Giter VIP home page Giter VIP logo

saito's People

Contributors

arpee avatar bearguy avatar escapedcat avatar mathiasarens avatar ramcas42 avatar trevelyan avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

saito's Issues

"Success" screen stays after the invite has expired.

Not sure if the title explains it. This is what I'm talking about:

image

If you look at the screenshot, there's no invite from that hash. (the other 2 are my alts)

Once the invite you've sent expires, that screen should go as well and the user should be sent back to the Arcade. You could also add a button to extend the invite.

Core Features

  • DNS replications

  • Block Compression

  • Peer Discovery

There is no winner.

We are throwing a server side error on game deletion. Not sure if this is causing any issues.

|node:6561) UnhandledPromiseRejectionWarning: Error: SQLITE_ERROR: no such column: winner
| (node:6561) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 70)

Just thought I would flag, rather than fix - as it might relate to something that is troubling folk.

@BearGuy @trevelyan

We cannot find a block on disk.... on chain reorganisation.

Chain Test 20180520

  1. Create a node and run it to generate cash
  2. Create a second node listing one as a peer.
  3. Add two as a peer for one (separate bug they won't synch if you don't)
  4. Create blocks on the chain by sending messages.
  5. Stop one and send messages to self on two to create blocks
  6. Stop two and start one and send messages in a loop to create blocks

Both nodes have 5 blocks but block 5 is different on each

  1. Restart one.
  2. Restart two.
  3. Send a transaction from one:

Error

START TIME: 1526824853109
Adding block 6 -> 1c31bed6ffd40e0df48c696f3ad839a8917d631da1bf629e8463ca54a527a125 1526823527616
UPDATING LONGEST CHAIN: 2 new |||||| 0 old 1
validate longest chain...
 ... unwind old chain
 ... validate block inputs and other stuff
 ... validate block inputs and other stuff
 ... validate block inputs and other stuff
FAILED TO VALIDATE SLIP: 591adcde0eca885d4a4a17ca06646b8566d20edaa4e4f8710279d65e017a93ba00136
{
    "add": "2242wmfGQiVrg3oUvSsLaziSudFdo6999f1FwWuVUMuGR",
    "amt": 36,
    "gt": 0,
    "bid": 5,
    "tid": 9,
    "sid": 1,
    "bhash": "adcde0eca885d4a4a17ca06646b8566d20edaa4e4f8710279d65e017a93ba001",
    "lc": 1,
    "ft": 0,
    "rn": 63
}
MY GBID: 1
 ... unwind old chain
We cannot find a block on disk that should exist in unwindChain

NB have tested in various combinations including creating one longer chain... which ever way - when a chain reorg is forced I get this error.

Node not syncing if no peers listed.

  1. Create a node and start to generate cash.
  2. Send messages to generate blocks.
  3. Add second node that lists one as a peer.

Two syncs.

  1. Stop one
  2. Send messages on two to generate blocks.
    6 Restart one.

Error
One does not add blocks from two.

escapedcat's notes on modules refactoring

Esacpedcat's Notes on Module Refactoring

To refactor the current compile/refresh/build approach I suggest the following improvements.
Those are just ideas and do not represent yet a final solution.

  • move bash scripts to npm-scripts to improve node environment handling
  • refactor modules to have their own node_modules, build-script to be independent of main script
  • main browser.js should lazy-load (dynamic import) modules to minimize startup footprint
  • modules should be activated through a config which is read by browser.js
  • modules should be handled as independent dependencies so later on third party modules (i.e. via npm) can use the same approach
  • a mono-repo approach can help to keep everything in one repo to keep dev-workflow easy but add versioning etc to all modules
    these can be used to help with a mono-repo approach:

later stage:

  • automatic changlog-creation should be added to main- and module-repos

Game wrongly shows the USSR as the winner

Happens when USSR loses via DEFCON. It says USSR won even if the log clearly shows DEFCON dropped on USSR's turn. Pls fix so Krom stops bullying me saying he won.

Screenshot attached:
image

Broken match from the beginning

Tried to play a match against Krom, the game started like this. Look at my log. Repeated Misile Envy, Mid War cards... Krom was playing from his phone and the game took a hell of a long time to start, like 15 mins.

No errors in console.
Last block: 25918 (I'm 26p6)

Screenshots attached:

image

image

node start.js throws error : reading options file

Command Line :
root@65b6e9b87e69:/home/saito/lib# node start.js

Error message :

Error Reading Options File
error: Error Reading Options File {"stack":"Error: ENOENT: no such file or directory, _open '/home/saito/lib/saito/../options'\_n    at Object.fs.openSync (fs.js:660:18)\n    at Object.fs.readFileSync (fs.js:565:33)\n    at Storage.loadOptions (/home/saito/lib/saito/storage.js:429:12)\n    at Storage.initialize (/home/saito/lib/saito/storage.js:87:8)\n    at initSaito (/home/saito/lib/start.js:67:13)\n    at Object.<anonymous> (/home/saito/lib/start.js:29:3)\n    at Module._compile (internal/modules/cjs/loader.js:654:30)\n    at Object.Module._extensions..js (internal/modules/cjs/loader.js:665:10)\n    at Module.load (internal/modules/cjs/loader.js:566:32)\n    at tryModuleLoad (internal/modules/cjs/loader.js:506:12)"}

I looked into lib/saito/storage.js at line 429,

fs.readFileSync(__dirname + '/../options', 'utf8', (err, data) => {

and in lib/ , options.conf exists instead of options .

Chess move showing up in TS log

I think this happened bc I had sent a Chess invite before I took Saitopore's TS game and then an Organic (that later played Krom) took it. Being able to close invites would resolve this.

image

Chain not updated on peer node.

Test - Chain Reorg

  1. Create two clean nodes
  2. Run node one
  3. Update Node two to list node one as a peer
  4. Run node two

Node two syncs

  1. Create blocks on node one

Node two syncs

  1. Create blocks on node two

Node one syncs

  1. Stop node two
  2. Create blocks on node one

ERROR
node two does not sync blocks from node one

  1. Create blocks on node one

New block is creted on node two but not recognised as part of longest chain.

Tokens disappearing from wallet

Tried sending an invite but it told me I didn't have enough tokens, which I found weird since I had sent another invite an hour earlier. In the main page, it showed me 0 tokens. Went to the faucet and claimed the tokens but didn't receive any. After reloading a couple times, my balance showed up again.

Screenshots attached:

image

image

Asia Scoring bug

Credit to Cardlinger for finding this bug.

He (USSR) controlled Taiwan and had Dominaton in Asia but the Scoring only gave him 1 vp, when it should have been 5. After I played China, thus cancelling Formosan, it went back to -5.

Moving Europe's VP counter

Currently, Europe's VP counter looks like this:

EuropeVP
As you can see there, it gets covered up by Sweden's and Finland's influence if there is any.

I recommend moving it a bit to the side to avoid this, same way SA's VP counter is a bit shifted to the right:

FixEuropeVP

Make back button undo influence

When placing influence, the back button should undo what you've already placed. This can be done rn refreshing the page but implementing it would improve the game experience.

Screenshot attached with an absolutely innecessary red circle.

BackButtonn

Tests are not included in the code base

I find in .gitignore

lib/test.js

which I suppose should be tests. Can anyone help remove this and add tests to the code base? It would be help build up the test coverage as well as make easier for new devs to understand.

Thanks!

Add the description of the Saito-created cards to the card selection

Right now there is no way for new users to know what our custom cards do unless they use them in a game. Yesterday I had a guy asking me if he could see their descriptions and I had to send each thru the chat.

I suggest adding a hoveover description, like in the game log, to the card selection screen. Either that or a '?' button besides each card.

image

Cancel button doesn't do anything

After you click a tile, hitting the cancel buttton should make the options disappear but it doesn't. You can only click another tile for them to move.

Arcade fails to show names

image
Screenshot_2019-08-29-09-25-16-237_com chrome beta

As you can see, arcade shows invites from hashes on one of my browsers when it should be showing names, as it does on mobile

Ghost invite from Gegitor

Weird bug, my main account's arcade shows a permanent invite from Gegitor that isn't actually there. Accepting it doesn't do anything. Screenshots below (2nd screenshot is incognito mode)

image

236

Confirmation Button in TS

I'm my opinion, this is our most requested feature. Everyone complaints about misclicks and it would help a lot with newbies.

Regarding its implementation, it could work like when you try couping a BG when DEFCON is 2. A box asking if you're sure that's what you wanna do. If you place influence, it could ask you to confirm after you're done placing it. Also, a "don't show this again" option would be wonderful.

Being able to see who your opponent is in-game

Same way as Chess does it. Auto-creating a private chat between the two upon entering the game might be a good idea as well since a lot of organics seem to come in and play with friends but never use the public chat

Showing people their hashes/names in the Arcade

Quoting Duke

"btw, something I realized recently
when people get here and don't register a name, or if they just refuse to register a name
they most likely don't know what their hash is
so when we call to them by using it in chat, they probably have no clue it's them we are talking about
wallets seem to get created with some tokens in already, so people don't really have a reason to go out of the arcade page and figure their own hashes anymore, so it might be worth putting something on the arcade that displays your hash/username"

Command Center Module

Refactored Email and Control Panel Application to be shipped by the foundation as a core app.

Saito Relay

User on chain key exchange to find and route between users.
Module to route traffic if nodes without public IP.
(This is useful for messaging, IoT etc)

DevOps and CI

Work on CI and Devops cannot begin before application deployment is decided.

  • Build process (do we provide compiled code, or do users compile?)
  • Linting
  • Comment2Documentation flow

China card giving an extra influence point

Krom (USSR) controlled Italy 0/2. I used China to break control and I still had 3 influence left. Ended up 3/2 when it should have been 2/2. Look at the log

Screenshot attached:
Italy

Chat behaving weird

Playing a match against Krom, My Chrome window started disconnecting randomly and I had to refresh. Tried sending a message thru the chat but it told me I was disconnected and it grayed out, nonetheless, I did receive the message in my alt account (which wasn't suffering from disconnection issues).

Screenshots attached, 26p6 is my main account.

Chrome
Chome

Edge
Edge

Wrong URL when redirecting from the faucet

image

When getting tokens from the faucet, it gives you a link to go back to the mail. Said link takes you to saito.tech/mail instead of apps.saito.network/mail which results in a 404

TS Freeze

Had a game against Saitopore freezing today, really important. Screenshot and report attached.

PS: Can you please add the hash under your opponent's name in the Player tab? Would make it easier to find transactions in the explorer. I couldn't ask Saitopore his hash since he had already left.

T006- Bug Report.docx

image

Font-Awesome

we are remote-loading a library we need to include in-house, at least for chrome extension purposes.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.