saitotech / saito-lite Goto Github PK

the newGame function sets the game id to a random number:

newGame(game_id = null) {

    if (game_id == null) { game_id = Math.random().toString(); }

Bur the save function rejects this:

if (this.game.id.length < 25) {
        console.log("Apparent Error: " + this.game.id);
        process.exit();
      }

in game template

https://github.com/SaitoTech/saito-lite/blob/master/lib/saito/network.js#L32

Pre-refresh:

Post-refresh:

Quoting Duke:

when having another window open on the arcade, same browser/wallet (was doing it for chat)
it desyncs games in a weird way, as in, you can play normally, but if you refresh after a certain point, it takes you back to the start of the game, or some arbitrary checkpoint of sorts

console looks normal on the side playing the game, but it looks like this on the one idling at the arcade

Should be noted that since chat doesn't work in-game, it's necessary to open the arcade in another window or tab, which causes games to stop functioning correctly in case of the latter.

Title is quite self-explanatory

Pre-refresh

Post-refresh

Screenshot:

Also, there's a spelling mistake in Pandemic. It says 'Boardgme' instead of 'Boardgame'.

Simple yet very important bug. US gets the bonus from Vietnam Revolts when playing China.

Take a look:

USSR headlines Vietnam Revolts and then USA plays the China card for 6 ops in Thailand, getting both China's and VR's bonuses.

This only affects China and doesn't apply to the rest of the cards:
Played all of East European Unrest's ops into SE Asia and didn't get the bonus

USSR gets to make Realignment rolls in European US controlled countries even if NATO is triggered, take a look at the log:

Also, NATO correctly stops coup attempts by the USSR but it also stops coup attempts by the US in US controlled countries:

Credit to the great JAN for this find. Korean War's code only counts the modifiers from Japan and Taiwan, thus making it possible for NK to win the war even if USA controls the 3 adjacent countries.

The Reformer's reforms aren't doing much reforming:

USSR headlines The Reformer and promptly coups Hungary on the following AR

Chess is really really broken. Games don't sync up with each other, you get to play as both sides and the log goes haywire.

This is supposed to be the same match:
1

2

Console shows the following errors:

Tried to play a match against Tele. When it started, this is what I saw:

Match didn't even load on Tele's side. Refreshing didn't fix it.

The reset your account button in the new arcade currently resets your account immediately as soon as you press it and it could pose a danger to people that have yet to backup their wallets.

Adding an "Are you sure you want to reset your account" prompt should be good enough to fix this!

Bugtesting game against myself. Couped Argentina as the US and the game got stuck at this screen:

The other player sees this tho. The OK button works fine and the game can be continued on his side so it must be an interface bug.

Took a look at the console and deleted this element:

Deleting it fixed the issue, game went back to normal and I kept on playing:

Starting a TS match sends you to this url: http://saito.io/twilight_struggle - which is blank.

Tried to start a match against myself so I sent an invite:

Mine's the first one (US+6)

This is what the arcade looks like on the incognito tab before refreshing:

Refreshing makes it show up correctly, but it shouldn't be necessary to reload the tab in order to see invites.

Various issue occur when attempting to sync blocks:

Not going to do a super thorough job documenting as there are many errors trying to sync to nodes. These should be obvious trying to run two nodes in tandem.

On node tying to sync:

(node:29602) UnhandledPromiseRejectionWarning: ReferenceError: tmperr is not defined
    at Peer.sendRequestWithCallback (/home/richardp/projects/saitotoo/saito-lite/lib/saito/peer.js:283:16)
    at Network.sendRequestWithCallback (/home/richardp/projects/saitotoo/saito-lite/lib/saito/network.js:283:21)
    at StorageCore.loadTransactionsByKeys (/home/richardp/projects/saitotoo/saito-lite/lib/saito/storage.js:119:22) 

Node being synced from:

edge case with unordered blocks...
block is not on the longest chain...
ERROR 620394: block does not exist on disk that should. terminating

Chat seems to work fine on the arcade but it doesn't show up at all when playing games.

Open four browsers with clean wallets with cash.

In one start any game.

Wait till the invitation is open in all browsers.

Accept the invitation in all non-inviting browsers.

All can join game - irrespective of number of players needed.

(This is only possible for a short time - as when the game has sufficient players and initialisation is started, the invitation is cleared correctly from the browser.)

Add function to send legacy email.

Title explains it. Zoom works fine, everything is clickable without issues but the map itself can't be moved.

GIF attached:

Clear browser and open the AppStore. Select a module to install and click "install". The server will not successfully compile the bundle.

Something about file paths being incorrect, etc.

Note -- correct design should reflect the possibility that multiple users will attempt to create bundles at the same time. All modules should be unzipped into a temporary folder specific to the bundle being compiled -- not a shared folder "mods".

Two instances of Brush War succeeding on impossible odds. -5 modifier on the first case and -4 on the second. It isn't possible to roll 3-6

If USSR controls 9+ countries in Western Europe, triggering Marshall Plan causes the game to get stuck. Very unlikely to happen but a bug nonetheless.

In this case, I triggered Marshall as the USSR and the game couldn't be advanced further from the following screen

Take a look at the log. First, USSR triggers Decolonization and places 1 each in Somalia, Nigeria, Burma and Indonesia. On USSR's following AR, They get to place inf in any African or SE Asian country even if there's no adjacency.

In this case I played Warsaw Pact for 3 ops and placed 1 each in Thailand, Zaire and SE African States.

Remember this old guy? Well it's back and it wants blood.

The card works as intended, you can take out 3 influence but the log only shows 2.

Screenshots attached:

Pre-Soc Gov. Look at Italy and WG:

Post-Soc Gov. Look at the log:

Bear Trap forced me to discard a card or play ME Scoring, which showed up twice in my hand. Seems to be only visual, since I played the card and everything went back to normal. SHould be noted that it only happens during Bear Trap (maybe Quagmire too, will check) and not during regular gameplay.

Right now the US is able to ignore adjacency in Western Europe.

Take a look, placed 4 influence in 4 countries without prior adjacency:

Take a look at the following screenshots:

When someone sends a message, it shows up a bunch of times on my chat. I seem to be the only one affected and refreshing does fix it but it is a bug nonetheless. Using Chrome

add more info about network in logs

Tucho's here, let's kill some bugs.

Clicking on http://saito.io/chat/ sends you to a blank page where you can't do anything

Screenshot attached:

Tried to cancel a game against Telechris but couldn't. Same happens to him.

This is what the console looks like rn:

Also uploaded the whole console so you can take a look at it if you want to:
WbConsole.txt

Well this one is critical lol.

Sent an invite and took it using Incognito to test the new arcade but this really subtle 404 greeted me:

Avatars work too, but having both avatars and names would improve it.

Tucho's fantastic and super complex suggestion:

Turning this

Into this

Added identicons and cleaned up UI for visibility ad niceness.

Not sure how to word this one so I'm just gonna gif it:

On Firefox

On Chrome

As you can see, even if I don't click anyhting at all, the Settings morph into the mail.

Title. None of the VP counters work. Hovering the mouse over them doesn't show you the VPs

Proposing adding a delete script to deploy - wanting to verify what we should delete on chain reset...

  rm -f ./data/explorer.sq3

is all I am seeing now.

Tried to send myself an email. Everything seems to work fine in the email app, but when you hit 'send', nothing happens. Both the regular Send button and the Send Saito button have no effect whatsoever.

Title. You can't see the name (or the address) of your opponent when inside a Chess match

Clicking on the Backup Wallet button does nothing. Shouldn't it download a .JSON file?

Arcade has been completely dead today. Games can't be started. Invites are dead upon accepting, they all just freeze like this.

Also, games remain on the arcade even if someone takes them so the arcade gets cluttered up with dead invites. Resetting wallets also doesn't fix the issues.

• Transaction SQL
• Navigation
• CSS

comment what this mapping is
https://github.com/SaitoTech/saito-lite/blob/master/lib/saito/blockchain.js#L868

Only way to access it on mobile is going to saito.io/chat

Take a look, this is the removed pile before my headline:

Now, afterwards. I decided to headline Truman :
Discard pile:

Removed pile:

As we can see here, the ol' Truman shows up in both the removed and discarded piles which shouldn't happen. This happens to all the starred the events, not only Truman.

The good ol' Ortega has no option to skip the coup attempt, which can be taken advantage of by the US if CMC is active, thus leading to USSR suicide.