saket / dank Goto Github PK

Is it fine to have the API key public?
https://github.com/saket/Dank/blob/master/app/src/main/java/me/saket/dank/di/DankApi.java#L31

I love the look and feel of the app. However when using it on my Samsung Galaxy Tablet, it'll randomly crash. At first I thought it may be happening when loading the next page while browsing, but earlier it also crashed when just reading the comments in a post.

The current deep link package checker implementation checks for the official YouTube app being present. Many users might use third-party clients/MODs.
An Intent for those can be fired using startActivity(new Intent(Intent.ACTION_VIEW, Uri.parse("vnd.youtube://"+Video_Id))); as a fallback if YouTube app is not installed.

What are your thoughts on this?

Hey there, with Dank being sunset and the source code being open up to the public it's a good idea to attach a license to the project.

04-13 12:09:46.451 7093-7093/me.saket.dank.debug E/AndroidRuntime: FATAL EXCEPTION: main
Process: me.saket.dank.debug, PID: 7093
java.lang.NoSuchFieldError: No instance field qs of type Lio/reactivex/internal/fuseable/QueueDisposable; in class Lcom/tspoon/traceur/ObservableOnAssembly$OnAssemblyObserver; or its superclasses (declaration of 'com.tspoon.traceur.ObservableOnAssembly$OnAssemblyObserver' appears in /data/app/me.saket.dank.debug-1/base.apk:classes3.dex)
at com.tspoon.traceur.ObservableOnAssembly$OnAssemblyObserver.requestFusion(ObservableOnAssembly.java:67)
at io.reactivex.internal.operators.observable.ObservableConcatMap$ConcatMapDelayErrorObserver.onSubscribe(ObservableConcatMap.java:322)
at io.reactivex.internal.observers.BasicFuseableObserver.onSubscribe(BasicFuseableObserver.java:66)
at io.reactivex.internal.operators.observable.ObservableFromArray.subscribeActual(ObservableFromArray.java:31)
at io.reactivex.Observable.subscribe(Observable.java:12246)
at com.tspoon.traceur.ObservableOnAssembly.subscribeActual(ObservableOnAssembly.java:43)
at io.reactivex.Observable.subscribe(Observable.java:12246)
at io.reactivex.internal.operators.observable.ObservableConcatMap.subscribeActual(ObservableConcatMap.java:55)
at io.reactivex.Observable.subscribe(Observable.java:12246)
at com.tspoon.traceur.ObservableOnAssembly.subscribeActual(ObservableOnAssembly.java:43)
at io.reactivex.Observable.subscribe(Observable.java:12246)
at io.reactivex.Observable.subscribe(Observable.java:12232)
at io.reactivex.Observable.subscribe(Observable.java:12109)
at me.saket.dank.DankApplication.onCreate(DankApplication.java:87)
at android.app.Instrumentation.callApplicationOnCreate(Instrumentation.java:1037)
at android.app.ActivityThread.handleBindApplication(ActivityThread.java:6422)
at android.app.ActivityThread.access$1800(ActivityThread.java:229)
at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1887)
at android.os.Handler.dispatchMessage(Handler.java:102)
at android.os.Looper.loop(Looper.java:148)
at android.app.ActivityThread.main(ActivityThread.java:7325)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1230)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1120)

I decided to parse markdown in the app directly because I thought using custom spans would be easier if the app was in control of parsing markdown. That was a correct assumption, but I soon realized it was a bad idea because markdown on Reddit is a gigantic pile of broken markdown syntaxes. I tried correcting some of them in the app using regex, but is like a losing battle.

I'd like to switch back to using the "processed" markdown HTML that Reddit sends. Android offers an HTML parsing using Html.toHtml(), but it does not let us use custom spans. We'll have to figure out a way to do that.

i am using this awesome app on my samsung galaxy note 3 SM-N9005 running unofficial LOS16. i know you are not working anymore on this app. but it would be really great if you at least fix the crash i am facing when i am browsing reddit. i am attaching a log file below. again thanks for your great work!

2019-01-04-19-58-35.txt

Hi!
I've been using the app for couple of days now, and I must say I'm impressed, well done! But I noticed that the app crashes when scrolling very far down the list. According to logcat, it's caused by SubredditSubmissionsAdapter#findCollidingIds.

I didn't go through the code so I just silenced the exception in a fork. For now I haven't faced any side effects, but have a look at the issue and possibly fix it when you have time.

Thanks