salesforcelabs / fluentassert Goto Github PK

Consider:

• isRecordType()
• hasError()

Use SObject.get(String) to build something like

Fluent__Assert.that(sobject)
              .extracting("AccoutNumber, SomeOtherString__c")
              .containsExactly(new List<String>{'RealAccountNumber', 'Real Value of SOSc'}
              ...
              back()

Type-specific getters

Fluent__Assert.that(sobject)
              .getAsInteger(".....") // Returns IntegerAssertNavigator
              ...
              .back()

Hi
I was trying to use isRecordType from SObject and I found this issue -

I created account like this -
Id customerRecTypeId = Schema.SObjectType.Account.getRecordTypeInfosByName().get('Customer').getRecordTypeId();
Account acc = new Account(
Name = 'TEST ACCOUNT',
Source_ID__c = 'ACCOUNT 001',
recordTypeId = customerRecTypeId
);

insert ACC;

Fluent.Assert.that(acc).isRecordType('Customer') -> This fails
But
Fluent.Assert.that(acc).isRecordType(customerRecTypeId) -> This passes.

So it looks like if a record type is set during record creation then it compares against record type id not record type developer name.

I also looked into your code

global SObjectAssert isRecordType(String developerName) {
        notNull(actual, 'actual');
        notNull(developerName, 'developerName');

        **String actualRecordTypeDevName = actual.isSet('RecordTypeId') ? (String) actual.get('RecordTypeId') :** SObjectTypeUtil.getDefaultRecordTypeInfo(Schema.SObjectType.Account).getDeveloperName();
        assert(developerName == actualRecordTypeDevName, 'Expected RecordType to be \'{0}\' but found \'{0}\'', new List<Object> {developerName, actualRecordTypeDevName});

        return this;
    } 

It looks like if record type id is set then you are assigning that id to actualRecordTypeDevName . I was expecting you would fetch the developer name from that record type id and use that to compare the values.

Is this an expected behaviour ?