salleman33 / reservation Goto Github PK

Hello, im having a trouble with the check in/out option, everytime i make a reservation the check in/out it came allready with the date, both of them.. (19-01-2038 à 03:14:07).

Could you help ?

When I force the automatic task it sends me to "/front/crontask.form.php" and stays there, all white, when I go back the task is stuck at "Next run: Running" and I never receive any email.

I should get an email for this one right?

we use the Reseration plugin in GLPI version 9.4. is the plugin also compatible with version 9.5 or is there a timetable for adaptation to version 9.5? Thanks a lot.

hello Sylvain,
we would like to contact you for a collaboration. we need to have a version of your plugin with a few more (paied) features and we would like to know if it is possible for you to do this paied consultancy .
contact me at
spam at initiativa.it

thank you

davide

Its possible to add the name of the technician who made a checkout of an reserved item?

This issue may go beyond this specific case but I encountered it when trying to add an item to a reservation. The sql error was due to the comment of the reservation having the special character ' which was interpreted as an end of string

Hi,

It would be nice if you create tag for older GLPI versions. It would be easier for users with older GLPI to install your plugins.

Since http://plugins.glpi-project.org/#/ redirect to your GitHub, user can be lost if they don't find versions they need.

If it's not possible, at least put link to older versions (glpi forge ?)

Regards,
Gilles Dubois.

Hi,

this is not really an issue, but I wonder what the 'Moves' arrows are for.

I can't click them and I don't really get what they mean.

BTW your plugin is great, we love it :)

Thank you in advance!

Hello!

I noticed that the reservations are also displayed in a sub-entity, although the corresponding users are not authorised to read this device category and the corresponding devices are not visible in the sub-entity.

Can this be changed?

The background is that we want to give a branch that has a sub-entity the possibility to manage its own device reservations as well.

Now, however, they also see our reservations from the root entity, even though they can't edit them.

If reservation is disabled on an item, it cannot be put in a category? I wonder if this should not be changed so that every item can be put in a category ?

Hello Sylvain,
We discover your plugin and want to use it in place of the reservation tool.
But we don't have found where the old reservations are stored. When we check the checkout, the reservation disappear and we don't find its anywhere.
Are they deleted ? Or can we see it in some options ?
We're thinking very useful to see who was the last people who take some material.
Thanks.

Bonjour, serait il possible de créer une notification spécialement pour la fonction checkin car actuellement elle fait parti de la notification de modification de la réservation et cela serait plus pratique de les séparer.

Merci.

Cette fonctionnalité fonctionnais bien en version 1.4.3.
Mais depuis que je suis passé à la version du plugin 2.3.3, les ordinateurs qui passent en expiré, au lieu de passer en rouge et d'être prolongé par exemple à chaque pas de 5 minutes, la réservation est automatiquement considéré comme rendu.

Comment remédier à cela ?

Merci

Hi,

I use the GLPI 9.4 package on a Synology NAS.

You plugin work correctly except that I can't show it from the Simplified interface. My goal is : when a user login GLPI, it's your plugin that show up in first.

Is it possible?

Thanks for you help.

Tepitepo

Steps to Reproduce

1. Migrate GLPI to 10.0.2 version
2. Reinstall the last version of reservation plugin
3. Open tab ""Matériels disponibles" (Available items)

Expected Behaviour

We should see items available for reservation and we should be able to reserve them.

Observed Behaviour

The tab is empty.
The available items are still visible (and reservable) via Tools->Reservations

• GLPI version: 10.0.2
• Reservation plugin version: 2.3.8
• Operating System and version : Debian 11.3
• Web server version and php version : apache2 : 2.4.54-1~deb11u1, php : 7.4.30

Analysis

I see that some of issues are written in French, so I will use French for this issue. If it is not acceptable, I'm sorry I'll rewrite it in English.
Now the problem.

Nous avons migré récemment notre GLPI depuis la version 9.5 sur la version 10.0.2

Au moment de la migration nous avons également mis à jour tous les plugins, dont le plugin reservation.

L'installation du plugin s'est bien passé, mais maintenant nous avons un petit problème.

Au fait le volet "Matériels disponibles" est vide. Est-ce que c'est normal ?

Je joins ici un petit screenshot.

Nous pourrons toujours aller dans le menu "Outils"-> Réservations. On voit là-bas la liste du matériel disponible pour la réservation, on peut les réserver et ils vont apparaitre dans "Réservations actuelles", mais on ne peut plus le faire depuis l'onglet "Matériels disponibles".

Si j'active le mode debug sur la page de cet onglet, je vois :

1. Deux fois :

PHP Warning (2): Declaration of PluginReservationConfig::showForm() should be compatible with CommonDBTM::showForm($ID, array $options = Array) in /usr/share/glpi/plugins/reservation/inc/config.class.php at line 46

2. Puis beaucoup des erreurs :

SQL Error "1054": Unknown column 'glpi_reservationitems.is_deleted' in 'where clause' in query "SELECT `glpi_reservationitems`.`id`, `glpi_reservationitems`.`comment`, `glpi_computers`.`name` AS name, `glpi_computers`.`entities_id` AS entities_id, `glpi_reservationitems`.`items_id` AS items_id FROM `glpi_reservationitems` INNER JOIN `glpi_computers` ON (`glpi_reservationitems`.`itemtype` = 'Computer' AND `glpi_reservationitems`.`items_id` = `glpi_computers`.`id`) LEFT JOIN `glpi_reservations` ON (`glpi_reservationitems`.`id` = `glpi_reservations`.`reservationitems_id` AND '2022-08-04 17:33:46' < `glpi_reservations`.`end` AND '2022-08-04 20:00:00' > `glpi_reservations`.`begin`) WHERE `glpi_reservationitems`.`is_active` = '1' AND `glpi_reservationitems`.`is_deleted` = '0' AND `glpi_computers`.`is_deleted` = '0' AND `glpi_reservations`.`id` IS NULL AND ( `glpi_computers`.`entities_id` IN ('0') ) ORDER BY `glpi_computers`.`entities_id`, `glpi_computers`.`name` ASC"

Je ne sais pas si ca aide.

For now, when a conflict occurs, only the user of the new reservation that is being delayed is notified
I would like to add a way to also notify the user of the conflicting previous reservations and allow the notification translation to handle the name of both users so that they know who is the other one

The 2.1.2 release have define('PLUGIN_VERSION', '2.1.1'); in setup.php.

Regards

v2.1.1 fixed a problem with sendMailLateReservations.
Now I see it only sends a notification that the reservation is ending to: Admin, or different profiles (Admin, Hotline, Technician, etc...) but the "Requester" as in the "New Reservation" Notification.
It would be good to have the user notified.

Bonjour,

Deja merci pour ce plugin tres pratique.

Je cherche a l'utiliser pour ue notion que je ne retrouve pas dans GLPI ni dans d'autre plugin : la dotation de matériel pour un nouvel employé. Cette dotation cour de son entrée dans la structure jusqu'au départ de la personne, donc sans date de fin défini dès le début.

Il y a bien le champs "utilisateur" ou "usager" mais ils sont mis a jour a chaque inventaire automatique, "fusion inventory" dans mon cas, et finalement c'est la derniere personne connecté lors de l'inventaire qui apparait dans ces champs.

Alors que moi je cherche a faire une attribution administrative qui me permetrait de gérer un circuit de départ pour le restitution de materiel.
Bref un besoin assez proche du service que rend le plugin reservation mais avec une option "sans date de fin connu".

un peut comme dans cette discution : https://forum.glpi-project.org/viewtopic.php?id=158662

Est il enviseageable d'ajouter une case a cocher "reservation longue durée" ou "sans date de fin" ou "dotation" qui excluerais de la vérification de la date de fin des resa pour les notifcations, ces materiels attibuées.
Le jour on l'equipe info connait la date de départ de l'utilisateurs, elle renseigne la date de fin de reservation, ce qui décoche l'option "dotation" et nous lance les notif si la personne ne rend pas le matos en temps et heures ?

Cordialement,
vlepetit

Hi,
i already translated the plugin for PT-BR and put the new files on /locales/ folder.
But still in english.

How to do for work the translation?

Download for the translation:
reservation-pt_BR.zip

I find it convenient to display my own reservations on top of others to easy access.

I developed it like the capture below, on another table because it was the easiest way.

Do you agree with that?
Do you want me to do it differently?

We have made a reservation for an object. But we made a mistake for this object in a wrong category and have to delete it and create another in another category.
Actually our reservation show a reservation with the user account but any element in the user page.
In the reservation plugin, there is a problem because we don't see the others reservation. It seems like the empty element stop to list the others.

Some screenshots to show our problem.

Bonjour. Je n'arrive pas à installer le plugin réservation. Je suis dans la dernière version de GLPI 9.3. Message d'erreur lors de l'activation du plugin : - Erreur durant l'éxecution de la requête : INSERT INTO glpi_plugin_reservation_configs (name , value) VALUES ("mode_auto",0), ("conflict_action","delete") - L'erreur est Duplicate entry 'mode_auto' for key 'name'
Quelqu'un peut-il m'aider ? D'avance merci de votre retour

Bonjour,

Je souhaiterais utiliser votre plugin pour créer une gestion des disponibilité des postes de travail dans l'entreprise dans laquelle je travaille. Pour faciliter la visibilité je souhaiterais extraire les informations relatives aux réservations en utilisant l'API que vous avez développé pour afficher les afficher sous forme de plan avec les tables et noms des employées.

Néanmoins j'ai quelques problèmes dans l'utilisation de l'API :

• j'arrive à sortir l'ensemble des réservations (GET ...apirest.php/reservation) mais je n'arrive pas à utiliser les fonctions présentent dans le fichier api.php (currentReservation, nextReservation ... ), ces fonctions pourraient répondre à un besoin de mon entreprise
• en modifiant un peu le fichier api.php je me suis rendu compte que mes modifications ne changeaient pas le comportement de l'api (le fichier api.php est-il utilisé par l'api ou est-ce un autre ?)
• en essayant de comprendre le fichier api.php je n'ai pas réussi à trouver la référence de la bibliothèque utilisé Glpi\Api\API utilisé pour la classe PluginReservationApi

Hi!

Could you please help me? As soon as I click on Plugins-Reservation it shows:

There was a problem loading
Please check GLPI´s Logs or contatct admin.

Any ideas please?

Best Regards

Hello,

I think it's useful to have a way to edit multiple reservations at once.

I plan to implement it like the picture below.
Adding a new link to edit the groups already formed when they have the same dates.
And then use a page, like the "edit" one, that deals with multiple items, where we can update the begin/end date.

Do you have an opinion about that?

Hi,

I am on GLPI 9.3.1 and reservation 2.1.0

When i want to launch glpi sendMailLateReservations automatique schedule task i had blanck screen on my web browser and this error log in /var/log/apache2/error.log

PHP Fatal error: Uncaught Error: Call to undefined method PluginReservationConfig::getConfigurationWeek() in /var/www/glpi/plugins/reservation/inc/task.class.php:144\nStack trace:\n#0 /var/www/glpi/plugins/reservation/inc/task.class.php(130): PluginReservationTask::sendMailLateReservations(Object(CronTask))\n#1 /var/www/glpi/inc/crontask.class.php(837): PluginReservationTask::cronSendMailLateReservations(Object(CronTask))\n#2 /var/www/glpi/front/crontask.form.php(49): CronTask::launch(-1, 1, 'sendMailLateRes...')\n#3 {main}\n thrown in /var/www/glpi/plugins/reservation/inc/task.class.php on line 144, referer: https://support.univ-psl.fr/front/crontask.form.php?id=43

Could you help me to resolve this issue, please.

Regards,
vlepetit

Steps to Reproduce

Hi,

I have only 3 reservation activated, 2 computers, and 1 reservation from Room Plugin

1. Install and active Room Plugin, create a Room and active Reservation.
2. Make a reservation of the Room created before, do a check-in, without a check-out
3. Go to uninstall Plugin Room.
4. Go to Plugins > Reservation, the error appears:

PHP Notice (8): Undefined index: id in /var/www/html/glpi/plugins/reservation/inc/menu.class.php at line 305
PHP Notice (8): Undefined index: name in /var/www/html/glpi/plugins/reservation/inc/menu.class.php at line 305
PHP Notice (8): Undefined index: realname in /var/www/html/glpi/plugins/reservation/inc/menu.class.php at line 305
PHP Notice (8): Undefined index: firstname in /var/www/html/glpi/plugins/reservation/inc/menu.class.php at line 305

PHP Notice (8): Trying to get property 'fields' of non-object in /var/www/html/glpi/plugins/reservation/inc/menu.class.php at line 328
PHP Notice (8): Trying to access array offset on value of type null in /var/www/html/glpi/plugins/reservation/inc/menu.class.php at line 328
Uncaught Exception Error: Call to a member function getFormURLWithID() on bool in /var/www/html/glpi/plugins/reservation/inc/menu.class.php at line 328

Expected Behaviour

When a reservation, as a computer, o a room from room's plugin, is uninstall, this should not affect the use of the reservation's plugin. The plugin should work with assets that actually are still there.

Observed Behaviour

I have to install Room plugin again, and create a room, and activate the reservation of that room, for the plugin working:

Context

As the plugin room was uninstalled, I have to install again, create a room, make a reservation, and thus the reservation plugins works again.

• GLPI version: 9.5.7
• Reservation plugin version: 2.3.8
• Operating System and version : Ubuntu 20.4
• Web server version and php version : Apache 7.4

Glpi version 9.2.4
Plugin resources version 1.4.1
Good morning
I have a Question:
Is the plugin vulnerable to Log4shell (CVE-2021-44228)?

Thank you in advance for your answer

Regards

I'm having problems with the reservation plugin version 2.3.3. It stopped working, on the plugins administration screen, this one has an error / clear status. I try to click the button to do the cleaning, the screen keeps loading and error 504 Gateway Time-Out returns.

How can I resolve this case? Thank you very much.

We have noticed that the plugin has not yet been properly translated into German.

Maybe we can help here.

Is there any way that we can work on a translation ourselves? How is thisimplemented into the plugin?

Sorry for the beginner's question, but we are still making our first experiences in GLPI ourselves.

Hello,

The plugin Reservation 2.3.5 does not work any more after upgrade to GLPI 9.5.5 with PHP 8.0.12. I'm getting a white screen when I connect to https://myserver/glpi/plugins/reservation/front/menu.php both with firefox 89.0.2 / firefox 93.0 and alos chromium 87.0.4280.66.

This file /var/www/html/glpi/files/_log/php-errors.log tells :

[2021-10-27 14:48:32] glpiphplog.CRITICAL: *** Uncaught Exception TypeError: Unsupported operand types: array & int in /var/www/html/glpi/inc/session.class.php at line 1031
Backtrace :
inc/session.class.php:857 Session::haveRight()
plugins/reservation/front/menu.php:21 Session::checkRight()

The debug on GUI tells :

Uncaught Exception TypeError: Unsupported operand types: array & int in /var/www/html/glpi/inc/session.class.php at line 1031

Thank you for your attention ! With best regards

Hi !!

My notification recaps who reserved what item so I've put the tag ##reservation.item## in my html code but it's not translated in the notification email. The other tags work just fine, it's the only one not working.

Bonjour,

L'installation du plugin ne fonctionne pas sur la version 9.5.1 de GLPI.
Le fichier php-errors.log marque
glpiphplog.ERROR: Plugin::getInfo() in /var/www/glpi9.5.1/inc/plugin.class.php line 1394
plugin_version_reservation-2.3.3 method must be defined! {"user":"260@srvglpi"}

Merci de votre aide.

I've set the configuration to delay next reservation when the current reservation delays on its checkout, but the plug-in keeps deleting the next reservation. I'm currently using the latest plug-in version. Is there a fix? We're currently seeing the possibility to implement this plug-in in our IT sector but this inconsistency is critical. Thanks in advance!

hy,
it's possible to update de plugin fo 6.4 version as soon as possible
thanks a lot

API-Calls not working:
PHP Fatal error: Uncaught Error: Class 'API' not found in /var/www/glpi-9.5.2/plugins/reservation/inc/api.php:9

Hi!

We're testing the GLPI 10 beta and the plugin won't work properly.

Is it planned to release an update for 10.0?

after upgrade to glpi 9.5.2 and upgrade plugin reservation occurred error on open plugin.
this error:

Deprecated: Use DBmysql::fetchAssoc() in C:\xampp\htdocs\glpi\inc\toolbox.class.php on line 632

Bonjour,

Depuis la migration de mon GLPI (v0.90.3 > v0.93) et la mise à jour du plugin Réservation (v1.3.3 > v2.1.0), je ne peux plus installer ce dernier. J'ai une erreur de non conformité CSRF et je ne peux que nettoyer ce plugin.
Petite précision, avant la migration de GLPI, j'ai désinstallé le plugin Réservation, afin de faire une réinstallation propre.

Une idée de l'origine de mon problème ?

(GLPI sur serveur DEBIAN)

Hi,

I use the latest Reservation plugin
Glpi: 9.3.2
I have an issue with using API to get Reservation list
My user (this which I'am using to connect through the API) has full permission to manage reservations in his profile. And when I'am making Reservations in GUI, there isn't any problems

But, when I'am using API with for example
uri = 'http://pathto/glpi/apirest.php/PluginReservationReservation/getAllReservations'
I cannot get those data because of Error Right Missing

Can you help me with this problem ?

GLPI: 9.3.2
Plugin: 2.1.2

I have problem with notifiy requester by email from Reservation events.
For every possible event ex. Expired, Deleted, New etc.

I enabled in requester user profile "notifications for my changes" - nothing happened.
With new reservation I notify group, and that works fine. I see in queue that new reservation emails will be send to users from group, but not for requester.

I tryed almost everything, do you have any idea?
Thanks for help

réservation non supprimée lorsqu’un utilisateur crée une autre réservation pour le même matériel

I need manual for install this plugins with send error when rename file in /var/www/html/glpi/plugins :

Bareword "reservation" not allowed while "strict subs" in use at (user-supplied code) line 3.

Who is the problem ?

Hello

I would like create Custom Categories but the devices are invisable. I can't see any devices on the Configure Site.

Bonjour,

Je viens de m'apercevoir qu'il est possible d'acquiter le matériel lorsque celui ci n'est pas encore arrivé à la fin de la réservation mais lorsque celui ci est est dépassé le matériel disparait de la liste. Comment puis-je voir toutes les réservations dont le matériel n'est pas rendu svp.

Merci

Bonjour,
Je n'arrive pas a installer le plugins, j'ai la version 9.4.5 de glpi et j'ai essayé d'installer la version 2.2.0 et 2.0.0-rc2 dans mon dossier plugin mais ils ne sont toujours pas visible dans la liste des plugins à installer sur GLPI.

PS : j'ai essayé avec d'autre version mais cela ne fonctionne pas non plus

Pouvez vous m'aider svp
Merci beaucoup

Deprecated: Use DBmysql::fetchAssoc() in C:\xampp\htdocs\glpi\inc\toolbox.class.php on line 632

Voici le message d'erreur affiché sur toute la page...

Glpi 9.5.2

Bonjour,

Je viens de mettre a jour notre GLPI en version 9.5.7 avec une version PHP 8.0.
J'ai installé le plugins reservation mais il m'est impossible de l'utiliser.
Lorsque je souhaite accéder à la partie Configuration, j'obtiens une page blanche.

Est ce que le plugin est compatible avec php 8;0 ?

Merci de votre retour.
Bonne journée

• GLPI version:
• Reservation plugin version: 2.3.8
• Operating System and version : Ubuntu 20.4
• Web server version and php version : 8.0

Analysis

Hi

You may improve the upgrade code of the plugin with the migration class. This class give methods to add / change / remove columns and rename tables.