saltstack-formulas / nagios-formula Goto Github PK

View Code? Open in Web Editor NEW

21.0 36.0 73.0 141 KB

nagios-formula

Home Page: http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html

License: Other

SaltStack 76.12% HTML 23.88%

nagios-formula's Introduction

nagios

Formulas to set up and configure nagios server and nrpe agent

Note

See the full Salt Formulas installation and usage instructions.

Available states

`nagios`

Install the nagios server, nagios plugins, nrpe plugin and server packages.

`nagios.plugins`

Install nagios plugins.

`nagios.server`

Install the nagios package and start the nagios service.

nagios.server.dynamic ------------------------

Generate service and command definitions based on pillar data.

`nagios.nrpe`

Install the nrpe plugin and server.

`nagios.nrpe.server`

Install the nrpe server.

`nagios.nrpe.plugin`

Install the nrpe plugin.

`nagios.nrpe.dynamic`

(Debian only) Generate command definitions and optionally install non-packaged plugins based on pillar data.

`nagios.nsca.client`

Install the nsca client.

nagios-formula's People

Contributors

Stargazers

Watchers

nagios-formula's Issues

[BUG] E: Unable to locate package u"nagios-plugins-contrib"

Your setup

Formula commit hash / release tag

fb96ae0

Bug details

Describe the bug

Details of the bug are upstream saltstack/salt#55620 notifying here in case this is not an upstream bug

All other sections of the bug report are on that issue.

nagios.nrpe.server state fails due to undefined cfg_dir

Ever since 5268b10 got merged in #16 nagios.nrpe.server can't be used as it causes:

some.minion.tld:
    Data failed to compile:
----------
    Rendering SLS 'base:nagios.nrpe.server' failed: Jinja variable 'dict object' has no attribute 'cfg_dir'

It would be great if this could be rectified as this breaks existing setups and alienates new users.

Does not work on Debian

If you use this formula on Debian you get:

# salt '*' state.highstate test=True
foo:
    Data failed to compile:
----------
    Rendering SLS "base:nagios.nrpe" failed: Jinja error: Undefined is not JSON serializable
Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/salt/utils/templates.py", line 261, in render_jinja_tmpl
    output = jinja_env.from_string(tmplstr).render(**unicode_context)
  File "/usr/lib/python2.7/dist-packages/jinja2/environment.py", line 894, in render
    return self.environment.handle_exception(exc_info, True)
  File "<template>", line 6, in top-level template code
  File "/usr/lib/python2.7/dist-packages/salt/utils/jinja.py", line 302, in format_json
    return Markup(json.dumps(value, sort_keys=True).strip())
  File "/usr/lib/python2.7/json/__init__.py", line 238, in dumps
    **kw).encode(obj)
  File "/usr/lib/python2.7/json/encoder.py", line 202, in encode
    chunks = list(chunks)
  File "/usr/lib/python2.7/json/encoder.py", line 435, in _iterencode
    o = _default(o)
  File "/usr/lib/python2.7/json/encoder.py", line 177, in default
    raise TypeError(repr(o) + " is not JSON serializable")
TypeError: Undefined is not JSON serializable

; line 6

---
{% from "nagios/nrpe/map.jinja" import map with context %}

nrpe:
  pkg:
    - installed
    - pkgs: {{ map.pkgs|json }}    <======================
  service:
    - running
    - name: {{ map.service }}
    - enable: true
  group:
[...]

---

A comparable error is thrown for nagios or nagios.server and it is obvious that this formula does not support Debian at all. It should also be noted that the configuration directories, the created user and groups along with their respective home directories are not appropriate on Debian and that the corresponding sections in this formula should be adapted.

Split file.recurse of plugins from nrpe.plugin

nagios-formula/nagios/nrpe/plugin.sls

Lines 3 to 13 in 14737d3

 nrpe-plugin-package: 

  pkg.installed: 

  - name: {{ nrpe.plugin }} 

 {% if 'nagios/nrpe/files/plugins' in salt['cp.list_master_dirs']() %} 

 {{ nrpe.plugin_dir }}: 

  file.recurse: 

  - source: salt://nagios/nrpe/files/plugins/ 

  - clean: False 

  - file_mode: 0755 

 {% endif %}

These two states do not belong together. The NRPE plugin goes on the Nagios server, and the additional plugins belong on the monitored hosts.

I propose moving lines 7-13 to nagios.plugins, although that would obviously require a change for anyone depending on the current behaviour.

dont_blame_nrpe should be taken from pillar

dont_blame_nrpe={{ nrpe.get('dont_blame_nrpe', '0') }}

Question about pkg source

I'm new to both arch and salt, so maybe I'm missing something here... When I get to this line [1] to install the nagios package, I get an error saying that the package cannot be found. It looks like the package is in the AUR, but not community or any other official repo, so pacman won't install it. Is there a way to add AUR to my pacman sources? Or some other way to use this?

Thanks,
Patrick

[1] https://github.com/saltstack-formulas/nagios-formula/blob/master/nagios/server/init.sls#L3

Ship nrpe_commands to included subfolder

It would be nice to have the nrpe_commands to be shipped to one (or multiple) separate files in /etc/nagios/nrpe.d

Use of cfg_dir on Redhat

Hello,

In https://github.com/saltstack-formulas/nagios-formula/blob/master/nagios/map.jinja#L134, cfg_dir is not defined.

Is there a reason for not having this variable ?
If none, would it be possible to have it defined to /etc/nrpe.d ?

Thank you

Server: Red Hat Enterprise Linux Server release 7.5 (Maipo)
nrpe: nrpe-2.15-4.2.el7rhgs.x86_64

nagios_server_log is referenced by not defined

nagios/server/init.sls has a reference to nagios_server_log, but it is not defined for any arch.

Keep nrpe_local.cfg include

On debian stretch the following line is removed by the formula :

include=/etc/nagios/nrpe_local.cfg

It would be nice to keep it (or have a way to add it via pillars)

Illegal characters in Pillar file

I am using the sample Pillar file for setting up Nagios for a small demo. I think there are two entries in Pillar.example which will cause a pillar render error. After removing those two, all works fine. I am using the version: salt 2015.8.1 (Beryllium)

Error:

2015-10-30 05:30:48,910 [salt.pillar      ][CRITICAL][6715] Pillar render error: Rendering SLS 'nagios' failed. Please see master log for details.
2015-10-30 05:30:48,909 [salt.pillar      ][CRITICAL][6717] Rendering SLS 'nagios' failed, render error:
found character '`' that cannot start any token; line 108

---
[...]
    low_host_flap_threshold: 5.0
    high_host_flap_threshold: 20.0
    date_format: iso8601
    enable_embedded_perl: 1
    use_embedded_perl_implicitly: 1
    illegal_object_name_chars: `~!$%^&*|'"<>?,():     <======================
    illegal_macro_output_chars: `~$&|'"<>
    use_regexp_matching: 0
    use_true_regexp_matching: 0
    admin_email: root@localhost
    admin_pager: pageroot@localhost
[...]

---

NRPE plugin looks for plugins and fails

I don't weather to call this a bug - or lack of enough documentation for a newcomer. I will leave it to you to decide on that but here is what is happening when I tried this as a complete noob to Nagios:

NRPE plugin installation fails because it looks for plugin directory, code snippet from nagios.nrpe.plugin.sls:

{{ nrpe.plugin_dir }}:
  file.recurse:
    - source: salt://nagios/nrpe/files/plugins/

But the plugin directory does not exist in nagios/nrpe/files. I understand that ideally this is where plugins will go and is specific to how a user uses it - but leaving a empty directory or some sort of note will be helpful.

nrpe-user SLS ID not globally unique

I'm getting this error when trying to use this formula:

The conflicting ID is "nrpe-user" and is found in SLS "base:nagios.server" and SLS "base:nagios.nrpe.server"

missing dynamic definitions

the dynamic definitions use a linux-server host template and a limited-notification-service service template. but neither are defined anywhere.

host definitions use a parent directive that nagios does not recognize:

Error: Invalid host object directive 'parent'.

also, /etc/nagios3/dynamic/ is missing from the server:cfg_dir: entry in the pillar example.

i think both templates could be created from pillar data. that way the users can modify the templates for their own needs.

and i guess it is safe to just add /etc/nagios3/dynamic/ to the list of directories, even if it there is no dynamic data because it would just be an empty directory. (though i don't know if nagios is fine with that or a missing directory)

i don't know what do do about parent. i just removed it to make things work.

missing documentation or examples on how to use this formula.

it would be helpful to have some instructions on how to use this formula and create an example setup.

as i discovered, at a minimum, the following steps are necessary:

install the formula as in the Salt Formulas installation and usage instructions.

in top.sls set up the server with:

'nagios-server':
  - nagios.server
  - nagios.server.dynamic

copy pillar.example to the the pillar directory (eg as nagios.sls)
add the nagios pillar to the nagios server and to all machines that are monitored through nrpe
edit the pillar file to the fix the conflicting ID 'checks' by choosing whether to target only the server or minions as well.
link/copy the provided apache2.conf into the apache directory (the debian nagios packages pull in a ready-to-run apache server. on other distributions, the webserver may need to be configured independently, which is beyond the scope of this formula):
```
/etc/apache2/sites-enabled/nagios.conf:
    file.symlink:
        - target: /etc/nagios3/apache2.conf
```

create a user:passwd entry for nagios admin:

/etc/nagios3/htpasswd.users:
    file.managed:
        - source: salt://services/nagios/htpasswd
        - mode: 755

only at that point nagios is actually running and accessible by webbrowser.

next i need to figure out how to add our local configuration. it looks like this involves setting up NRPE

maybe this issue can be used to create some basic instructions on how to get started.

Excessive dependencies pulled by default `nagios.nrpe.plugin` formula

This is from a fresh Debian wheezy installation:

----------
          ID: nrpe-plugin-package
    Function: pkg.installed
        Name: nagios-nrpe-plugin
      Result: True
     Comment: The following packages were installed/updated: nagios-nrpe-plugin
     Started: 13:35:49.296221
    Duration: 72255.574 ms
     Changes:
              ----------
              apache2:
                  ----------
                  new:
                      1
                  old:
              apache2-mpm:
                  ----------
                  new:
                      1
                  old:
              apache2-mpm-prefork:
                  ----------
                  new:
                      2.2.22-13+deb7u6
                  old:
              apache2-utils:
                  ----------
                  new:
                      2.2.22-13+deb7u6
                  old:
              apache2.2-bin:
                  ----------
                  new:
                      2.2.22-13+deb7u6
                  old:
              apache2.2-common:
                  ----------
                  new:
                      2.2.22-13+deb7u6
                  old:
              bind9-host:
                  ----------
                  new:
                      1:9.8.4.dfsg.P1-6+nmu2+deb7u7
                  old:
              bsd-mailx:
                  ----------
                  new:
                      8.1.2-0.20111106cvs-1+deb7u1
                  old:
              default-mta:
                  ----------
                  new:
                      1
                  old:
              dnsutils:
                  ----------
                  new:
                      1:9.8.4.dfsg.P1-6+nmu2+deb7u7
                  old:
              exim4-base:
                  ----------
                  new:
                      4.80-7+deb7u1
                  old:
              exim4-config:
                  ----------
                  new:
                      4.80-7+deb7u1
                  old:
              exim4-config-2:
                  ----------
                  new:
                      1
                  old:
              exim4-daemon-light:
                  ----------
                  new:
                      4.80-7+deb7u1
                  old:
              exim4-localscanapi-1.0:
                  ----------
                  new:
                      1
                  old:
              exim4-localscanapi-1.1:
                  ----------
                  new:
                      1
                  old:
              fping:
                  ----------
                  new:
                      3.2-1
                  old:
              freeipmi-common:
                  ----------
                  new:
                      1.1.5-3
                  old:
              freeipmi-tools:
                  ----------
                  new:
                      1.1.5-3
                  old:
              geoip-database:
                  ----------
                  new:
                      20130213-1
                  old:
              host:
                  ----------
                  new:
                      1
                  old:
              httpd:
                  ----------
                  new:
                      1
                  old:
              httpd-cgi:
                  ----------
                  new:
                      1
                  old:
              irb:
                  ----------
                  new:
                      1
                  old:
              irb1.9.1:
                  ----------
                  new:
                      1
                  old:
              javascript-common:
                  ----------
                  new:
                      7
                  old:
              libapache2-mod-php5:
                  ----------
                  new:
                      5.4.45-0+deb7u1
                  old:
              libapr1:
                  ----------
                  new:
                      1.4.6-3+deb7u1
                  old:
              libaprutil1:
                  ----------
                  new:
                      1.4.1-3
                  old:
              libaprutil1-dbd-sqlite3:
                  ----------
                  new:
                      1.4.1-3
                  old:
              libaprutil1-ldap:
                  ----------
                  new:
                      1.4.1-3
                  old:
              libbind9-80:
                  ----------
                  new:
                      1:9.8.4.dfsg.P1-6+nmu2+deb7u7
                  old:
              libclass-accessor-perl:
                  ----------
                  new:
                      0.34-1
                  old:
              libconfig-tiny-perl:
                  ----------
                  new:
                      2.14-1
                  old:
              libdate-manip-perl:
                  ----------
                  new:
                      6.32-1
                  old:
              libdbm-ruby1.9.1:
                  ----------
                  new:
                      1
                  old:
              libdigest-hmac-perl:
                  ----------
                  new:
                      1.03+dfsg-1
                  old:
              libdns88:
                  ----------
                  new:
                      1:9.8.4.dfsg.P1-6+nmu2+deb7u7
                  old:
              libencode-locale-perl:
                  ----------
                  new:
                      1.03-1
                  old:
              libfile-listing-perl:
                  ----------
                  new:
                      6.04-1
                  old:
              libfont-afm-perl:
                  ----------
                  new:
                      1.20-1
                  old:
              libfreeipmi12:
                  ----------
                  new:
                      1.1.5-3
                  old:
              libgd2:
                  ----------
                  new:
                      1
                  old:
              libgd2-noxpm:
                  ----------
                  new:
                      2.0.36~rc1~dfsg-6.1+deb7u1
                  old:
              libgdbm-ruby1.9.1:
                  ----------
                  new:
                      1
                  old:
              libgeoip1:
                  ----------
                  new:
                      1.4.8+dfsg-3
                  old:
              libhtml-form-perl:
                  ----------
                  new:
                      6.03-1
                  old:
              libhtml-format-perl:
                  ----------
                  new:
                      2.10-1
                  old:
              libhtml-parser-perl:
                  ----------
                  new:
                      3.69-2
                  old:
              libhtml-tagset-perl:
                  ----------
                  new:
                      3.20-2
                  old:
              libhtml-tree-perl:
                  ----------
                  new:
                      5.02-1
                  old:
              libhttp-cookies-perl:
                  ----------
                  new:
                      6.00-2
                  old:
              libhttp-daemon-perl:
                  ----------
                  new:
                      6.01-1
                  old:
              libhttp-date-perl:
                  ----------
                  new:
                      6.02-1
                  old:
              libhttp-message-perl:
                  ----------
                  new:
                      6.03-1
                  old:
              libhttp-negotiate-perl:
                  ----------
                  new:
                      6.00-2
                  old:
              libio-pty-perl:
                  ----------
                  new:
                      1:1.08-1+b2
                  old:
              libio-socket-ip-perl:
                  ----------
                  new:
                      0.16-2
                  old:
              libio-socket-ssl-perl:
                  ----------
                  new:
                      1.76-2
                  old:
              libio-tty-perl:
                  ----------
                  new:
                      1
                  old:
              libipc-run-perl:
                  ----------
                  new:
                      0.92-1
                  old:
              libipmiconsole2:
                  ----------
                  new:
                      1.1.5-3
                  old:
              libipmidetect0:
                  ----------
                  new:
                      1.1.5-3
                  old:
              libisc84:
                  ----------
                  new:
                      1:9.8.4.dfsg.P1-6+nmu2+deb7u7
                  old:
              libisccc80:
                  ----------
                  new:
                      1:9.8.4.dfsg.P1-6+nmu2+deb7u7
                  old:
              libisccfg82:
                  ----------
                  new:
                      1:9.8.4.dfsg.P1-6+nmu2+deb7u7
                  old:
              libjpeg8:
                  ----------
                  new:
                      8d-1+deb7u1
                  old:
              libjs-jquery:
                  ----------
                  new:
                      1.7.2+dfsg-1
                  old:
              liblockfile-bin:
                  ----------
                  new:
                      1.09-5
                  old:
              liblockfile1:
                  ----------
                  new:
                      1.09-5
                  old:
              liblwp-mediatypes-perl:
                  ----------
                  new:
                      6.02-1
                  old:
              liblwp-protocol-https-perl:
                  ----------
                  new:
                      6.03-1
                  old:
              liblwp-useragent-determined-perl:
                  ----------
                  new:
                      1.06-1
                  old:
              liblwres80:
                  ----------
                  new:
                      1:9.8.4.dfsg.P1-6+nmu2+deb7u7
                  old:
              libmail-imapclient-perl:
                  ----------
                  new:
                      3.31-2
                  old:
              libmail-perl:
                  ----------
                  new:
                      1
                  old:
              libmailtools-perl:
                  ----------
                  new:
                      2.09-1
                  old:
              libmath-calc-units-perl:
                  ----------
                  new:
                      1.07-1
                  old:
              libmemcached10:
                  ----------
                  new:
                      1.0.8-1
                  old:
              libmodule-implementation-perl:
                  ----------
                  new:
                      0.06-1
                  old:
              libmodule-runtime-perl:
                  ----------
                  new:
                      0.013-1
                  old:
              libmysqlclient18:
                  ----------
                  new:
                      5.5.44-0+deb7u1
                  old:
              libnagios-plugin-perl:
                  ----------
                  new:
                      0.36-1
                  old:
              libnet-dns-perl:
                  ----------
                  new:
                      0.66-2+b2
                  old:
              libnet-http-perl:
                  ----------
                  new:
                      6.03-2
                  old:
              libnet-ip-perl:
                  ----------
                  new:
                      1.25-3
                  old:
              libnet-libidn-perl:
                  ----------
                  new:
                      0.12.ds-1+b3
                  old:
              libnet-smtp-tls-perl:
                  ----------
                  new:
                      0.12-1
                  old:
              libnet-snmp-perl:
                  ----------
                  new:
                      6.0.1-2
                  old:
              libnet-ssleay-perl:
                  ----------
                  new:
                      1.48-1+b1
                  old:
              libonig2:
                  ----------
                  new:
                      5.9.1-1
                  old:
              libopenssl-ruby1.9.1:
                  ----------
                  new:
                      1
                  old:
              libparams-classify-perl:
                  ----------
                  new:
                      0.013-4
                  old:
              libparams-validate-perl:
                  ----------
                  new:
                      1.06-1
                  old:
              libparse-recdescent-perl:
                  ----------
                  new:
                      1.967009+dfsg-1
                  old:
              libperl5.14:
                  ----------
                  new:
                      5.14.2-21+deb7u2
                  old:
              libpng12-0:
                  ----------
                  new:
                      1.2.49-1
                  old:
              libpq5:
                  ----------
                  new:
                      9.1.18-0+deb7u1
                  old:
              libqdbm14:
                  ----------
                  new:
                      1.8.78-2
                  old:
              libradiusclient-ng2:
                  ----------
                  new:
                      0.5.6-1.1
                  old:
              libreadline-ruby1.9.1:
                  ----------
                  new:
                      1
                  old:
              libreadonly-perl:
                  ----------
                  new:
                      1.03-4
                  old:
              libreadonly-xs-perl:
                  ----------
                  new:
                      1.04-2+b3
                  old:
              libruby1.9.1:
                  ----------
                  new:
                      1.9.3.194-8.1+deb7u5
                  old:
              libsensors4:
                  ----------
                  new:
                      1:3.3.2-2+deb7u1
                  old:
              libsnmp-base:
                  ----------
                  new:
                      5.4.3~dfsg-2.8+deb7u1
                  old:
              libsnmp15:
                  ----------
                  new:
                      5.4.3~dfsg-2.8+deb7u1
                  old:
              libsocket-perl:
                  ----------
                  new:
                      2.002-1
                  old:
                      1
              libsub-name-perl:
                  ----------
                  new:
                      0.05-1+b2
                  old:
              libtalloc2:
                  ----------
                  new:
                      2.0.7+git20120207-1
                  old:
              libtdb1:
                  ----------
                  new:
                      1.2.10-2
                  old:
              libtry-tiny-perl:
                  ----------
                  new:
                      0.11-1
                  old:
              liburi-perl:
                  ----------
                  new:
                      1.60-1
                  old:
              libwbclient0:
                  ----------
                  new:
                      2:3.6.6-6+deb7u5
                  old:
              libwww-perl:
                  ----------
                  new:
                      6.04-1
                  old:
              libwww-robotrules-perl:
                  ----------
                  new:
                      6.01-1
                  old:
              libyaml-syck-perl:
                  ----------
                  new:
                      1.20-1
                  old:
              lsof:
                  ----------
                  new:
                      4.86+dfsg-1
                  old:
              mail-reader:
                  ----------
                  new:
                      1
                  old:
              mail-transport-agent:
                  ----------
                  new:
                      1
                  old:
              mailtools:
                  ----------
                  new:
                      1
                  old:
              mailx:
                  ----------
                  new:
                      1
                  old:
              mysql-common:
                  ----------
                  new:
                      5.5.44-0+deb7u1
                  old:
              nagios-images:
                  ----------
                  new:
                      0.7
                  old:
              nagios-nrpe-plugin:
                  ----------
                  new:
                      2.13-3
                  old:
              nagios-plugins:
                  ----------
                  new:
                      1.4.16-1
                  old:
              nagios-plugins-basic:
                  ----------
                  new:
                      1.4.16-1
                  old:
              nagios-plugins-common:
                  ----------
                  new:
                      1.4.16-1
                  old:
              nagios-plugins-contrib:
                  ----------
                  new:
                      4.20120702
                  old:
              nagios-plugins-standard:
                  ----------
                  new:
                      1.4.16-1
                  old:
              nagios3:
                  ----------
                  new:
                      3.4.1-3+deb7u1
                  old:
              nagios3-cgi:
                  ----------
                  new:
                      3.4.1-3+deb7u1
                  old:
              nagios3-common:
                  ----------
                  new:
                      3.4.1-3+deb7u1
                  old:
              nagios3-core:
                  ----------
                  new:
                      3.4.1-3+deb7u1
                  old:
              php5-cli:
                  ----------
                  new:
                      5.4.45-0+deb7u1
                  old:
              php5-common:
                  ----------
                  new:
                      5.4.45-0+deb7u1
                  old:
              php5-json:
                  ----------
                  new:
                      1
                  old:
              php5-mhash:
                  ----------
                  new:
                      1
                  old:
              phpapi-20100525:
                  ----------
                  new:
                      1
                  old:
              psmisc:
                  ----------
                  new:
                      22.19-1+deb7u1
                  old:
              qstat:
                  ----------
                  new:
                      2.11-3
                  old:
              rdoc:
                  ----------
                  new:
                      1
                  old:
              rdoc1.9.1:
                  ----------
                  new:
                      1
                  old:
              ruby:
                  ----------
                  new:
                      1:1.9.3
                  old:
              ruby-interpreter:
                  ----------
                  new:
                      1
                  old:
              ruby1.9.1:
                  ----------
                  new:
                      1.9.3.194-8.1+deb7u5
                  old:
              rubygems1.9.1:
                  ----------
                  new:
                      1
                  old:
              samba-client:
                  ----------
                  new:
                      1
                  old:
              samba-common:
                  ----------
                  new:
                      2:3.6.6-6+deb7u5
                  old:
              samba-common-bin:
                  ----------
                  new:
                      2:3.6.6-6+deb7u5
                  old:
              smbclient:
                  ----------
                  new:
                      2:3.6.6-6+deb7u5
                  old:
              snmp:
                  ----------
                  new:
                      5.4.3~dfsg-2.8+deb7u1
                  old:
              ssl-cert:
                  ----------
                  new:
                      1.0.32+deb7u1
                  old:
              whois:
                  ----------
                  new:
                      5.1.1~deb7u1
                  old:
              wwwconfig-common:
                  ----------
                  new:
                      0.2.2
                  old:

A colleague with more patience has informed me that "nagios-nrpe-plugin recommends nagios3 which deps nagios3-cgi which deps apache2-utils and recs apache2".

As a workaround, I have added the following to our infra:

states> cat core/nrpe_no_fucking_apache.sls
include:
  - base: nagios.nrpe.plugin

extend:
  nrpe-plugin-package:
    pkg.installed:
      - install_recommends: False

[debian] [stretch] allow_bash_command_substitution=0 is removed

on debian stretch, "allow_bash_command_substitution=0" is removed, it would be nice to keep it, and make it configurable

illegal_object_name_chars render error

Trying to execute the nagios state in the formula throws a pillar render error using salt 2015.8.0 (Beryllium). It seems that the initial backtick value at ilegal_object_name_chars/ilegal_macro_output_chars keys it's not supported:

sheriff.habitissimo.com:
    Data failed to compile:
----------
    Pillar failed to render with the following messages:
----------
    Rendering SLS 'nagios-server.sheriff' failed, render error:
found character '`' that cannot start any token; line 108

---
[...]
    low_host_flap_threshold: 5.0
    high_host_flap_threshold: 20.0
    date_format: iso8601
    enable_embedded_perl: 1
    use_embedded_perl_implicitly: 1
    illegal_object_name_chars: `~!$%^&*|'"<>?,():     <======================
    illegal_macro_output_chars: `~$&|'"<>
    use_regexp_matching: 0
    use_true_regexp_matching: 0
    admin_email: root@localhost
    admin_pager: pageroot@localhost
[...]

---

And also, if I remove the backticks I have problems with the colon (:)

# salt 'sheriff*' state.sls nagios test=True
sheriff.example.com:
    Data failed to compile:
----------
    Pillar failed to render with the following messages:
----------
    Rendering SLS 'nagios-server.sheriff' failed, render error:
mapping values are not allowed here; line 108

---
[...]
    low_host_flap_threshold: 5.0
    high_host_flap_threshold: 20.0
    date_format: iso8601
    enable_embedded_perl: 1
    use_embedded_perl_implicitly: 1
    illegal_object_name_chars: ~!$%^&*|'"<>?,():     <======================
    illegal_macro_output_chars: ~$&|'"<>
    use_regexp_matching: 0
    use_true_regexp_matching: 0
    admin_email: root@localhost
    admin_pager: pageroot@localhost
[...]

---

	nrpe-plugin-package:
	pkg.installed:
	- name: {{ nrpe.plugin }}

	{% if 'nagios/nrpe/files/plugins' in salt['cp.list_master_dirs']() %}
	{{ nrpe.plugin_dir }}:
	file.recurse:
	- source: salt://nagios/nrpe/files/plugins/
	- clean: False
	- file_mode: 0755
	{% endif %}

saltstack-formulas / nagios-formula Goto Github PK

nagios-formula's Introduction

nagios

Available states

nagios

nagios.plugins

nagios.server

nagios.nrpe

nagios.nrpe.server

nagios.nrpe.plugin

nagios.nrpe.dynamic

nagios.nsca.client

nagios-formula's People

Contributors

Stargazers

Watchers

Forkers

nagios-formula's Issues

Your setup

Formula commit hash / release tag

Bug details

Describe the bug

Recommend Projects

Recommend Topics

Recommend Org

`nagios`

`nagios.plugins`

`nagios.server`

`nagios.nrpe`

`nagios.nrpe.server`

`nagios.nrpe.plugin`

`nagios.nrpe.dynamic`

`nagios.nsca.client`