Describe the bug
When you try to post with /sell using a file, the bot doesn't react. Something goes wrong, needs investigation

To Reproduce
Steps to reproduce the behavior:
Try selling with a file-photo, without compressing

Expected behavior
It should accept photos as files

Screenshots

To ensure the robustness and correctness of the image handling functionality in the project, it's essential to create unit tests that thoroughly validate its behavior. 🧪🖼️

Expected Behavior:
The unit tests should verify that the image handling function correctly processes incoming photos, downloads them, prepares the data, and sends the image to the specified channel with the appropriate caption.
Acceptance Criteria 🎯:

• Unit tests for simulating incoming photo messages are implemented.
• Unit tests for image download and data preparation are functional.
• Tests for caption generation meet expectations.
• Unit tests for sending images to specified channels are working.
• Tests cover different image formats.
• All tests pass successfully 🟢.

Steps for Implementation 🔨:
Set Up Testing Environment: Ensure that you have a test environment that closely mimics the production environment.

Test Incoming Messages: Write tests to simulate incoming photo messages.

def test_incoming_messages():
    # your code here

Test Photo Download and Data Preparation: Create tests that ensure photos are downloaded and data is prepared correctly.

def test_photo_download():
    # your code here

Test Caption Generation: Validate that captions are generated in the expected format.

def test_caption_generation():
    # your code here

Test Image Sending: Test whether the image is sent to the specified channel.

def test_image_sending():
    # your code here

Test Different Formats: Include tests for different image formats.

def test_image_formats():
    # your code here

Run and Validate Tests: Run the tests and ensure they all pass. If any fail, debug and rerun the tests.

Additional Notes 📚:
Include logging within tests to capture important debugging information.
Consult the documentation for any external libraries you're using for image processing.

You can do one test at a time, no problem!

The README.md right now is rather ordinary and deserves some refreshment.

Provide a nice new version of the first page of our project

• I suggest adding a GIF demonstration on how the bot works, would be really nice.
• Also broaden the table of languages, adding the top 20 most popular languages for us to consider in the future
• Rephrase and delete unnecessary wording
• Add useful link (f.e. contributing guide)

Issue Description 📝

Currently, after a user presses an inline button associated with a message in a channel, the button remains active. This allows for repeated actions, which is undesirable. Additionally, the message gets deleted from the channel upon successful action. The goal is to make the inline button disappear or be disabled once pressed, and to prevent further actions after a successful operation.

Requirements 🎯

1. Inline Button Removal: After a user presses the inline button, it should be removed from the message.
2. Message Deletion: Continue to delete the message from the channel after successful action, if that's the current desired behavior.
3. Prevent Repeated Actions: Once the action is successful and the message is deleted, the action should not be allowed to be repeated.

Acceptance Criteria ✅

• Inline button should disappear or become disabled after a user presses it.
• Message should continue to be deleted after a successful action.
• Users should not be able to perform the action again once it's been successfully executed.

Possible Solution 🛠️

1. Capture the callback query when the inline button is pressed.
2. Delete or disable the inline button from the message.

   await bot.edit_message_reply_markup(
       chat_id=callback_query.message.chat.id,
       message_id=callback_query.message.message_id,
       reply_markup=None
   )

Okay so prior to my earlier issue raised i have all my modules installed via poetry & my environment set up however i still come across a KeyError of a missing env variable.

Steps to reproduce
Run project from scratch with python main.py

Expected result:
Bot started (success message)

Actual result:

Traceback (most recent call last):
  File "/Users/macbookpro/telegram_flea/main.py", line 18, in <module>
    bot = aiogram.Bot(os.environ["TELEGRAM_BOT_TOKEN"])
                      ~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^
  File "<frozen os>", line 679, in __getitem__
KeyError: 'TELEGRAM_BOT_TOKEN'

Screenshots

Description 📝:

As part of our ongoing efforts to make our project more accessible to a global audience, we would like to extend our existing i18n (Internationalization) support to include the Ukrainian language.

Requirements 📋:

• Extend i18n Configuration: Add Ukrainian (uk-UA) to the list of supported languages in the i18n configuration.
• Translation Files: Create a .po file for Ukrainian translations in the /locales directory.
• Text Resources: Update all text resources to include Ukrainian translations.
• Testing: Test to ensure that the Ukrainian language support works seamlessly across all features.
• Documentation: Update relevant documentation to reflect the new language support.

Acceptance Criteria 🎯:

• Ukrainian is added to the list of supported languages in the i18n configuration.
• Ukrainian .po file is added.
• All text resources are translated into Ukrainian.
• Ukrainian language support is fully functional in all features.
• Documentation is updated to indicate Ukrainian language support. (README.md file)

Describe the bug
On loading the repo to my IDE, i get bugs requesting I install missing modules even after rightly installing them.

To Reproduce
Steps to reproduce the behavior:

1. After loading project to my IDE
2. I install modules 'aiogram' , python-dotenv, Path on my IDE terminal
3. After which i encounter missing aiogram dependencies/imports errors on lines 5,6,8,9

Screenshots

Main.py expects locale files to be compiled before first run.

Steps to reproduce
Run project from scratch with python main.py

Expected result:
Bot started (success message)

Actual result:
RuntimeError: Found locale 'uk' but this language is not compiled!

Enhance user support by implementing a /help command to provide guidance and information within the application. 🤝🆘

Users can type /help in the chat to receive a list of available commands, FAQs, and basic usage instructions, improving their understanding of the app's functionality. 💬❓

Description 📝:
Implement support for multiple languages in the bot using Aiogram's built-in i18n features. The language setting will not be interactive and will be a bot-level configuration.

Requirements 📋:
Installation: Install any necessary packages for i18n.
Configuration: Configure i18n settings in Aiogram bot.
Translations: Add translation files for supported languages.
Fallback: Ensure there's a fallback language (ENGLISH or UKRAINIAN) if the set language translation isn't available.
Acceptance Criteria 🎯:

• i18n is configured in the bot
• Translation files are added and loaded
• Bot responds in the configured language
• Fallback to a default language is implemented
• Steps for Implementation 🔨:
• Initialize i18n: Initialize i18n in the Aiogram bot project.

from aiogram import Bot, types
from aiogram.dispatcher import Dispatcher
from aiogram.contrib.fsm_storage.memory import MemoryStorage
from aiogram.contrib.middlewares.i18n import I18nMiddleware

bot = Bot(token='YOUR_BOT_TOKEN')
storage = MemoryStorage()
dp = Dispatcher(bot, storage=storage)

i18n = I18nMiddleware('bot', 'path/to/locales')
dp.middleware.setup(i18n)

Add Translation Files: Create .po files and automate .mo creation for supported languages in the /locales directory.

Configure Language in Bot: Set the language to be used in the bot settings, and not allow users to change it.

@dp.message_handler(commands=['start'])
async def send_welcome(message: types.Message):
    await message.reply(i18n.t('bot.start_message'))

Test: Make sure all features work in the specified language, and a fallback language is used when necessary.

Sellers without usernames are displayed incorrectly in the listing.
For such users, their user IDs are displayed where the username is supposed to be, resulting in the mention @[some numbers here]. Such mentions are parsed by Telegram incorrectly, as it treats these IDs as actual usernames.

To Reproduce
Steps to reproduce the behavior:

1. Get a Telegram account without a username.
2. Add an item using the bot.
3. In the moderator chat or channel, the seller mention is displayed incorrectly and is not traversable.

Additional
It is possible to create a link to a user using formatting: [some text](tg://user?id=), then, with the proper formatting method, "some text" will be displayed as a link to an account. With this method, there might be some issues with account privacy settings.

Enhance user interaction by replacing text commands with intuitive action buttons. 🚀🔘

Expected Behavior:
Instead of typing commands, users can click on the keyboard buttons for common actions, making the app more user-friendly and accessible. 🤖📲

Docs: https://docs.aiogram.dev/en/latest/api/types/reply_keyboard_markup.html

Example:
https://github.com/aiogram/aiogram/blob/dev-2.x/examples/regular_keyboard_example.py

Make it simple

Summary: 📝

Add a feature to the Flea Market Telegram Bot that allows users to manually cancel the selling request for items, effectively removing them from the Telegram channel.

Details: 📚

Currently, once an item is posted for sale in the Telegram channel, it stays there indefinitely. Users should have the ability to manually remove their items from the channel, whether it's because the item was sold outside of the channel, withdrawn from sale, or for any other reason.

Proposed Solution: 🛠

Add a /cancel [item_id] command to the bot.
When a user triggers this command, the bot should prompt for a confirmation to ensure it's not a mistake.
Upon confirmation, the bot should remove the corresponding item post from the Telegram channel.

Acceptance Criteria: ✅

• A user can cancel a selling request by using the /cancel [item_id] command.
• A confirmation step exists to ensure items are not deleted accidentally.
• The item post is removed from the Telegram channel once the cancellation is confirmed.

Additional Information: ℹ️

This feature adds flexibility for users in managing their selling requests and contributes to keeping the channel clean and relevant.

Thank you for considering this feature request. This will greatly enhance user autonomy and improve the overall experience in the Telegram channel. 🙏🤖🗑

What?

• Connect S3 (possibly Digital Ocean Spaces) using e.g. boto3 or rather aioboto3.
• Save images sent to bot to S3. Possibly using a Middleware.
• [Optional but preferred] Save the images' UUID4s (or similar) to the Database so that in the database we have a full local copy of an ad.

Why?

• To have a list of all the images sent to the bot, in case someone is trying to abuse it, we can track the bad actor.
• To possibly allow for a web-interface and/or different mediums, including different mediums in terms or payments.

Anything else?

I would argue for using async version of boto3 - aioboto3 (or analogs) because uploading an image to S3 is a heavy I/O-bound operation and having it be done async is a great plus.

Issue Description:
To ensure a top-notch marketplace, we need a moderation system for selling requests. This will guarantee that all listed items follow our rules and policies. 📜🧐

Expected Behavior:
When a user submits a selling request, it should go first to a admin (who's ID has been identified in the .env) with two buttons APPROVAL / DECLINATION inline-button attached. Moderators can approve, reject. 🚀👮‍♂️

Suggestions are welcome 🙌

You can split this into multiple issues:
the strings are:

• bot.declined_successfully
• bot.listing_declined{listing}
• bot.listing_approved{listing}
• bot.approved_successfully
• bot.sent_to_moderation
• bot.moderator_declination
• bot.moderator_approval

Make sure to include in the tanslated version the {listing} variable

• Hindi
• English
• German
• Indonesian

Currently after sending the photo, the user is instantly sending in to moderation.

It would be more appropriate to show the user a preview and let him confirm changes

Example: (left button -- confirm, right, cancel)

The user should be notified that this length has a constraint, let it be around 2k symbols

Looks something like this:

2023-11-06T13:06:08.294794+00:00 app[bot.1]:   File "/app/.heroku/python/lib/python3.11/site-packages/aiogram/bot/base.py", line 236, in request
2023-11-06T13:06:08.294794+00:00 app[bot.1]:     return await api.make_request(await self.get_session(), self.server, self.__token, method, data, files,
2023-11-06T13:06:08.294794+00:00 app[bot.1]:                  │   │                  │    │              │    │       │             │       │     └ {'photo': <InputFile 'attach://Zr7EVo7IeESjfXai5uPjYQ' with file='<_io.BufferedReader name='item_photo.jpg'>'>}
2023-11-06T13:06:08.294795+00:00 app[bot.1]:                  │   │                  │    │              │    │       │             │       └ {'chat_id': , 'caption': 'Текстові картинки з символів, які також називають ASCII арт це одне з мистецтв доступних к...
2023-11-06T13:06:08.294796+00:00 app[bot.1]:                  │   │                  │    │              │    │       │             └ 'sendPhoto'
2023-11-06T13:06:08.294796+00:00 app[bot.1]:                  │   │                  │    │              │    │       └ <aiogram.bot.bot.Bot object at 0x7fab07b39910>
2023-11-06T13:06:08.294796+00:00 app[bot.1]:                  │   │                  │    │              │    └ TelegramAPIServer(base='https://api.telegram.org/bot{token}/{method}', file='https://api.telegram.org/file/bot{token}/{path}')
2023-11-06T13:06:08.294796+00:00 app[bot.1]:                  │   │                  │    │              └ <aiogram.bot.bot.Bot object at 0x7fab07b39910>
2023-11-06T13:06:08.294796+00:00 app[bot.1]:                  │   │                  │    └ <function BaseBot.get_session at 0x7fab07f20360>
2023-11-06T13:06:08.294796+00:00 app[bot.1]:                  │   │                  └ <aiogram.bot.bot.Bot object at 0x7fab07b39910>
2023-11-06T13:06:08.294797+00:00 app[bot.1]:                  │   └ <function make_request at 0x7fab07ea3c40>
2023-11-06T13:06:08.294797+00:00 app[bot.1]:                  └ <module 'aiogram.bot.api' from '/app/.heroku/python/lib/python3.11/site-packages/aiogram/bot/api.py'>
2023-11-06T13:06:08.294797+00:00 app[bot.1]:   File "/app/.heroku/python/lib/python3.11/site-packages/aiogram/bot/api.py", line 140, in make_request
2023-11-06T13:06:08.294797+00:00 app[bot.1]:     return check_result(method, response.content_type, response.status, await response.text())
2023-11-06T13:06:08.294797+00:00 app[bot.1]:            │            │       │        │             │        │             │        └ <function ClientResponse.text at 0x7fab08381620>
2023-11-06T13:06:08.294800+00:00 app[bot.1]:            │            │       │        │             │        │             └ <ClientResponse(https://api.telegram.org/bot6738102641:AAG9NTvl5IFG1qTBDmBe7vlAHteaUFhc-zA/sendPhoto) [400 Bad Request]>
2023-11-06T13:06:08.294800+00:00 app[bot.1]:            │            │       │        │             │        │               <CIM...
2023-11-06T13:06:08.294800+00:00 app[bot.1]:            │            │       │        │             │        └ 400
2023-11-06T13:06:08.294800+00:00 app[bot.1]:            │            │       │        │             └ <ClientResponse(https://api.telegram.org/bot6738102641:AAG9NTvl5IFG1qTBDmBe7vlAHteaUFhc-zA/sendPhoto) [400 Bad Request]>
2023-11-06T13:06:08.294800+00:00 app[bot.1]:            │            │       │        │               <CIM...
2023-11-06T13:06:08.294801+00:00 app[bot.1]:            │            │       │        └ <property object at 0x7fab0854d850>
2023-11-06T13:06:08.294802+00:00 app[bot.1]:            │            │       └ <ClientResponse(https://api.telegram.org/bot6738102641:AAG9NTvl5IFG1qTBDmBe7vlAHteaUFhc-zA/sendPhoto) [400 Bad Request]>
2023-11-06T13:06:08.294802+00:00 app[bot.1]:            │            │         <CIM...
2023-11-06T13:06:08.294802+00:00 app[bot.1]:            │            └ 'sendPhoto'
2023-11-06T13:06:08.294802+00:00 app[bot.1]:            └ <function check_result at 0x7fab07ea3d80>
2023-11-06T13:06:08.294802+00:00 app[bot.1]:   File "/app/.heroku/python/lib/python3.11/site-packages/aiogram/bot/api.py", line 115, in check_result
2023-11-06T13:06:08.294803+00:00 app[bot.1]:     exceptions.BadRequest.detect(description)
2023-11-06T13:06:08.294803+00:00 app[bot.1]:     │          │          │      └ 'Bad Request: message caption is too long'
2023-11-06T13:06:08.294803+00:00 app[bot.1]:     │          │          └ <classmethod(<function _MatchErrorMixin.detect at 0x7fab080c2de0>)>
2023-11-06T13:06:08.294803+00:00 app[bot.1]:     │          └ <class 'aiogram.utils.exceptions.BadRequest'>
2023-11-06T13:06:08.294803+00:00 app[bot.1]:     └ <module 'aiogram.utils.exceptions' from '/app/.heroku/python/lib/python3.11/site-packages/aiogram/utils/exceptions.py'>
2023-11-06T13:06:08.294804+00:00 app[bot.1]:   File "/app/.heroku/python/lib/python3.11/site-packages/aiogram/utils/exceptions.py", line 141, in detect
2023-11-06T13:06:08.294804+00:00 app[bot.1]:     raise cls(description)
2023-11-06T13:06:08.294804+00:00 app[bot.1]:           │   └ 'bad request: message caption is too long'
2023-11-06T13:06:08.294804+00:00 app[bot.1]:           └ <class 'aiogram.utils.exceptions.BadRequest'>

What?

Create a condition to use aiogram's MemoryStorage() class when the user did not input the REDIS_URL

Why?

This would make it simpler for newcomers and contributors to work on the project without redundant functionality

This is easy to implement

Create a generalized starting message that provides a warm welcome and essential information to new users. 🆕👋

It should be the answer to the /start command

This can be done even with chatGPT, prefered to use GPT4

Can be also split to several small PR's for newcomers, do as you like 🤗

• Ukrainan
• Hindi
• Indonesian
• German

Currently the picture is mandatory, this shouldn't be the case.

After the price part, I would suggest a button "send without photo"

Summary: 📝

Create documentation that provides instruction on how to use and install the Flea Market Telegram Bot, aimed at both users and potential contributors.

Proposed Solution: 🛠

• Write a comprehensive guide on how to use all existing features of the bot.
• Include step-by-step screenshots or short video clips for complex processes.
• Add an FAQ section to address common questions. (or leave space for future considerations)
• Include a section that outlines how contributors can set up the development environment and add new features. + find the variables
• Update the README.md to include a link to the new documentation.

Acceptance Criteria: ✅

• Documentation is complete
• Step-by-step guides are clear and easy to follow.
• An FAQ section is added. (even if empty)
• README.md is updated with the link to the new documentation.

Additional Information: ℹ️

This documentation will be the primary source of information for users and new contributors, so it needs to be as clear and comprehensive as possible. It would be beneficial to get feedback from both users and other developers to ensure all bases are covered.

Thank you for considering this issue. Proper documentation will significantly improve the user experience and encourage more contributions to the project. 📚🤖👥

Issue: Implement PostgreSQL Database for Capturing Useful Statistics and Anonymous User Data Using Tortoise-ORM

Problem Description

At present, the bot doesn't keep track of useful statistics and user data that could be crucial for improving user experience and analyzing usage patterns. We would like to capture and store this data in a PostgreSQL database.

Objective 🎯

The aim is to implement a PostgreSQL database using Tortoise-ORM to store statistics and user metrics, while ensuring that all data is anonymized for user privacy.

Suggested Changes

You can divide these into separate PullRequests, to make the task easier:

Implement basic data saving:

• Use Tortoise-ORM to create database models that align with the metrics and data points you identified.
• Implement data capture and storage in the database within the bot's existing command handlers and states.
• Make sure all stored data is anonymized and not traceable to individual users.

Suggestions on what to save:

• the Triggering of specific commands with datetime
• Average interaction length.
• Interface language of users

Do something with the data:

• Create a module to analyze the data in general
• Analyze the most popular time of the day and day of the week using a graph (matplotlib)
• Use a barplot to visualize Interface languages of users

❕ Important: this functionality should be optional, as the usage of a sophisticated database and statistical analysis can be unnecessary for some projects.

Code Snippet

Below is a hypothetical Python code snippet that demonstrates how you might use Tortoise-ORM to interact with a PostgreSQL database:

from tortoise import Tortoise, fields
from tortoise.models import Model

class UserStatistics(Model):
    id = fields.IntField(pk=True)
    command_used = fields.CharField(max_length=50)
    session_length = fields.FloatField()
    # any other fields

Tortoise.init(
    db_url='postgres://username:password@localhost:5432/mydatabase',
    modules={'models': ['your_project.models']}
)

async def track_start_command(user_id: int):
    await UserStatistics.create(command_used='start', session_length=0.0)
    # other logic

Acceptance Criteria

1. Data is properly captured and stored in a PostgreSQL database.
2. All stored data is anonymized.
3. The database setup should be modular and easily extendable for capturing more metrics in the future.
4. Testing
5. Add unit tests to verify that the database is capturing and storing the data as expected.
6. Manually review entries to ensure that they are anonymized and not traceable to individual users.
7. Please feel free to contribute by making a Pull Request to address this issue. Thank you! 📈🔒

Note: Make sure to adhere to privacy guidelines and policies such as GDPR when implementing this feature.

You can divide this task by creating multiple pull requests! No need to do all this work at once ♥

Current README.md file is not up-to-date, please add:

• How to use the bot without Redis
• how to get the BotFather and channel going
• How to use WITH Redis
• Other missed features and steps

Issue: Implement Redis Storage for Data Persistence

Problem Description

Currently, the bot is using in-memory storage for FSM (Finite State Machine) which loses all its data when the bot is restarted. This may not be ideal for production where uptime and data integrity are important.

Objective

Implement a Redis storage solution to replace the existing MemoryStorage for better data persistence.

Suggested Changes

1. Add Redis to your project's dependencies.
2. Modify the storage = MemoryStorage() line to use Redis-based storage.
3. Ensure that all existing FSM states and data points are moved to Redis.
4. Test thoroughly to make sure all functionalities remain intact post-migration.

Code Snippet

Replace:

storage = MemoryStorage()

Acceptance Criteria

1. Data should be persistent across bot restarts.
2. All FSM states should function as expected but now backed by Redis.
3. Measure and confirm that the bot's performance isn't negatively affected by this change.
4. Testing
5. Ensure all existing unit and integration tests pass after these changes. If possible, add tests to confirm that the Redis storage behaves as expected.

Please contribute by making a Pull Request that resolves this issue. Thank you! 🌟🔒

What's happening?

Currently the bot simply types the cancelation message without any reference to the request

Why?

It should be more intuitive to do a bot.reply() instead of bot.send_message() because the person will understand what is happening

This is easy to fix