samccone / scrollin Goto Github PK

The current version has an issue with browserify

Cannot find module 'lodash.debounce'

which is odd.

Going to unit test this tool vs an boring integration suite.. To make this possible the following methods need to be stubbed and the following internal APIs need to be exposed

To Stub

Window

Methods

• requestAnimationFrame
• addEventListener

Props

• innerWidth
• innerHeight

Elements

Methods

• getBoundingClientRect
{right: xx, left: xx, top: xx}

To Expose

tracking

https://twitter.com/mathias/status/601010834119200769

Thanks @mathiasbynens 👯

Create an option to simply pass an offset in order to have it fire later into the viewport.

This line removes the _onScroll method:
https://github.com/samccone/scrollin/blob/master/index.js#L41

This line adds a throttled _onScroll method:
https://github.com/samccone/scrollin/blob/master/index.js#L49

Will the _onScroll handler never die since the function registered isn't the function deregistered?

This would be a nicer API compared to

Array.prototype.slice.call(document.querySelectorAll('.foo'))
.forEach(n => Scrollin.track(n, myFunc))

Sometimes you need a fake scroll container instead of window, for things like basement menus or certain page transitions. This requires tracking an element's scroll events, rather than window.

Thankfully, the project I'm working on has down away with its scrolljacked container. But I thought I'd raise this for down the road.

Normally, I'd use my own morlock.js for this, but I'm tired of maintaining it so I put this TODO on your plate instead :)

The important parts are: https://github.com/tdreyno/morlock.js/blob/master/streams/scroll-stream.js#L15
And: https://github.com/tdreyno/morlock.js/blob/master/core/dom.js#L42-L52

Thanks for this simple project 🍻