san-kumar / installer Goto Github PK

Hello,

I haven't used this yet but it's certainly got my attention. In inspecting the project I see you're using the Console namespace for this installer code base.

I recommend some code changes.

• Prefix all code namespace with AwsLambda or SanKumar\AwsLambda.
• For most of my open source work I put the code into a organization that way it's not just in my personal directory and it feels more professional and less attached to me, the developer. So I recommend you move this library and supporting library lambdaphp into a new organization. For an example from my own work see https://github.com/api-skeletons If you move this to a new organization the namespace would be OrganizationName\AwsLambda\Console
• Don't use brackets to differentiate namespaces. This technique is possible but it is not a recommendation of the PSR standards.

If you like I will review all your PHP code (which looks pretty good already!) and write it to strict PSR standards.

I think you've got a good thing going here and I'm here to help. How can I assist?

Hi,
Fun project! Great work..

Have you thought about running PHP in server mode, so cold starts aren't issue anymore?

Basically, you can spawn a detached PHP process, that will live open in the container after the request is served
Some more info: https://www.linkedin.com/pulse/aws-lambda-container-lifetime-config-refresh-frederik-willaert
Container reuse

Please post all bugs to https://github.com/san-kumar/lambdaphp

It's hard to keep track in different places.

I'm finding issues deploying on unix/linux from the latest composer which would suggest its been edited using a windows format and not cleaned prior to commit.

find . -type f -exec dos2unix {} ;

This is resulting in a broken deploy function on unix/linux os, once again, attempted to PR this but unfortunately I do not have the appropriate rights.

Thanks for this.

Any chance you could add the zip extension --enable-zip in the php configure options?

Note I tried building my own php using the upstream dockerfile, however my compiled version seems to be missing some options.

(Any chance you could include the dockerfile and the build wrapper.zip script?)

Thanks again.

within installer/console/App/Config.php on line 68 -- us-east-1 needs replacing with

'region' => getenv('AWS_DEFAULT_REGION') ?: ''

I attempted to PR for this but the repo is locked down so I was unable to.