sanemethod / hup Goto Github PK

readAsDataURL returns wrong event.target.result WHEN we use the DeferReader AND we use the chunked option to true AND the type is image (perhaps the same problem for other types).

The problem is that it does not add the file type in the data string:

data:;base64,lVKENsd8bVZG7K2wAI+zQb/jiqpV2l9Z/hIoaAbV+.......

it should be

data:image/jpeg;base64,lVKENsd8bVZG7K2wAI+zQb/jiqpV2l9Z/hIoaAbV+.......

That problem in Chrome.

In Firefox we get:

data:application/octet-stream;base64,NGmHgRJvqzLVtN01ULFQkB/.......

which is again wrong. I guess Firefox auto adds "application/octet-stream"

So there is something wrong with the DeferReader when chunked option is true.

P.S. When we don't use chunked then it works fine as it should be.

Hi Christopher!

First of all - I love your HUp plugin! I easily managed injecting it into my project. But I can't find the way how to filter files before the upload. Simply, let's say I want to allow uploading only image files or files below 10MB. I know I could do that server-side but I don't want to for two reasons:

1. If someone uploads a 700MB file while allowed size is 10MB it would be unnecessary burden for the server
2. In my UI I'm providing a progress bar. I don't want the user to see the bar growing green just to experience a "file not allowed" message at the end of the upload.

Best regards,
Mateusz

hi itry this but chunked option seem not working