sansanbgl / jquery-formatcurrency Goto Github PK

Feature request:

I would love if you could add functionality to round to a specifiable
number of decimal places and also do a correct rounding if more are entered.

I will email you a workable solution based on your current SVN repository
which includes unit-tests.

Thanks,
Emmanuel Sambo

What steps will reproduce the problem?
1. $(function() {
    $(".currency").blur(function() {
        $('.currency').formatCurrency({ dropDecimals:false, symbol: '#'  });
    });
});
2.
3.

What is the expected output? What do you see instead?
No cents in the currency

What version of the product are you using? On what operating system?
jquery.formatCurrency-1.1.0.js

Please provide any additional information below.

What steps will reproduce the problem?
1. Set value to be formatted to 154.20
2. Call the .formatCurrency method
3. Formatted value is $154.19

What is the expected output? What do you see instead?
Expected formatted value is $154.20, but output is $154.20 

What version of the product are you using? On what operating system?
jquery.formatCurrency-1.0.0.min.js, on Windows XP, using Firefox 3.0.1

If you use "," as decimal delimmter and "." as thousands delimitter, you cannot 
write 37.000 in input field to get a correct output. That will output 37,00.

The solution is :-)
attatched below... see line 142

The script is combined with some other data useage, just discard that ;-)

Hope you can use it, otherwise a great plugin!
Good job

When starting with a number, dollar sign or minus sign, all letter input is 
automatically replaced as-you-type. However, if you start the input with a 
letter, it does not replace it. To reproduce, simply try entering "hello"

Reported From teyeheimans on usage page comments

I have a float var with the value "33195.5". 

I want it to be displayed as 33.195,50 This plugin however converts it 
incorrect and displayes "331.955,00". 

Bug?? 

My code: 

var sum = 33195.5;$("#field").val(sum).formatCurrency({  
decimalSymbol: ',',  
digitGroupSymbol: '.',  
dropDecimals: false,  
groupDigits: true,  
symbol: ''});

What steps will reproduce the problem?

1. declare a html input <input type="text" id="moneyInput">

2. set method formatCurrency with jQuery in this code 
$('#moneyInput').change(function() $("#moneyInput").formatCurrency();});

3. set a value larger that 9999999.99 and put it in the input text with jQuery 
$("#moneyInput").val(19999999.99);

4. make the event change happend $("#moneyInput").change()

What is the expected output? What do you see instead?
The output value should be $19,999,999.99 but that give me $1.999999.99

What version of the product are you using? On what operating system?
jquery.formatCurrency-1.4.0.min.js

Please provide any additional information below.
i am using jQuery v1.9.0

the value in the html is value="1.999999999E7"

Hey guys,

I'm the maintainer of https://github.com/plentz/jquery-maskmoney which is kinda 
popular. I just looked at your source code and will do basically the same that 
we do. What do you guys think about merging the two projects and joining forces?

I'm asking it because I saw as well that you have quite a bit of issues and 
pull requests open(a few of them we already solved) and I know the work that is 
required to maintain an open source project, so more hands and eyes looking at 
the same code is pretty good.

Well, let me know what do you guys think :)

exports is not defined
[Break On This Error]   

extend(exports, QUnit);

What steps will reproduce the problem?
1. Run qunit in an amd module based on require js


What is the expected output? What do you see instead?
N/A


What version of the product are you using? On what operating system?
qunit 1.5, firefox 10, Chrome 18

Please provide any additional information below.
In my special case we are using qunit to test dojo toolkit components.

I think this is more of a general problem with the detection of environment, 
since you test for typeof require === "undefined", which would be false in case 
of requirejs/dojo, still requirejs/dojo does not define an exports object.

This test is causing the error to occur:
define(
    [ ],
    function () {
        test("Test", function(){
            equal(1, 1);
        });

    }
);

even in your online demo this problem occurs.

What steps will reproduce the problem?
1. Set blur on a text input
2. leave that field blank, click in it, click off it (not changing value of
blank)
3. Sets value to 0.00 incorrectly

What is the expected output? What do you see instead?
Blank, saw 0.00

What version of the product are you using? On what operating system?
1.1

Please provide any additional information below.

When i used india. the methid asNumber({region:"en-IN"}) returns with 
0.34343 for the input of Rs. 34343.00 How can I resolve. 

The website for this project[1] says that the code is licensed under the GNU 
Lesser GPL. The LICENSE.txt file in the released .zip file contains the LGPL 
additions to the GPL (though the GPL is not distributed with the archive so the 
license text is incomplete as distributed).

Yet, the .js files state that they are distributed under the GPL license, 
contradicting the statements above.

In my opinion (I am not a lawyer!) this makes the jquery-formatcurrency plugin 
distributable only under the GPL (since it's not clear whether the LGPL 
additional permissions are in effect).

Also, the FSF informs[2] that LGPL programs also need to distribute the text of 
the GPL since the LGPL text is just an addition and references clauses of the 
GPL.

-- 
[1] - https://code.google.com/p/jquery-formatcurrency/
[2] - https://www.gnu.org/licenses/gpl-howto.html

What steps will reproduce the problem?
1. Convert $39.80 using formatCurrency() 

What steps will reproduce the problem?
1. using the example provided here: 
http://www.bendewey.com/code/formatcurrency/demo/format_as_you_type.html
Change the line
default: $(this).formatCurrency({ colorize: true, negativeFormat: '-%s%n', 
roundToDecimalPlace: -1, eventOnDecimalsEntered: true });
to 
default: $(this).formatCurrency({ colorize: false, negativeFormat: '-%s%n', 
roundToDecimalPlace: -1, eventOnDecimalsEntered: true });

What is the expected output? What do you see instead?
Expected a formatted number as you type. 
Instead typing new digits does change the number displayed. 
eg. typing 546 results in $5


Version 1.4.0
OS : Windows 8

What steps will reproduce the problem?
1.Format any number with some region
2. Set any non from that region symbol

What is the expected output? What do you see instead?
I expect to see the symbol I manually set, not the region one. 


What version of the product are you using? On what operating system?
1.4.0 on windows

Please provide any additional information below.
Why need this? Usually the the currency is one, the number is allways saved on 
that currency no matter from what region you are.

So, if the user is from Spain I will set region es-ES and he will be happy to 
see the number formated as he is used to, but if he also see € but the number 
was saves as $, then we have a problem.

BTW, amazing script, thanks!

Miljan

What steps will reproduce the problem?
1. Use the attached file to reproduce the problem.
2. Enter 1, 10, 100, check the console log -> no problem.
3. Enter 1000 and above, value not recognized.

Please use the attached file to reproduce the issue.

What steps will reproduce the problem?
tried using the dropDecimals argument, but it didn't work. Looked into the
code, and it doesn't seem to be defined at all.


What version of the product are you using? On what operating system?
1.0.0 
CentOS

Thanks!

In case no one else does before google code shuts down.

https://github.com/KrunchMuffin/jquery-formatcurrency

What steps will reproduce the problem?
1. The source is a number with decimals
2. I set the decimalSymbol option to ','
3. The number I get back has 2 extra decimals

What is the expected output? What do you see instead?
When I try to convert 1000.25, I should get $1,000.25 and not $100,025,00


What version of the product are you using? On what operating system?
Mac OS X 10.6.1,  Safari 4.0.3

Steps to reproduce
------------------
1. Let the input element clear by re-visit the page or simply press "Esc" 
character
2. Enter any character but numbers or dot(.) or dash (-) For example "jqu 
ERY_+=\|`~" and 'ro CKS <>?/, *&^%#@!'
3. Also applicable for copy-paste

Expected Output/Actual Output
-----------------------------
The expected output should be Rp. 0 (for regional id-ID) or $0 (default), but 
the actual output is exactly equals to what i type

Version & Platform
-------------------
1.4.0 minified along with regional id-ID pack, Windows XP SP2, Firefox 3.6.6

Notes
-----
Also reproduced in 
http://bendewey.com/code/formatcurrency/demo/format_as_you_type.html at 
formatWhileTypingAndWarnOnDecimalsEntered2 and 
formatWhileTypingAndWarnOnDecimalsEntered element to be precise. See attachment

What steps will reproduce the problem?
1. formatted result (multi-row) currency with <span> option
2.
3.

What is the expected output? What do you see instead?
Each of the row should reflect the currency in the default format

What version of the product are you using? On what operating system?
1.0.0

Please provide any additional information below.

Currently, the following priority is being used in the symbols setting:
  1. defaults
  2. default region
  3. custom symbols
  4. region symbols (with the culture thing)

This does not allow the customization of the region. In my case, I'd like to 
use "pt-BR" region, but remove only the "R$", so I used:
.formatCurrency({ symbol:"", region:"pt-BR" });

When using the region, the custom settings are overrided. As the custom symbols 
are the most specific, I'd like to suggest the following alteration in the 
priority order of symbol settings: 
  1. defaults
  2. default region
  3. region symbols (with the culture thing)
  4. custom symbols

Notice the alteration of points 3 e 4, making it possible to customize the 
regions. Please, let me hear the ressonancy on this topic.


Cheers,
CaioToOn!

What steps will reproduce the problem?
1. Call convert on an input that is blank
2. Value should change from "" to 0

What is the expected output? What do you see instead?
Value should stay "", as there is a big difference between NULL and 0


What version of the product are you using? On what operating system?
1.4.0


Please provide any additional information below.

If you put theese settings

$.formatCurrency.regions[''] = {
        symbol: '',
        positiveFormat: '%n',
        negativeFormat: '-%n',
        decimalSymbol: ',',
        digitGroupSymbol: '.',
        groupDigits: true
    };

after hitting 4 digits result is
123.4

but after hitting fifth digit it's
123,45
and then starts the decimal warning and it's not the same number anymore.

I am reffering at this example
http://bendewey.com/code/formatcurrency/demo/format_as_you_type.html
round to 2 decimal places as you type

I am using last version 1.4.0 on windows 7 and XP.

What steps will reproduce the problem?
1. Create a text field.
2. Enter a plain number in the field, e.g. 1500
3. Use the formatCurrency to format it as a specific region, e.g. fr-FR
4. Use the formatCurrency to format it as a different region, e.g. en-CA
5. Call formatCurrency's asNumber function.
6. The raw number is different.

What is the expected output? What do you see instead?

I'd expect format currency to switch between formats while retaining the 
original number value (so switching formats does not change your raw number).

What version of the product are you using? On what operating system?

Version 1.4.0, Windows 7, Chrome.

Please provide any additional information below.

What's happening is format currency is just removing non-numeric symbols from 
the number, then formatting the number. So if you switch formats, your number 
will change because it's not actually converting it back to a raw number first 
(it's just removing all the symbols and re-formatting that number).

If I set region setting to en-IN then the numbers should be grouped as:
99,99,99,999.00 (99 crores, 99 lakhs, 99 thousand, 9 hundred and ninety nine

instead numbers are grouped as:
999,999,999.00

There is currently no option to disable negative inputs.  I think there 
should be an option allowNegatives (default true), that when set to false 
prevents negatives. 


What version of the product are you using? On what operating system?
jQuery-formatcurrency-1.3.0

It appears rounding rounds to the nearest cent. I need a way to truncate, or 
round down.

Hi,

Not sure it's an issue but you might be interested in my observations.
I've noticed that in several occasions jquery currency uses this code to get or 
set the value/content of an elemnt :

to get : control.is('input, select, textarea') ? 'val' : 'html']()

to set : control[control.is('input, select, textarea') ? 'val' : 'html'](value);




I'm using jquery currency in a table that can contain several hundreds to 
thousands of numbers to "currencify" and i was having performance issues.
I have replaced the above code by using this type of methods :


function GetControlValue(id) {

    var c = document.getElementById(id);

    switch (c.tagName.toLocaleLowerCase()) {
        case "input":
        case "select":
        case "textarea":
            return c.value;
        default:
            if (typeof (c.textContent) != "undefined")
                return c.textContent;
            else
                return c.innerText;
    }
}

function SetControlValue(ctrl, value) {

    var c = document.getElementById(ctrl);

    switch (c.tagName.toLocaleLowerCase()) {
        case "input":
        case "select":
        case "textarea":
            c.value = value;
            break;
        default:
            if (typeof (c.textContent) != "undefined")
                c.textContent = value;
            else
                c.innerText = value;
    }
}


It should be cross browser (I havent fully tested as it is sufficient for my 
own needs and the browsers we support). However the performance gap is pretty 
big so you might want to look into it.

in IE9, calling it 1049 times, i spent 3093ms in formatCurrency. By using my 
Get/Set method i spent 421ms.
Gap in IE7 and 8 was similarly important, in other browsers (chrome and ffx) it 
was not to big as the performance using jquery html method was already very 
good in these browsers. Didn't try in Opera.

Thanks for the great library btw
best regards
Jerome

http://code.google.com/p/jquery-formatcurrency/wiki/Usage

"Changes the contents of the .ageInput field to a number removing any invalid 
characters. Invalid characters include any number, the negative sign -, and the 
decimalSymbol. "


What does it mean that any number is invalid?

Originally I thought it must be a mistake, but I see that almost the first page 
comment, from way back in 2009, is about this, so it seems unlikely the page 
has been wrong for years -- is it possible to explain on the page what this 
means, because it really seems very confusing?

What steps will reproduce the problem?
1.  Add a negative number and call formatCurrency on it, shows up red and
in parentheses
2.  Try to convert it back to a number with asNumber
3.  Number comes back as positive instead of negative

What is the expected output? What do you see instead?
Expect if it was negative when formatCurrency was called, it should come
back as negative when asNumber is called on the same field

What version of the product are you using? On what operating system?
formatCurrency 1.2, FF 3.0.15, jquery 1.3.2

Please provide any additional information below.
Been trying to patch it myself, but haven't quite figured it out yet.

Hello,
i use format like

$.formatCurrency.regions['de-DE'] = {
                symbol: '',
                positiveFormat: '%n %s',
                negativeFormat: '-%n %s',
                decimalSymbol: ',',
                digitGroupSymbol: '.',
                groupDigits: false
            };

It works fine ... but i get a space at last character in my inputs.
How can i prevent this ?
Thanks
Jürgen

What steps will reproduce the problem?
1. Put any negative number between 0 and -1 for example -0.25 in a textbox.
2. Apply the formatCurrency with standard options. 

What is the expected output? What do you see instead?
(0.25) according to the default negative number representation, but the 
result is 0.25. The number seems to be considered as positive.

I think this is because of this check

// format number
var numParts = String(num).split('.');
num = numParts[0];
var isPositive = (num == (num = Math.abs(num)));

0 is an unsigned number so it will result all the time as positive number, 
but -0.25 is not positive.

Sorry for the noob question but... why you don't check simply for

num < 0

What version of the product are you using? On what operating system?

formatcurrency 1.1.0 in windows XP SP3. But I don't think it's an issue 
related to the OS

Regards.

What steps will reproduce the problem?
1. http://jsbin.com/iniri3/5/edit
2. Alternatively from #1, go to 
http://bendewey.com/code/formatcurrency/demo/format_as_you_type.html and type 
in "-.01" in bottom left input field.

What is the expected output? What do you see instead?
Expected output: -$0.01
Actual output: ($NaN.01)

What version of the product are you using? On what operating system?
jQuery 1.3.2 with latest jquery-formatcurrency as of 6/23/10.

Please provide any additional information below.

formatCurrency = function( num ) {
    return $('<span />').text( num ).formatCurrency().text();
}

$('#button').on('click', function() {
    $this = $(this);
    for (i=1.5; i<=10.5; i++) {
        $this.parent().append('<p>'+formatCurrency(i)+'</p>');
    }
});

This code should create 10 paragraph tags, each with a different dollar amount, 
and append them to the parent of the #button element. However, because both 
this function and the plugin use "$this = $(this);" there is a scope issue, and 
my local variable $this gets overwritten.

While this issue can be corrected by changing my local code to an explicit 
declaration ("var $this = $(this);") the plugin should explicitly declare $this 
as a new variable to prevent this from happening.

A user requested via email that we add a setting to remove decimal places.

From Daniel Scullin:
-----------------------------
Yeah, please do commit it. 

The context in which I'm using it is in the real estate business. Houses 
listed on the website need to be formatted as currency, but not down to 
the cents. My client asked if I could drop the .00

Since it is (displayed as) currency, I don't see an absolute need for a 
numberOfDecimalPlaces property since a currency displayed as $1,000.5 or 
even $1,000.53213 might be misinterpreted. I'd have to say the rounding 
logic is beyond the scope of your library and you should leave that 
portion to the business objects.

BUT (there is always a BUT)... If any math calculations will be done with 
your library, you need to allow for any number of decimal places. For 
instance, If I ordered 16.457 yards of lumber at $4.00 per yard.... the 
price technically would have 3 decimal places ($65.858) but again, this 
business logic may be beyond the scope of your project.

My .0002 cents. Thanks for you help and your nice jquery contribution!

-DJ
On Mon, Jun 22, 2009 at 9:20 PM, Ben Dewey <[email protected]> wrote:
Great are you okay with me commiting this?  Do you see any benefit to 
using a numberOfDecimalPlaces setting that could be set to 0?

-Ben

From: Daniel Scullin [mailto:[email protected]] 
Sent: Monday, June 22, 2009 3:28 PM
To: Ben Dewey
Subject: Re: FormatCurrency Decimals

I just did a

if (!settings.dropCents) {
  num = num + settings.decimalSymbol + cents;
}


And initialized it via $(".currency").formatCurrency( {dropCents: true} );

This seems to work while maintaining the default behavior. Thanks for your 
help Ben!

-DJ
On Mon, Jun 22, 2009 at 2:11 PM, Ben Dewey <[email protected]> wrote:
Daniel,

There isn’t currently a setting to disable that.

Although you can modify the code to support this.

Comment out the line that says. 

num = num + settings.decimalSymbol + cents;

by putting two // in front of it.

Please note, that this breaks the default behavior.  If you’re interested 
in supporting both the default behavior and the noCents setting, then let 
me know I’ll try to help you come up with something different.

-Ben Dewey


From: Daniel Scullin [mailto:[email protected]] 
Sent: Monday, June 22, 2009 12:23 PM
To: [email protected]
Subject: FormatCurrency Decimals

Howdy Sir,

Using your jquery formatcurrency library, is there a way to drop the 
cents? For example...

1123.00 results $1,123

Any suggestions are appreciated. Thanks!

-DJ

What steps will reproduce the problem?
1. Enter some numeric value say 54321, this gets converted to 54,321
2. Now place the cursor at number "4" and delete it
3. Cursor goes back to end of the field, rather than staying at the location 
where delete button was pressed

What is the expected output? What do you see instead?
Cursor should stay in the position where delete event was fired

What version of the product are you using? On what operating system?
Windows 7

Please provide any additional information below.

What steps will reproduce the problem?
1. Open the example
2. Type a big number
3. Move the cursor to the first character
4. Press shift, command, control or alt.

What is the expected output? What do you see instead?
When you press any of these keys the cursor is moved to the end of the field 
(the content of the 
field is reloaded/reformatted, but this is not necessary because the value is 
the same)

What steps will reproduce the problem?
1. Set input element value to 1,234.56.
2. Call $(element).formatCurrency({ symbol: ''}); on input element.
3. Verify input element value is 0.

What is the expected output? What do you see instead?
See above.

What version of the product are you using? On what operating system?
jquery.formatCurrency-1.2.0.js, IE8 & Chrome

Please provide any additional information below.

Bugfix:
1. Removed 'symbol|' part from regex, we want to strip all symbols
2. Replaced '.' wildcard character with '\\.'

function generateRegex(settings) {
    var decimalSymbol = settings.decimalSymbol.replace('.', '\\.');
    return new RegExp("[^\\d" + decimalSymbol + "-]", "g");
}

Hello, 

I am getting a "SCRIPT438: Object doesn't support property or method 
'formatCurrency'" error when I try to format a value in an ASP hidden field and 
textbox. 
I successfully used the library in 3 other pages, and here is the code for the 
problematic 4th page (breaks at var test=...):
{{{
function RefreshGrid() {
            var nRow = $('#tblCreditNote').dataTable().fnGetNodes();
            for (var i = 0; i < nRow.length; i++) {
                var Total = (nRow[i].children[6].children[0].innerHTML * nRow[i].children[7].children[0].innerHTML).toFixed(2);
                $("input[id$='hfUnformatted']").val(Total);
                var test = $('.hidden').val(Total).formatCurrency().val(); 
.
.
.
}
}}}

The License File indicates LGPLv3, however, the Scripts are all marked as 
GPLv3.  With the GPLv3 markings in place, this would make all the Java Scripts 
GPLv3 and not LGPLv3.

Related to licensing, instead of purely LGPLv3/GPLv3, as to provide greater 
flexibility and compatibility with other Open Source Licenses, would the 
authors be willing to change the licensing to be the same as jQuery and other 
jQuery Plugins (Dual Licensed, MIT or GPL)?

Thanks,Jeff

The Malaysian currency symbol is incorrect it should be 'RM' and not 'R'. Also 
incorrect are decimal symbol, decimal separators.To work around just update the 
jquery.formatCurrency.ms-MY.js script file.

united states dollars

What steps will reproduce the problem?
1. Enter a value into one of the boxes on the demo page.
2. Click somewhere in the middle of the value you just entered.  
3. Enter a digit.

What is the expected output? What do you see instead?
I expect the cursor to stay where I am inside the string, so I could enter more 
digits. Instead, the cursor will be taken to the end of the input, before you 
can type another character.

What version of the product are you using? On what operating system?

I ran this using the demo on here, using Chrome on Windows Vista.
Please provide any additional information below.

What steps will reproduce the problem?
1. call $([]).asNumber();

What is the expected output? What do you see instead?
null is not an object error is returned