Giter VIP home page Giter VIP logo

sapui5's Introduction

REUSE status

Contributions to the SAPUI5 Documentation

Found a mistake in our documentation? Always wanted to add a step in one of our procedures that could save many others much time? Then you're at the right place! All contributions made to the Markdown files in the docs directory are reviewed, and if deemed valuable be added to our official documentation in the SAPUI5 Demo Kit. The easiest way is to start there, and choose Edit on GitHub to find the right Markdown file to contribute to.

Requirements

For contributions, it's required that you have a GitHub account. For more information, see Signing up for a new GitHub account in the GitHub documentation.

Contributing

We recommend using the SAPUI5 documentation in the SAPUI5 Demo Kit as a starting point for contributions:

  1. Open the SAPUI5 Documentation.
  2. Choose Edit to suggest a change for the current page you see in the SAPUI5 Demo Kit.

If you only make a small contribution, that's the quickest way to propose a change. For larger contributions, we recommend forking this repository to work locally. The filenames in the docs directory are created based on the title of the page in the SAPUI5 Demo Kit.

More information: Contribution Guidelines

Code of Conduct

Adhere to the SAP Open Source Code of Conduct to ensure a welcoming and open culture for everyone involved in contributions to SAP documentation.

Licensing

See our LICENSE for copyright and license information.

sapui5's People

Contributors

andre-schaerpf avatar boghyon avatar ditaccms-bot avatar divyavd avatar dstork avatar fariddotnet avatar fredatwork avatar hhelibeb avatar jannalisa avatar jberthe avatar kaijainga avatar klattg avatar kvm2 avatar lemaiwo avatar marianfoo avatar mgnther avatar mishuagrawal avatar narendran-nv avatar naxos84 avatar nlunets avatar o-liver avatar oli4-k avatar olmue avatar pubmikeb avatar qmacro avatar sebastianesch avatar simonarangelova avatar siyaaleksieva avatar stefanrutzmoser avatar tobiashofmann avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

sapui5's Issues

Is the the documentation regarding Read Access Logging (RAL) support correct?

Hello SAPUI5 Documentation Team,

on the documentation page SAP Gateway Export versus Client Export there is the statement

RAL is not supported because the SAP Gateway export is carried out by a server process that does not run in a specific user context.

in column "SAP Gateway" for the feature "Read Access Logging (RAL) support". I don't think that is correct as the request to SAP Gateway will still be executed in a user context. Maybe @anfisc can provide some input here.

Best Regards
Gregor

Code sample full of ` `

https://sapui5.hana.ondemand.com/sdk/#/topic/02fb273ee1024fec914b11befe2b1887

can´t attach a screenshot currently, so here is the faulty sample

"card007_ProductsOutOfStock": {
  "model": "salesOrder",
  "template": "sap.ovp.cards.stack",
  "settings": {
    "itemText": "{{stackCard_itemText}}",
    "title": "Products Out of Stock",
    "subTitle": "SalesOrderSet Stack Card",
    "requireAppAuthorization": "#Action-toappnavsample",
    "entitySet": "SalesOrderSet",
    "identificationAnnotationPath": "com.sap.vocabularies.UI.v1.Identification,com.sap.vocabularies.UI.v1.Identification#item2",
    "objectStreamCardsSettings": {
      "showFirstActionInFooter": false,
      "customActions": [
        {
          "text": "text1",
          "press": "press1",
          "position": 1
        },
        {
          "text": "text2",
          "press": "press2",
          "position": 10
        },
        {
          "text": "text3",
          "press": "press1",
          "position": 3
        },
        {
          "text": "text4",
          "press": "press2",
          "position": 8
        },
        {
          "text": "text5",
          "press": "press1",
          "position": 5
        },
        {
          "text": "text6",
          "press": "press2",
          "position": 6
        }
      ]
    }
  }
}, 

Issue in the generated links on the deployed version

Issue description

Issue Description

When I open the (deployed version of the) documentation page: Extension Points for Tables

and I click on the link:

For more information, see Configuring Responsive Behavior of a Table.

then my browser gives me the error 404 The requested resource is not available.

The same issue occurs with the link:

For more information, see Using the Export Feature.

Screenshots

Screenshot 2023-09-27 at 09 19 31
Screenshot 2023-09-27 at 09 19 15
Screenshot 2023-09-27 at 09 19 40

Further information

When I open the corresponding markdown page by clicking on "Edit on GitHub", the links work properly.

https://github.com/SAP-docs/sapui5/blob/main/docs/06_SAP_Fiori_Elements/extension-points-for-tables-d525522.md

Feedback Type (Optional)

linking

Page Title on SAP Help Portal (prefilled)

No response

Page URL on SAP Help Portal (prefilled)

No response

Dynamic hiding/showing columns with OData V2 and CDS Annotations

Issue description

Hello.

I am using odata v2 with adapter from v4 (because we are using CAP Model). And I see in your documentation this example to dynamically show/hide coulmns in table.

DataField Records in Tables

To hide table columns, the UI.Hidden path needs to refer to the property of the header instance, for example:

In the following example, STTA_C_MP_Product is the entity set of the object page header and STTA_C_MP_ProductText is the entity set of the smart table on the object page, and to_Product is the navigation property from STTA_C_MP_ProductText to STTA_C_MP_Product.

But I am using cds annotations and trying to do the same. But there is no some affect when I put it in LineItems Annotation. It works well in FieldGroup, but not in LineItems.

My question: how I can make dynamic visible of columns with OData V2 and cds annotations?

image image image image

Feedback Type (Optional)

clarity

Page Title on SAP Help Portal (prefilled)

Additional Features in SAP Fiori Elements for OData V2 DataField Records in Tables

Page URL on SAP Help Portal (prefilled)

https://sapui5.hana.ondemand.com/sdk/#/topic/ca00ee45fe344a73998f482cb2e669bb.html

[doc issue] Missing documentation to Event Buses

Missing documentation to Event Buses

Hello Documentation Team,

Recently, I faced an issue trying to access controllers of child views inserted in the parent view. The concept of event buses really helped to reduce lines of code and to make the entire inter-controller-communication easier (in case there are better ways to solve this problem, please let me know). However, the event bus feature was overlooked by our team for quite some time, since there weren't any documentation pages referring to the feature, but only a single API reference page instead. There are a couple documentation pages describing how to incorporate child views using multiple targets, but no description how these child controllers should interact with each other & communicate information. Event buses also come in handy when generally dealing with publishing custom events, which is why I'm proposing a documentation page for the event bus feature.

Feedback Type (Optional)

None

Page Title on SAP Help Portal (prefilled)

No response

Page URL on SAP Help Portal (prefilled)

No response

[doc issue] Why is Asynchronous Loading both deprecated and recommended?

Issue description

I'm new to UI5 and am currently deciding if I should set data-sap-ui-async="true" for my new UI5 project.

However, I'm finding this option listed as deprecated on Deprecated and Experimental Configuration Options while recommended at Use Asynchronous Loading.
image

image

I am a bit confused now. If the option is deprecated, does it mean it could be removed in the future and I should not use it for new projects? If so, why is the option still listed as recommended?

Feedback Type (Optional)

clarity

Page Title on SAP Help Portal (prefilled)

Deprecated and Experimental Configuration Options

Page URL on SAP Help Portal (prefilled)

https://sapui5.hana.ondemand.com/sdk/#/topic/b474a712ca364d40a1b0a804baf2d734

Fiori Element Add column to table missing crucial information

Issue description

The documentation of extending Fiori Element responsive table is missing the name of the fragment files you are supposed to create. It mentions you need two extensions, then it provides code for the two extensions, but it only specifies the file name for the second code snippet. It took me hours to find out what I was doing wrong.

https://sapui5.hana.ondemand.com/#/topic/28e95702b5854b938ac51c4bc2d078ab.html

The first code snippet needs to mention create a file: webapp/ext/fragments/ListReportResponsiveTableCells.fragment.xml

The equivalent doc for grit table extension is also missing this crucial piece of information.

Also, the documentation fails to indicate how to deploy this FE extension and run it in Fiori Launchpad. How do you ensure your new columns will be available when users click on the original app's tile?
I'm still stuck on that, trying to find other online sources to explain the process.

Thanks

Feedback Type (Optional)

examples or samples

Page Title on SAP Help Portal (prefilled)

Example: Adding Columns to a Responsive Table in the List Report

Page URL on SAP Help Portal (prefilled)

https://sapui5.hana.ondemand.com/#/topic/28e95702b5854b938ac51c4bc2d078ab.html

Small Problem with API Docu for sap.suite.ui.microchart.ColumnMicroChart

Issue description

"When no custom tooltip is defined, the tooltip is generated automatically based on the logic described in sap.ui.core.Element#getTooltip_AsString."

Unfortunatly there is no (longer?) description of any logic behind the link.

Feedback Type (Optional)

content gaps

Page Title on SAP Help Portal (prefilled)

sap.suite.ui.microchart.ColumnMicroChart - API Reference - Demo Kit - SAPUI5 SDK

Page URL on SAP Help Portal (prefilled)

https://ui5.sap.com/#/api/sap.suite.ui.microchart.ColumnMicroChart%23overview

Value help dropdown Query

Hi,

I am implementing multivalue dropdown filter in ALP floor plan. I would like to know, if there is a possibility to show "All" in the default state in the dropdown?
In my case the dropdown is under the compact filters of Analytics List Page. I would like to display "All" in the dropdown, the first time the page is loaded.

Screenshot 2023-11-22 at 12 12 33
I have visited : docs/06_SAP_Fiori_Elements/value-help-as-a-dropdown-list-2a0a630.md But If you could also point me to the sample code, if there is any apart from https://github.com/SAP-samples/fiori-elements-feature-showcase/tree/main.
Thanks!

Support Assistant tool issue

Hello Team,
we are getting Support assistant high priority issue for "editable" property of sap.ui.layout.form.Form
Either setting editable property or not, still its throwing high priority issue.
As of now we have only non-editable content in our form.
The editable property of the Form is used to align the Labels and add screen reader information.
For more detail refer below screenshot.
Please guide how to resolve this issue?

support assistant issue

[doc issue] Inconsistent casing for configuration options in doc

Issue description

I was browsing through sample code from the documents and wanted to find clarification for some configuration options used for UI5 loading.
However, I was unable to find some configuration options used in sample code from Configuration Options and URL Parameters.

Upon further investigation, I realize the issue was inconsistent casing. The documentation presented sample code lines with camelCase or lowercase for options, whereas Configuration Options and URL Parameters exclusively showcased kebab-case.

I find it would be easier for me (and fellow UI5 beginners) if all sample code in the documentation uses the same casing convention for configuration options.

Example samples not using kebab-case:

Step 1: Ready...:

	<script id="sap-ui-bootstrap"
		src="https://sdk.openui5.org/resources/sap-ui-core.js"
		data-sap-ui-theme="sap_belize"
		data-sap-ui-libs="sap.m"
+		data-sap-ui-resourceroots='{"Quickstart": "./"}'
+		data-sap-ui-onInit="module:Quickstart/index"
+		data-sap-ui-compatVersion="edge"
		data-sap-ui-async="true">
	</script>

We can find more relevant pages by searching for resourcingroots, onInit, or compatVersion in doc.

Example:
image

Feedback Type (Optional)

examples or samples

Page Title on SAP Help Portal (prefilled)

Configuration Options and URL Parameters

Page URL on SAP Help Portal (prefilled)

https://sapui5.hana.ondemand.com/sdk/#/topic/91f2d03b6f4d1014b6dd926db0e91070

[Fiori element JourneyRunner code coverage of extended view controller]

Issue description

I have added a opaTests.qunit.html to below code but its unable to recognise the code coverage which is available on ext folder (where we have custom view and controller)

<script src="/resources/sap/ui/qunit/qunit-coverage-istanbul.js"
data-sap-ui-cover-only="projectui/ext"
data-sap-ui-cover-never="../test/"></script>

Feedback Type (Optional)

None

Page Title on SAP Help Portal (prefilled)

No response

Page URL on SAP Help Portal (prefilled)

No response

HTML in <code> tags not escaped properly

The following page contains &nbsp; in the sentence Trailing spaces in text lines are escaped with in the respective BSP pages..

https://github.com/SAP-docs/sapui5/blob/main/docs/05_Developing_Apps/technical-remarks-5a814d9.md

The markdown is correct. However, it's not rendered right:

https://sapui5.hana.ondemand.com/#/topic/5a814d9945d148b0a1ad941791c3c723

The following is not correct:

<code>&nbsp;</code>

The content of the <code> tags must be escaped at render. It should be:

<code>&amp;nbsp;</code>

Please fix the markdown renderer.

Sample: Walkthrough - Step 26 - Mock Server Configuration - Issue in downloaded file "mockServer.html"

Issue description

Hi colleagues,

during my Walkthrough exercise (Step 26) I've downloaded complete source code of this exercise. I've realized issue in downloaded file mockServer.html in attribute src. Downloaded file contains wrong value "resources/sap-ui-core.js", but I assume the right value is "../resources/sap-ui-core.js". You can check it against source code for mockServer.html displayed directly at this Walkthrough exercise. With wrong value in the code I was not able to run the exercise.

Thank you for double checking and correction :)

Kind regards
Michal

The standard "Create Object" text is not updated after configured in i18n

Describe the bug
Unable to update the "Create Object" button text.

To Reproduce
Steps to reproduce the behavior:

  1. After implementing https://sapui5.hana.ondemand.com/sdk/#/topic/189e2d8a59f04a2693a4fde7f4a91a65 , when click on create button will display two options. "Create Object" and "Create with Filters", however after configured the key in i18n based on the documentation stated, the "Create Object" button still doesn't reflect as per the text maintained in i18n.
    image

image

image

Expected behavior
After configure the key in i18n, the "Create Object" text should be replaced with what is maintained in i18n.

Actual Result
The text is not updated
image

Logs/Console Output
N/A, no error.

  • UI5 version: 1.111.0
  • OS: Windows 10
  • Browser + Version : Chrome Version 113.0.5672.127

[doc issue] example not runnable; no manifest.json

Issue description

Hello,
during implementation of the first step of the getting started I encountered an issue.
Running this example with the given package.json results the following error:

Error Message:
Could not find required manifest.json for project sap-m-tutorial-quickstart-01: Could not find resource /manifest.json in project sap-m-tutorial-quickstart-01`

Serving the manifest.yaml would solve this issue :-)

Feedback Type (Optional)

content gaps

Page Title on SAP Help Portal (prefilled)

Step 1: Ready...

Page URL on SAP Help Portal (prefilled)

https://github.com/SAP-docs/sapui5/blob/main/docs/03_Get-Started/step-1-ready-851bde4.md

Documentation missing for important `sap-ui-xx-viewCache` url parameter

Issue description

Hi there,

I noticed that the sap-ui-xx-viewCache url parameter is not documented (at least not in this camel case form), although it is being used in a lot of samples and templates. While the sap-ui-xx-view-cache (in kebab case) parameter is documented (and seems to be doing the same thing), it is unfortunate that there are no useful hits when searching for sap-ui-xx-viewCache in the global search - despite this being one of the most used url parameters, especially during development. To further improve the search, I would also suggest to include the actual url parameters in their long form somewhere on the page (sap-ui-xx-viewCache), instead of just the short forms (xx-viewCache).

Best, Nico

Feedback Type (Optional)

content gaps

Page Title on SAP Help Portal (prefilled)

Deprecated and Experimental Configuration Options

Page URL on SAP Help Portal (prefilled)

https://sapui5.hana.ondemand.com/#/topic/b474a712ca364d40a1b0a804baf2d734

Missing documentation about the Fiori Elements Test libraries

Hi together,

It's great to now allow the whole community to improve the documentation around SAPUI5 and I want to do my part 😃.

I would like to contribute the missing documentation for the FioriElements Test libraries V2 and V4. These have, in my opinion, never been given proper documentation or announced publicly.

For that I just started to write down the first steps for the V2 integration on a fork. Here I might need some input from you to bring this forward:

  • Is it from your point of view at all wanted to add a documentation for these topics?
  • Is there any technical documentation of the available functions (especially for V2) other than the JSDoc documentation in the source code?

Best regards,
Simon

Walkthrough Tutorial -> Step 9: Component Configuration -> webapp/Component.js: wrong bundle name

Issue description

Hi colleagues,

I've realized small bug in Walkthrough exercise -> Step 9: Component Configuration -> webapp/Component.js. Here is defined bundle as "sap.ui.demo.walkthrough.i18n.i18n", but correct name is "ui5.walkthrough.i18n.i18n". Please double check my finding (e.g. with bundle from previous step = Step 8: Translatable Texts). And thank you for correction! :)

Kind regards,
Michal

P.S. I like this Walkthrough ;)

[doc issue] Missing modification in Step 4: Two-Way Data Binding for file index.html

Issue description

I discovered an omission in Tutorial Step 4: Two-Way Data Binding. There is an essential modification in the index.html file, the attribute data-sap-ui-resourceroots , which is present in the provided code sample but not described in the tutorial text. This omission leads to exception when following the code provided in the tutorial.
There is no data-sap-ui-resourceroots in step 3,
图片
but we can find it in step 4,
图片

Please consider updating the tutorial to include the missing modification found in the index.html file.

Feedback Type (Optional)

content gaps

Page Title on SAP Help Portal (prefilled)

Step 4: Two-Way Data Binding

Page URL on SAP Help Portal (prefilled)

https://sapui5.hana.ondemand.com/sdk/#/topic/c72b922fdb59422496661000165d7ff1

Walkthrough Step 28 not complete

When programming the Walkthrough Step 28, there is something missing.
In the NavigationJourney.js there are 4 steps:

  • Given: iStartMyUiComponent
  • When: onTheAppPage.iPressSayHelloWithDialogButton
  • Then: onTheAppPage.iShouldSeeTheHelloDialog
  • Then: iTearDownMyApp
    The problem is that after this there are only 2 of the 4 implemented (in pages/App.js)
    because of this, the test does not work according to the walkthrough
    Please add those two steps so that the test works
    thanks

[doc issue] quickstart tutorial doc code issue

Issue description

Hello Team,

I was following the tutorial "Quickstart" and got unexpected results at Step 2: Steady...

I can't get expected inline button and interactive Message Toast if I followed the code mentioned on the page. However, I changed the code in webapp/index.js and webapp/App.view.xml, then it worked fine.

Affected code:

  1. webapp/index.js
    line 6
    tutorial version: XMLView.create({viewName: "Quickstart.App" ......
    my version: XMLView.create({viewName: "ui5.quickstart.App"} ......

  2. webapp/App.view.xml
    line 2
    tutorial version: controllerName="Quickstart.App"
    my version: controllerName="ui5.quickstart.App"

After changing the code, I'm able to successfully run the program and get the button and subsequent Message Toast.

Feedback Type (Optional)

spelling or grammar

Page Title on SAP Help Portal (prefilled)

No response

Page URL on SAP Help Portal (prefilled)

https://ui5.sap.com/#/topic/128214a9b2754b15aec5e365780b03fd

Document adaptation project's appdescriptor 'validAppVersions' settings

A mismatch between the through BAS generated Adaptation Project's manifest.appdescr settings on validAppVersions and the sap.app/id version after a SP update caused the application to stop functioning.
The fact that it no longer worked in itself is of course not an issue, but the fact that it was automatically locked to that version in combination with a lack of documentation. It was hard to figure out why the extension's logic was not being invoked.

We looked for documentation on these settings but could not find any!

 "validAppVersions": {
        "creation": "1.0.126",
        "from": "1.0.126",
        "to": "1.0.126"
}

In particular, we need to know if we leave out minor and/or patch levels from the version targets.

Related to: docs/06_SAP_Fiori_Elements/extending-delivered-apps-using-adaptation-extensions-52fc48b.md

Demo Kit: image thumbnail and caption clickable but nothing happens

  1. Visit a Demo Kit documentation page that contains an image thumbnail with a caption. E.g. https://ui5.sap.com/#/topic/239b1922758645e7b451e01ded7f56bc (Scroll down to the "Additional Features in SAP Fiori Elements for OData V4" section to see them).
  2. Click on "Message Popover: Chevron Navigation to Message Details" or the image thumbnail.

Fiori elements documentation - Using Messages broken clickable thumbnail

Apart from nothing happening on click, the layout seems to be incorrectly rendered too.

It is also unclear where the image thumbnails actually come from. The source https://github.com/SAP-docs/sapui5/blob/b33d3c0b11a6b7f5883bf9aea8ab14ceeae051e8/docs/06_SAP_Fiori_Elements/using-messages-239b192.md has no references to the thumbnails.

[doc issue]

Issue description

The hyperlinks in the manifest.json documentation are all wrong!!

Feedback Type (Optional)

linking

Page Title on SAP Help Portal (prefilled)

No response

Page URL on SAP Help Portal (prefilled)

No response

[doc issue] Localization of UI Texts

Issue description

Edit: correction of the typo in "sap-language"

Hello,

I have noticed an issue with the ABAP CDS Localization of UI Texts.
It is about the following SAP documentation :

I have tried to implement it as described an I am using a List Report to display some demo data from the new flight data model.

I defined the line item in a Metadata Extension file:
@UI.lineItem: [{position: 70, label: '{i18n>TotalPrice}'}] TotalPrice;

And added the key-value pair into the i18n.properties file.
To this point, everything works perfectly fine.

But when i add another i18 file, in my example for the german langauge e.g. i18n_de.properties the language specific Text is not read and the standard sap-label (if existent) or the datafield name is shown wen loding the app in the preview (BTP BAS) with url parameter sap-language=de .

Changes to the app title are working fine. And the text is availiable in the networktab in the Browser DevTools. So I think this is an issue with the SAPUI5 Framework...

My expectation would be, that the localization via CDS annotation is also working for every other langauge file. Otherwise this way of implementation would not make sense.

Feedback Type (Optional)

other

Page Title on SAP Help Portal (prefilled)

Localization of UI Texts

Page URL on SAP Help Portal (prefilled)

https://sapui5.hana.ondemand.com/sdk/#/topic/b8cb649973534f08a6047692f8c6830d

Horizon theme missing in `Theme Parameter Toolbox`

Hi team,

I believe the sap_horizon and sap_horizon_dark themes are missing in the Theme Parameter Toolbox. They are available for quite a while now so I think they should be added there.

Looking forward to hearing back from you!

Missing showCurrentTimeButton & showCurrentDateButton function in Smartform Smartfields

Issue description

In DateTimePicker it is possible to use a shortcut for navigating to the current date or time (sap.m.DateTimePicker, property: showCurrentDateButton & showCurrentTimeButton). Is it possible to use these functions in a Smartfield?

https://experience.sap.com/fiori-design-web/datetime-picker/#today-button
image

Feedback Type (Optional)

examples or samples

Page Title on SAP Help Portal (prefilled)

No response

Page URL on SAP Help Portal (prefilled)

No response

[doc issue] Where do I find detailed reference for `sap.m.ObjectListItem`'s `number` attribute?

Issue description

Hi there, do you know where I can find detailed reference for sap.m.ObjectListItem's number attribute?

In Sample: Object List Item
The ObjectListItem's number attribute seems to be an object string with some pre-defined fields.
image

However, I cannot find supported fields from ObjectListItem's API reference at https://ui5.sap.com/#/api/sap.m.ObjectListItem%23controlProperties
image

Thank you!

Feedback Type (Optional)

clarity

Page Title on SAP Help Portal (prefilled)

class sap.m.ObjectListItem

Page URL on SAP Help Portal (prefilled)

https://ui5.sap.com/#/api/sap.m.ObjectListItem%23controlProperties

Why is there no list of all available themes?

Hi team,

A colleague who is new to UI5 recently approached me and asked for a list of all the available Fiori themes in UI5. I went on to search in the docs but I think this list actually doesn't exist. Please correct me if I'm wrong.

My suggestion is to include such a list here: markdown file - web page

Looking forward to hearing back from you.

Controller Code for Sample Input Checked does not work

Hi,

the sample for Input - Checked (https://ui5.sap.com/#/entity/sap.m.Input/sample/sap.m.sample.InputChecked) does not work.

In the Controller code https://ui5.sap.com/#/entity/sap.m.Input/sample/sap.m.sample.InputChecked/code/C.controller.js the function _validateInput needs to be corrected from:

_validateInput: function (oInput) {
	var sValueState = "None";
	var bValidationError = false;
	var oBinding = oInput.getBinding("value");

	try {
		oBinding.getType().validateValue(oInput.getValue());
	} catch (oException) {
		sValueState = "Error";
		bValidationError = true;
	}

	oInput.setValueState(sValueState);

	return bValidationError;
},

to:

_validateInput: function (oInput) {
	var sValueState = "None";
	var bValidationError = false;
	var oBindingInfo = oInput.getBindingInfo("value");

	try {
		oBindingInfo.type.validateValue(oInput.getValue());
	} catch (oException) {
		sValueState = "Error";
		bValidationError = true;
	}

	oInput.setValueState(sValueState);

	return bValidationError;
},

Kind regards,
Sebastian

Transition to TS samples

Issue description

The official endorsement of TypeScript & the drop of the beta for the support for it are great things for the framework and seem to set a positive direction for the future of the technology.

However during a recent visit to the documentation page (and also to the SDK in general) it came to me that all the samples in both the docs & in the mini apps in the 'samples' section still very much use var _aMyCustomEnum = ['Foo', 'Bar'] type of code.

While providing a general idea, this style of code is not only old but also contradicts the best practices encouraged for both TS & modern ES development, which may mislead or confuse newcomers - videos, books, blogposts all encourage modern ES use while official docs/samples have not been migrated (rewritten).

Therefore I thought it might be good idea to at least ask what the status & plans on possible migration of such samples are?

Are PR's with sample rewrites to be accepted? If yes this could help a bit the core maintainers with the migration effort.

Sorry if this has been clarified somewhere & I am missing it, otherwise It'd be nice to know.

Thanks & BR

Dimitar

Feedback Type (Optional)

clarity

Page Title on SAP Help Portal (prefilled)

No response

Page URL on SAP Help Portal (prefilled)

No response

Double `#` in the URL on a link on `https://sdk.openui5.org/nightly`

Issue description

If we check the description of sap.ui.core.Core.byId, we find out that this method is deprecated:

Deprecated as of version 1.119. Please use Element.getElementById instead.

We click on a proposed link and everything is OK.

However, in case of
https://sdk.openui5.org/nightly/#/api/sap.ui.core.Core%23methods/byId, the proposed link contains an extra #: https://sdk.openui5.org/nightly/#/#api/sap.ui.core.Element%23methods/sap.ui.core.Element.getElementById, and this link is wrong, leading to the error:

The requested resource was not found.

The correct link is:

https://sdk.openui5.org/nightly/#/api/sap.ui.core.Element%23methods/sap.ui.core.Element.getElementById

Feedback Type (Optional)

linking

Page Title on SAP Help Portal (prefilled)

class sap.ui.core.Core.byId

Page URL on SAP Help Portal (prefilled)

https://sdk.openui5.org/nightly/#/api/sap.ui.core.Core%23methods/byId

How to make Dynamic visibility of custom action in manifest.json with OData V2?

Issue description

Hello!

I am using Fiori Elements with OData V2 and I added custom action in Header on ObjectPage in manifest.json.

"Header": {
    "Actions": {
        "MyCustomAction": {
            "text": "Custom Action",
            "press": "onPressMyCustomAction",
            "applicablePath": "ui>/editable"
        }
    }
}

I want to show my button only in view mode, but in edit mode I want to hide this button. I found this property applicablePath but as I understand it works only with path to some field, but I don't know how to make it works with inverted value something like this "applicablePath": "!{ui>/editable}".

In my case "applicablePath": "ui>/editable" it is shown in edit mode, but in view mode is hidden.
Is there some option to make it work with inverted value (!true to make it false)?

I know that in OData V4 applications we can make basic expression binding in visible property of action. Something like this:

"actions": {
    "MyCustomAction": {
        "press": "onPressMyCustomAction",
        "text": "Custom Action",
        "visible": "{= !{$ui>/editable} }"
    }
}

Is it possible to make something similar with OData V2 Fiori Elements?

Feedback Type (Optional)

clarity

Page Title on SAP Help Portal (prefilled)

Additional Features in SAP Fiori Elements for OData V2 Action for the object page header

Page URL on SAP Help Portal (prefilled)

https://sapui5.hana.ondemand.com/sdk/#/topic/7619517a92414e27b71f02094bd08d06.html

Query regarding "Adapting the UI: Analytical List Page"

Hi,

I am newbie to Fiori elements. I have been working on sing floorplan Analytics List Page wit Odatav4. I would like to customize chart toolbar. Customizations are as follows:

  • Adding a download button
  • Removing the showlegend & Zoom in/out button
  • Remove the header title of the chart

I did come across this documentation : https://sapui5.hana.ondemand.com/sdk/#/topic/2c5fa29df37c4d13b5142ed7b484b274.html:~:text=showChartTypeSelectionButton-,Adapting%20the%20UI%3A%20Chart,-Feature. Howvere, it says at the top that "This topic is currently only applicable to SAP Fiori elements for OData V2." .

Is there any other way to achieve the above customizations on chart tool bar in ALP on odatav4 ?

Thanks in advance!

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.