sap-linuxlab / ansible.playbooks_for_sap Goto Github PK

In the doc page: here
It mentions "hdblcm", but this is an ASE deployment, so would not be done using this tool.

ASE uses numeric filename without prefix or suffix, and therefore cannot be detected once the file is removed.

Suggest additional weekly GH Action:

• Fuzzy search for SAP ASE 16 RDBMS Linux on x86_64 64bit
• Sort Descending order, use first item (index [0])
• Extract version substring (e.g. 16.0.04.06); parse to get SP 04 and Patch Level 06
• Search for Client file as ASEBC16004P_6 ; if Patch Level 00, then search ASEBC16004_0
• Identify replacement line using comment next to filename (e.g # SAP ASE 16.0.04.06 RDBMS Linux on x86_64 64bit)
• Identify replacement line using filename prefix ASEBC160
• Replace all occurances

Low priority.

@sean-freeman ENSA2 ASCS ERS Simple Mount scenario requires both ASCS and ERS file shares to be mounted on both cluster nodes, because of SAPStartSrv resource agent.

ASCS ERS Plays needs to be adjusted to account for this:
Current:

         sap_storage_setup_nwas_abap_ascs_instance_nr: "{{ host_specifications_dictionary[sap_vm_provision_host_specification_plan]
          [inventory_hostname_short].sap_storage_setup_nwas_abap_ascs_instance_nr | default('') }}"
        sap_storage_setup_nwas_abap_ers_instance_nr: "{{ host_specifications_dictionary[sap_vm_provision_host_specification_plan]
          [inventory_hostname_short].sap_storage_setup_nwas_abap_ers_instance_nr | default('') }}"

Which results into issue, where cluster nodes are not aware of Instance number of other one, creating incorrect folder on NFS and mounting it incorrectly. Example for ASCS node, which does not have sap_storage_setup_nwas_abap_ers_instance_nr defined.

/usr/sap/AE1/ASCS00
/usr/sap/AE1/ERS

Required cross server variable, not inside of host_specifications_dictionary:

        sap_storage_setup_nwas_abap_ascs_instance_nr: "{{ sap_system_nwas_abap_ascs_instance_nr }}"
        sap_storage_setup_nwas_abap_ers_instance_nr: "{{ sap_system_nwas_abap_ers_instance_nr }}"

When using ansible-terraform the terraform command called by community.sap_infrastructure.sap_vm_provision reported this:

...
Warning: Argument is deprecated
  
      with module.run_account_init_module.azurerm_subnet.vnet_subnet,
      on .terraform/modules/run_account_init_module/msazure_vm/account_init/network_vnet_new.tf line 18, in resource "azurerm_subnet" "vnet_subnet":
      18:   private_endpoint_network_policies_enabled     = true
  
    `private_endpoint_network_policies_enabled` will be removed in favour of the
    property `private_endpoint_network_policies` in version 4.0 of the AzureRM
    Provider
...

The section here: https://github.com/sap-linuxlab/ansible.playbooks_for_sap/blob/main/docs/GET_STARTED_WINDOWS.md#download
Has the following example:

mkdir -p run_playbooks && cd run_playbooks && curl -L https://github.com/sap-linuxlab/ansible.playbooks_for_sap/archive/refs/tags/1.0.0.zip | tar -xzv

But using 1.0.0.zip is not decompressed with tar.
Should be:

mkdir -p run_playbooks && cd run_playbooks && curl -L https://github.com/sap-linuxlab/ansible.playbooks_for_sap/archive/refs/tags/1.0.0.tar.gz | tar -xzv

Same for the MacOS section also.

all: update to Ansible Collection for linux system roles 1.82.0, contains dependency compatibility fixes for sap_install Ansible Collection

all: RHEL 9.x OS Images

All scenarios ansible_extravars.yml file require updating with RHEL 9.x OS Images regex strings for the Cloud Hyperscalers

all: linting fix broke AWS

ansible-lint identified Ansible Role reference should be amazon.aws.iam_role. However this was only happened in last release 7.2.0 a few days before ansible-lint bug fixes began prior to public release, and all ansible_requirements.yml files were version locked to 5.4.0 of amazon.aws Ansible Collection during development.

AP4S 1.0.1 must update this requirement; from brief regression testing the newest amazon.aws Ansible Collection is backwards-compatible and does not cause any issues.