Giter VIP home page Giter VIP logo

Comments (2)

satoren avatar satoren commented on July 19, 2024

thanks. It's bug

from kaguya.

Flamefire avatar Flamefire commented on July 19, 2024

Thanks. Could you probably add some tests that check the expected garbage collection is working? Cases I could think of:

  • Value, const Value, const Value&, Value&& -> Copy and gc after re-assignment
  • Pointer Value and Value& -> No gc and original instance (in C++) will be modified
  • Reassign temporary (e.g. from array), then pass into lua should also behave correctly (see above loop, due to a bug "Foo0" could be equal to "Foo4")

These would be a bit higher level tests (they test multiple parts of the library together) but these can detect regression bugs.
Probably also candiates for function calls (const, value and ref arguments should behave correctly)

from kaguya.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.