In Discord I've asked some time ago about the function to calculate differences from p

<div class="snippet-clipboard-content notranslate position-relative overflow-auto" data-snippet-clip

I changed the code and now I got this error: <div class="snippet-clipboard-content

[] a custom command `diff from previous column` about visidata HOT 5 CLOSED

maxim-uvarov commented on May 24, 2024

[] a custom command `diff from previous column`

from visidata.

Comments (5)

saulpw commented on May 24, 2024 1

Change c to self.

I just kind of tossed this code off, I thought maybe you knew how to code in Python a bit and could fix the issues and get it working for yourself. Adding this feature properly will probably require more polish (including documentation and a test) once it's working, and it's not a priority on our roadmap.

Kondo'ed for now.

from visidata.

saulpw commented on May 24, 2024

What is the error in one of the cells? You can see it with z Ctrl+E.

from visidata.

maxim-uvarov commented on May 24, 2024

Traceback (most recent call last):
File "/Users/user/miniconda3/lib/python3.11/site-packages/visidata/wrappers.py", line 105, in wrapply
return func(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^
File "/Users/user/miniconda3/lib/python3.11/site-packages/visidata/column.py", line 340, in getValue
return self.calcValue(row)
^^^^^^^^^^^^^^^^^^^
File "/Users/user/.visidatarc", line 27, in calcValue
prevval = self.prevCol.getTypedValue(row)
^^^^^^^^^^^^
AttributeError: 'DiffPreviousColumn' object has no attribute 'prevCol'

from visidata.

saulpw commented on May 24, 2024

Change prevCol to sourceCol (or vice versa).

from visidata.

maxim-uvarov commented on May 24, 2024

I changed the code and now I got this error:

Traceback (most recent call last):
File "/Users/user/miniconda3/lib/python3.11/site-packages/visidata/wrappers.py", line 105, in wrapply
return func(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^
File "/Users/user/miniconda3/lib/python3.11/site-packages/visidata/column.py", line 340, in getValue
return self.calcValue(row)
^^^^^^^^^^^^^^^^^^^
File "/Users/user/.visidatarc", line 28, in calcValue
curval = c.getTypedValue(row)
^
NameError: name 'c' is not defined

my current code is:

class DiffPreviousColumn(Column):
    def calcValue(self, row):
        prevval = self.sourceCol.getTypedValue(row)
        curval = c.getTypedValue(row)
        #return (curval-prevval)/prevval
        return 1

@Sheet.api
def diff_cols(sheet):
    for c in vd.numericCols(sheet.visibleCols):
        newcol = DiffPreviousColumn(c.name + 'diff', type=float, sourceCol=c)
        sheet.addColumn(newcol, index=sheet.columns.index(c))
        c.hide()

Sheet.addCommand('', 'diff-cols', 'diff_cols()')

from visidata.

Recommend Projects