Giter VIP home page Giter VIP logo

Comments (4)

dandv avatar dandv commented on September 16, 2024 2

@pantchox: please reopen the issue, as there is no solution. We also use a wrapper component on our site, and it would be nice to have the placeholder functionality built into this library.

The competing library react-tweet-embed has implemented this feature already but I can't get it to work.

from react-twitter-embed.

dandv avatar dandv commented on September 16, 2024

👍 to this request. When loading multiple tweets at once if you know their text (e.g. have it from an API), it helps to show the text while the tweets load.

from react-twitter-embed.

pantchox avatar pantchox commented on September 16, 2024

Hi,

I don't understand you comment as a solution can you please clarify with an example.
My solution was a "hack"

import {TwitterTweetEmbed} from 'react-twitter-embed';
...
const {error, loading} = this.state;
...
{loading && <YourLoaderHere />
{!error && <TwitterTweetEmbed
    tweetId={tweetId}
    options={{width: 'auto'}}
    onLoaded={(el) =>
        (el ? this.setState({loading: false}) : this.setState({loading: false, error: true}))} />}

I was checking if the element was valid on the DOM if not I assume error happened, I checked this with giving invalid tweetId or creating a tweet and then intentional delete it to check.

from react-twitter-embed.

saurabhnemade avatar saurabhnemade commented on September 16, 2024

@dandv @pantchox Yes. Its definitely a must have feature. We should definitely have it.
So to address that I am opening a PR shortly.

from react-twitter-embed.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.