sbfrf / getdatatestbed Goto Github PK

Line calls for string, code calls for date time, This should be updated before next release.

In getDataFRF at line 1030, local variable 'idx' is referenced before assignment. This is within the function getBathyTransectFromNC() and arises in the case where forceReturnAll is not True.

I can't use getnc without getting an error message in line 114 of getDataFRF.py. It says "local variable 'pName' is referenced before assigment"... I verified why is this happening and apparently although my server variable is equal to FRF (line 74), the IPaddress variable (line 81) does not start with either (134.164...) nor (10.0.0...). Since the 'if' condition in line 82 is not met, no pName is created. I'm running this on the Linux laptop and I've never had this issue before, was something recently changed in getDataFRF.py ? Extra info: I was calling getnc from getWaveData, so this is happening at RunwaorkflowFUNWAVE's beginning. I'm on development branch.

is it feasible to convert this package to utilize the xarray package which carries metadata, has plotting capability, etc?

are there improvements that could be made to return/parse data with more speed?

Problem: Downloading can be slow
downloading data takes a lot of time if not on local network, this download time should be minimized. Data on the server also change from time to time (as bugs in processing are found or new, better processing algorithms are employed) so this should be updated from time to time. users likely work with short datasets and particular types of data.

proposed solution: Create Local data cache
create a local cache where data can be locally stored (efficiently).

options or things to consider

• using a conf file to determine the location of this cache
• update data from server on occasion (set to default but user update-able)
• maybe use pickle instead of lots of netCDF files, this could save space and time

documentation lists xbound and ybound when code refers to xbounds, ybounds

Modify getdatatestbed.getintegratedbathy (or something close to that) to interface with existing bathy, as well as bathy/topo fusion product (& others like enoi, ml, etc.)