scalingo / buildpack-jvm-common Goto Github PK

View Code? Open in Web Editor NEW

This project forked from heroku/heroku-buildpack-jvm-common

0.0 0.0 0.0 12.36 MB

Common utils for JVM buildpacks

License: MIT License

Ruby 10.81% Shell 89.19%

buildpack jvm scalingo

buildpack-jvm-common's People

Watchers

buildpack-jvm-common's Issues

Sync with upstream from v123 to v135

https://github.com/heroku/heroku-buildpack-jvm-common/blob/main/CHANGELOG.md#v124

Remove reference to DYNO in jvmcommon script

These lines should be modified to match Scalingo

https://github.com/Scalingo/buildpack-jvm-common/blob/master/opt/jvmcommon.sh#L58-L63

run.. pattern is for Heroku one-off, it's one-off-* on Scalingo

And for the second it's not web. but web-

Sync with upstream v148

Sync with upstream from v117 to v121

https://github.com/heroku/heroku-buildpack-jvm-common/blob/main/CHANGELOG.md#v118

[OPSB-188] Update with upstream from v107 to v117

Sync with upstream v151

Sync with upstream from v97 to v107

Regression: Invalid DEFAULT_JDK_VERSION for (at least) JDK 11

When deploying a java 11 version it fails with:

 !     ERROR: Unsupported Java version: 11

My understanding of that is:

This is sent by validate_jdk_url called in bin/java:59
This need an url that comes from _get_jdk_with_default 11 called from bin/java:51

Since the user did not specify a JDK_URL_11 it will go to get_jdk_url (implemented in lib/jvm.sh) which will try to download the JDK from the heroky buildpack (but with scalingo-18) stack:

https://lang-jvm.s3.amazonaws.com/jdk/scalingo-18/openjdk11.0.6.tar.gz

Which is invalid.

upload-jvm-common.sh doesn't pass linting

Example:
https://github.com/Scalingo/buildpack-jvm-common/actions/runs/5456008217/jobs/9928298782

Blocks #37

Update to upstream v97

https://github.com/heroku/heroku-buildpack-jvm-common/releases/tag/v95

Sync with upstream from v121 to v122

https://github.com/heroku/heroku-buildpack-jvm-common/releases/tag/v122

SCALINGO_POSTGRESQL_URL is not correctly transformed into a JDBC URL

Sync with upstream from v122 to v123

https://github.com/heroku/heroku-buildpack-jvm-common/blob/main/CHANGELOG.md#v123

Sync with upstream from v139 to v144

Upgrade to last lts version

As JDK 17 is a LTS version, common usage is to upgrade to last minor version to get the well known long term support ;)

Actual behaviour

DEFAULT_JDK_17_VERSION="17.0.5"

Expected behaviour

DEFAULT_JDK_17_VERSION="17.0.7"

Sync with upstream v152

https://github.com/heroku/heroku-buildpack-jvm-common/blob/v152/CHANGELOG.md