scemino / engge Goto Github PK

Implement a debugger to understand the state of the game during runtime.
Watch variables, add/remove breakpoints, ...

Fox rexample, in the mansion library, the object "mansionEntryFire" should not be touchable:

Did you notice that in the game, the cell phone is indicating whether it has reception or not ? There is a little blinking green square if it has reception.

Describe the bug
When I select an actor, the camera stays in the actual room, not in the actor's room.

To Reproduce
Select an actor which is not in the current room and see.

Expected behavior
I expect the camera to be in the actor's room.

Desktop (please complete the following information):

• OS: macOS
• Version Mojave 10.14.4

Example:

Why \"Brothers\" if you're sisters?

should be

Why "Brothers" if you're sisters?

I have tested windows version 938, 958 & 957 and cannot get them to recognise,

Which version is compatible?

Segmentation fault using latest revision (1f4376d)

gdb --args ./engge
...
### Obj openingSign
### Obj opening1987
### Obj openingBulletHole
### Obj openingPop

Thread 1 "engge" received signal SIGSEGV, Segmentation fault.
0x00007ffff7e965f5 in sq_pushobject () from /home/g/Games/engge-latest/extlibs/squirrel/squirrel/libsquirrel.so.0
(gdb) bt
#0  0x00007ffff7e965f5 in sq_pushobject () from /home/g/Games/engge-latest/extlibs/squirrel/squirrel/libsquirrel.so.0
#1  0x00005555555fa204 in ng::_RoomPack::_defineRoom(SQVM*, long long, ng::Room*) ()
#2  0x00005555555fabe0 in ng::_RoomPack::defineRoom(SQVM*) ()
#3  0x00007ffff7ebf6f0 in SQVM::CallNative(SQNativeClosure*, long long, long long, SQObjectPtr&, int, bool&, bool&) ()
   from /home/g/Games/engge-latest/extlibs/squirrel/squirrel/libsquirrel.so.0
#4  0x00007ffff7ec06e2 in SQVM::Execute(SQObjectPtr&, long long, long long, SQObjectPtr&, unsigned long long, SQVM::ExecutionType) ()
   from /home/g/Games/engge-latest/extlibs/squirrel/squirrel/libsquirrel.so.0
#5  0x00007ffff7ec33de in SQVM::Call(SQObjectPtr&, long long, long long, SQObjectPtr&, unsigned long long) ()
   from /home/g/Games/engge-latest/extlibs/squirrel/squirrel/libsquirrel.so.0
#6  0x00007ffff7e99078 in sq_call () from /home/g/Games/engge-latest/extlibs/squirrel/squirrel/libsquirrel.so.0
#7  0x00007ffff7fbeba7 in sqstd_dofile () from /home/g/Games/engge-latest/extlibs/squirrel/sqstdlib/libsqstdlib.so.0
#8  0x00005555555e8a4d in ng::ScriptEngine::executeScript(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) ()
#9  0x0000555555568394 in main ()
(gdb) x/i $rip
=> 0x7ffff7e965f5 <sq_pushobject+37>:	addq   $0x1,0x8(%rdx)
(gdb) info registers 
rax            0x0                 0
rbx            0x7fffffffe1d0      140737488347600
rcx            0x7865745f          2019914847
rdx            0x0                 0
rsi            0x8000000           134217728
rdi            0x555556296640      93825006134848
rbp            0x7fffffffdec0      0x7fffffffdec0
rsp            0x7fffffffdd80      0x7fffffffdd80
r8             0x55555b46bc10      93825091943440
r9             0x6                 6
r10            0xa                 10
r11            0x0                 0
r12            0x5555563717f0      93825007032304
r13            0x5                 5
r14            0x0                 0
r15            0x70                112
rip            0x7ffff7e965f5      0x7ffff7e965f5 <sq_pushobject+37>
eflags         0x10206             [ PF IF RF ]
cs             0x33                51
ss             0x2b                43
ds             0x0                 0
es             0x0                 0
fs             0x0                 0
gs             0x0                 0

I'm following other game re-implementation like OpenNitemare3D. The developer produces releases often, basically every time a new feature is implemented and needs testing. I wonder if the same approach could be followed during the development of engge.

When we exit a room, objects created by code createObject, createTextObject should be deleted, local threads should be stopped.
I think triggers should be removed also.

As you can see here: https://blog.thimbleweedpark.com/savegame the actors, objects are identified by an id.

Describe the bug
When Sandy is telling a story about Ransome, in the trailer, she should say "Ransome the Jerk...", "...was the featured act at Stupendous Brothers Circus..." and "He was about ready to go on stage and meet his well-earned doom."

To Reproduce
Go to the diner, talk to Sandy, and select twice the first sentence.

Desktop (please complete the following information):

• OS: macOS
• Version: Mojave 10.14.6

When we double click somewhere or if we pressed the left mouse button for a certain time, the actor starts to run.

The instructions in the README won't work unless you move ThimbleweedPark.ggpack1, ThimbleweedPark.ggpack2 and test.nut into build.

When you click somewhere, the actor does not always found a path to go even if it should be possible.

Support for game controller, touch pads, etc.

• activeController
• actorAlpha
• actorAnimationNames
• actorAnimationFlags
• actorAt
• actorBlinkRate
• actorColor
• actorCostume
• actorDistanceTo
• actorDistanceWithin
• actorFace
• actorHidden
• actorHideLayer
• actorInTrigger
• actorInWalkbox
• actorLockFacing
• actorPlayAnimation
• actorPosX, actorPosY
• actorRenderOffset
• actorRoom
• actorShowLayer
• actorSlotSelectable
• actorStand
• actorStopWalking
• actorSound
• actorTalkColors
• actorTalking
• actorTalkOffset
• actorTurnTo
• actorUsePos
• actorUseWalkboxes
• actorVolume
• actorWalking
• actorWalkForward
• actorWalkSpeed
• actorWalkTo
• addCallback
• adhocalytics
• addSelectableActor
• addTrigger
• arrayShuffle
• assetExists
• breakwhilecamera
• cameraAt
• cameraBounds
• cameraFollow
• cameraInRoom
• cameraPanTo
• cameraPos
• chr
• clampInWalkbox
• createActor
• createLight, lightBrightness, lightConeDirection, lightConeAngle, lightConeFalloff, lightCutOffRadius, lightHalfRadius, lightTurnOn, lightZRange
• createObject
• createTextObject
• cursorPosX
• cursorPosY
• cutscene
• cutsceneOverride
• definePseudoRoom
• defineRoom
• defineSound
• deleteObject
• distance
• enableTrigger
• enterRoomFromDoor
• exCommand EX_ALLOW_SAVEGAMES
  // exCommand EX_POP_CHARACTER_SELECTION not used
• exCommand EX_AUTOSAVE
• exCommand EX_AUTOSAVE_STATE
• exCommand EX_BUTTON_HOVER_SOUND
• exCommand EX_CAMERA_TRACKING
• exCommand EX_FORCE_TALKIE_TEXT
• exCommand EX_IDLE_TIME
• exCommand EX_OPTIONS_MUSIC
• exCommand EX_RESTART
• exCommand EX_SHOW_OPTIONS
• fadeOutSound
• findObjectAt
• findRoom
• findScreenPosition
• flashSelectableActor
• frameCounter
• gameTime
• getPrivatePref, setPrivatePref
• getUserPref, setUserPref
• in_array
• incutscene
• indialog
• inputController
• inputHUD
• inputOff
• inputOn
• inputSilentOff
• inputState
• inputVerbs
• is_function
• is_object
• isActorOnScreen
• isActorSelectable
• isInputOn
• isInventoryOnScreen
• isObject
• isSoundPlaying
• jiggleInventory
• jiggleObject
• loadArray
• loadSound
• logEvent
• logInfo
• logWarning
• loopMusic
• loopObjectState
• loopObjectSound
• loopSound
• markAchievement
• markProgress
• markStat
• masterActorArray
• masterRoomArray
• masterSoundVolume
• microTime
• moveCursorTo
• mumbleLine
• musicMixVolume
• objectAlpha
• objectAlphaTo
• objectAt
• objectBumperCycle
• objectCenter
• objectColor
• objectDependentOn
• objectFPS
• objectHidden
• objectHotspot
• objectIcon
• objectLit
• objectMoveTo
• objectOffset
• objectOffsetTo
• objectOwner
• objectParallaxLayer
• objectParent
• objectPosX
• objectPosY
• objectRenderOffset
• objectRoom
• objectRotate
• objectRotateTo
• objectScale
• objectScaleTo
• objectScreenSpace
• objectShader
• objectSort
• objectState
• objectTouchable
• objectUsePos
• objectUsePosX
• objectUsePosY
• objectValidUsePos
• objectValidVerb
• ord
• pickupObject
• pickupReplacementObject
• playMusic
• playObjectSound
• playObjectState
• playSound
• playSoundVolume
• popInventory
• pushSentence
• random
• randomfrom
• randomOdds
• randomodds
• randomseed
• refreshUI
• removeCallback
• removeInventory
• removeTrigger
• roomActors
• roomEffect
• roomFade
• roomLayer
• roomOverlayColor
• roomRotateTo
• roomSize
• sayLine
• sayLineAt
• scale
• screenSize
• selectActor
• setAmbientLight
• setDebugger
• setDefaultObject
• setVerb
• shakeObject
• stopObjectMotors
• soundMixVolume
• soundVolume
• startDialog
• startglobalthread
• stopAllSounds
• stopObjectMotors
• stopSentence
• stopSound
• stopTalking
• strcount
• strcrc
• strfind
• strfirst
• strlast
• strlines
• strreplace
• strsplit
• talkieMixVolume
• translate
• threadid
• threadpauseable
• triggerActors
• verbUIColors
• walkboxHidden

When the camera is following an actor, the camera should move only when the actor is reaching the border of the room.

As there is already a parser for prefs.json, we can use it to parse other json files and remove nlohman/json dependency.

save:

• callbacks
• currentroom
• dialog
• easy_mode
• gameGUID
• gameScene
• gameTime
• globals
• inputState
• inventory
• objects
• rooms
• savebuild
• savetime
• selectedActor
• version
• capture screen
• call preSave callback

load:

• callbacks
• currentroom
• dialog
• easy_mode
• gameGUID
• gameScene
• gameTime
• globals
• inputState
• inventory
• objects
• rooms
• savebuild
• savetime
• selectedActor
• version
• call preLoad callback
• call postLoad callback

UI:

• save
• load
• translations

bugs:

• actor facing is locked after loading game
• actor HUD is wrong
• script fails in enteredRoom after loading a game

todo:

• save actor _lockFacing
• save actor _volume
• save actor _useDir
• save actor _usePos
• save actor _renderOffset
• save actor _color
• save actor _costumeSheet
• save object _state
• save object _touchable
• save object _offset
• add SAVEBUILD variable
• forceTalkieText
• load actor _animations array
• fix Linux linking error: CMakeFiles/engge.dir/Engine/Engine.cpp.o:(.data.rel.ro._ZTI13SQCollectable[_ZTI13SQCollectable]+0x10): undefined reference to `typeinfo for SQRefCounted'

An object can have a parent defined in a wimpy file or by code with objectParent function.

These dialog instructions are not implemented:

• allowObjects
• dialog
• limit
• override
• parrot
• waitfor
• waitwhile

As you can see in this screenshot, some layers are still wrong:

Describe the bug
When the actor looks his notes, we can see colors codes #00A000#✓#000000# instead of a green check mark.

To Reproduce
Boris at the beginning of the game, if he looks his notes we can see the color codes.

Expected behavior
We should see the real color, not the codes.

Screenshots

There are a lot of callbacks not called by the engine yet:

• onActorSelected
• onTalkieID
• onPickup
• onVerbClick
• onObjectClick
• onChoiceClick
• actorEnter
• actorExit
• actorPreWalk
• actorPostWalk
• objectGive
• objectPreWalk
• objectPostWalk
• onLanguageChange
• enteredRoom
• exitedRoom
• preLoad
• postLoad
• preSave
• sayingLine
• preWalking
• postWalking
• pressedKey
• actorArrived

It would be nice to setup some CI tests to detect crossplaform issues when compiling and running engge. It is worth to mention that travis is free for open-source repositories and has support for Linux and OSX.

To have a better diagnostic when the program has an unexpected behaviour.

Actors and objects are visible even if we hide them by code.

When we execute an action (walk to door for example), if we click elsewhere, the previous sentence should be stopped. Today the actor walk to elsewhere but we still change room 😢

Describe the bug
Object can have a function called 'enter' which should be called each time the player enters the room.

To Reproduce
Enter RansomeTrailer room.

Expected behavior
You can see the cheese even if the refrigerator is closed.
This code is not executed: objectDependentOn(this, ransomeTrailerFridge, OPEN)

Screenshots

Desktop (please complete the following information):

• OS: macOS
• Version: Mojave 10.14.4

• draw correctly background and items
• allow to scroll items
• jiggle animation
• pop animation

After compiling engge in Linux, a few Makefiles inside extlibs/* are listed as modified. It would be nice to remove them (since they are autogenerated) and add them into .gitignore.

Describe the bug
When entering a room, the actor has a wrong direction.

To Reproduce
Enter a room

Expected behavior
When the door is at the top, the actor should be facing us.

Screenshots
In this example, the actor enter the bathroomQuickiePalDoor:

Desktop (please complete the following information):

• OS: macOS
• Version: Mojave 10.14.4

Additional context
none

• Options Dialog
• Quit game
• Start screen

Describe the bug
Hide words in parenthesis in dialogs.

To Reproduce
Type this test.nut:

include("Defines.nut")
include("Boot.nut")

inputOn()
inputVerbs(ON)
selectActor(ray)
enterRoomFromDoor(highwayBridgeDoor)
sayLine("@30344")

Expected behavior
Actor should say "It's already open.", not "(neutral)It's already open."

Desktop (please complete the following information):

• OS: macOS
• Version Mojave 10.14.4

When we select Give verb, the suffix "to" should be displayed then if the cursor is on an actor, its name should be appended.

Room effects

• Ghost
• Black & White

I know this implementation of the experimental game engine is still a work in progress, but I'm wondering if it does make sense to try to re-use the SCUMMVM implementation of common point-and-click game elements (actor, dialogs, etc) to accelerate the development progress.

Describe the bug
The parallax is wrong in some rooms.

To Reproduce
In the script type:

include("Defines.nut")
include("Boot.nut")

inputOn()
inputVerbs(ON)
selectActor(ray)
enterRoomFromDoor(bathroomQuickiePalDoor)

Expected behavior
The foreground should be displayed correctly.

Screenshots

Desktop (please complete the following information):

• OS: macOS
• Version Mojave 10.14.4

Additional context
none

When actor is picking an object, a reach animation should be played before.

Describe the bug
Some layers are not drawn at the correct place.

To Reproduce
Select Ransome and use hair gel.
His face is behind his hair.

Expected behavior
The face should be drawn at the correct place.

Screenshots

Desktop (please complete the following information):

• OS: macOS
• Version: 10.14.6