Giter VIP home page Giter VIP logo

Comments (4)

pradeepnschrodinger avatar pradeepnschrodinger commented on July 23, 2024

Hey, thanks for the detailed analysis.
As you mentioned, I suspect we just need a broader falsey check on rowIndex and force the row instance to not be rendered in this case.

I'll be happy to consider a PR for this. If not, I can also tackle this myself in a few days.

Meanwhile, could you also mention the exact version of FDT that's used here?

from fixed-data-table-2.

pauliusg avatar pauliusg commented on July 23, 2024

Hi @pradeepnschrodinger, thank you for quick response. Unfortunately, I don't have more time to make PR. I am using latest FDT version 1.2.9.

from fixed-data-table-2.

tkirda avatar tkirda commented on July 23, 2024

Hi @pradeepnschrodinger, you were correct. There is a flaw in logic when assigning rowIndex. In case when _staticRowArray[i] already assigned to null, we should keep it as undefined so it can skip rendering that row.

from fixed-data-table-2.

pradeepnschrodinger avatar pradeepnschrodinger commented on July 23, 2024

This should now be resolved with v1.2.10 through #645.

Thanks @pauliusg and @tkirda!

from fixed-data-table-2.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.