Comments (11)
Resizing in mobile view or touch devices works in v1.2.x
In our opinion this is false. This is actually the exact reason why we are trying a migration towards v2, hoping to fix the behavior on mobile.
from fixed-data-table-2.
Hello! Thanks a lot for this fix! We confirm that we have tested and that the resize and reorder works now on our application (on mobile) with this your new prerelease version. We are looking forward for a release version.
from fixed-data-table-2.
Thanks a lot @pradeepnschrodinger
from fixed-data-table-2.
Thanks for filing.
This is a regression; Resizing in mobile view or touch devices works in v1.2.x but not in v2.0.x 😞
from fixed-data-table-2.
Ok. Thank you! But do you have any ideea why if
- I clone your project (on the master branch),
- I add on the ResizeExample.js for each
ResizeCell
touchEnabled={true}
- I run your examples (using
yarn site-dev-server
),
The resize is working ok on mobile?
https://www.youtube.com/watch?v=ssChIDgGRtE
(Also the reorder column example is working ok on the locally checked out project with touchEnabled={true}
)
from fixed-data-table-2.
Interesting.
We're no longer passing down the touchEnabled
prop to the cell renderers within FDT.
But the resizer plugin <ResizeCell />
still expects it, making it not work for touch devices.
I add on the ResizeExample.js for each ResizeCell touchEnabled={true}
So a quick workaround is to explicity pass down the prop to the cell renderer from the user's side, like what you did.
The actual fix likely involves FDT passing it down instead, like what I see for v1.2.x.
But do you have any idea why if the resize is working ok on mobile?
I unfortunately can't figure out why there's a difference in behavior with the local webpack server vs the one in hosted in codesandbox.
Even the v1.2.x version doesn't seem to work in codesandbox.
cc: @AmanGupta2708 , @karry08 , @abhisheksingh2410
On a side note, I'm also seeing an issue where trying to resize via touch results in the table being scrolled in the background.
It would be nice to check if both of these issues are stemming out from the same underlying problem.
from fixed-data-table-2.
@daniela-mateescu, @cristian-spiescu , I put a potential fix for this at #706, with a couple of other touch related issues I saw along the way.
I did a quick round of smoke testing by forking your example (see https://codesandbox.io/s/fixed-data-table-2-touch-resizing-s22nn7) and it seems to work well.
The fix can be grabbed by specifying "fixed-data-table-2": "https://github.com/schrodinger/fixed-data-table-2#fix-touch-handlers-prerelease",
in your package.json file.
It would be awesome if you guys can test it with your project, and let us know if it works.
from fixed-data-table-2.
Thanks a lot! We'll give it a shot Monday and get back to you. Have a nice weekend.
from fixed-data-table-2.
@pradeepnschrodinger do you have an idea when is a next version available, containg this fix? Maybe 2.0.3?
from fixed-data-table-2.
Thanks for the testing out the fix and letting us know it works.
The next release containing this fix is likely v2.0.3
, and should be released within a day or two.
I'll comment here and on the PR once it's done.
from fixed-data-table-2.
Fix released with v2.0.3.
cc: @daniela-mateescu , @cristian-spiescu
from fixed-data-table-2.
Related Issues (20)
- Why endRowIndex and firstRowIndex are not passed to onVerticalScroll and onHorizontalScroll? HOT 2
- Does it provide infinite scroll? HOT 1
- Resizable rows? HOT 5
- Need drop and play example HOT 3
- Sometimes when scrolling through table rows, I receive warning: Failed prop type: The prop `index` is marked as required in `FixedDataTableRowImpl`, but its value is `null`. HOT 4
- Check the column/cell visibility HOT 9
- Z-index 1 set on column header causes header to overlap other elements HOT 6
- Vertical scroll bar when we have many columns HOT 2
- Cannot read properties of null (reading 'onWheel') HOT 6
- Cannot read properties of null (reading 'setRoot') HOT 4
- React 18 question HOT 4
- "Global is not defined" in React Vite app HOT 2
- Error when refreshing data in table with "smaller" data HOT 5
- Is there a way to implement multi-level headers in Fixed Data Table 2 HOT 3
- When using variable row heights, setting `scrollTop` doesn't work well. Fix proposed HOT 4
- Resize line not shown when "maxHeight" is set. HOT 2
- Resize vertical bar public in header_ FixedDataTableColumnResizerLine_ Main positioning is not accurate HOT 4
- "site-dev-server" script doesn't work after upgrading to npm 9.8.0 HOT 4
- Scroll to an exact position when clicking the scrollbar track doesn't work in case of variable row heights and isVerticalScrollExact = true HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fixed-data-table-2.