Nested index.php about s2i-php-container HOT 10 CLOSED

@bparees @csrwng @mfojtik @mnagy @soltysh fyi

from s2i-php-container.

is this any different than v2 behavior? shouldn't index.php end up served as "host.com/public/index.php" in your scenario?

from s2i-php-container.

@bparees well as we spoke, in v2 you are able to detect the document root, where the index.php is located http://docs.openshift.org/origin-m4/oo_cartridge_guide.html#document-root
Unfortunately this cant be done with our approach since we dont know how the application looks like upon the php-55-***7 image build. In that case we have to come with a solution that will supply user with possibility to change the DocumentRoot.
A simple fix would be to add 151s%AllowOverride None%AllowOverride All% to the end of httdconf.sed which will take additional instructions for apache from .htaccess file which user will have to supply.

from s2i-php-container.

basically here are the changes I had to make: https://github.com/openshift/sti-php/compare/master...jhadvig:laravel5?expand=1

from s2i-php-container.

@jhadvig @bparees why we can't set AllowOverride All by default? Is there a security concern here?

from s2i-php-container.

@jhadvig in your diff, you also installing 'git' which I think is now included in base

from s2i-php-container.

@mfojtik it is, we can leave that out of discussion. Regarding setting the AllowOverride All, if you look closer to that change it only applies to the line 151 in the httpd.conf, and which allows reading the .htaccess file in the opt/openshift/src directory, which for now I think would be the best solution. In that case the index.php could be nested inside the repo and user will just have to supply the .htaccess to the root of the repo so Apache can pick up the information from it.

from s2i-php-container.

@jhadvig sounds ok to me.

from s2i-php-container.

@bparees ok will send PR + update docs accordingly

from s2i-php-container.

PR -> #19

from s2i-php-container.