Giter VIP home page Giter VIP logo

Comments (2)

omron93 avatar omron93 commented on June 24, 2024

Thanks for reporting this issue. There is inconsistency in what is in the code and what is in the readme.

README describes ./httpd-cfg , ./httpd-pre-init , ./httpd-ssl folders. But in code ./httpd-cfg , ./php-pre-start , ./httpd-ssl , ./php-post-assemble folders are used.
@hhorak You introduced the change. Which naming we want use?

@dirkrydvan So hotfix for this issue is to use php-pre-start folder instead of httpd-pre-init. But be prepared that a resolution of this issue can change naming.

from s2i-php-container.

hhorak avatar hhorak commented on June 24, 2024

@omron93 Yeah, naming is never easy :) my thinking behind this was to use the same entrypoint names where I'd expect the same content/use case for httpd and php container image -- that's the httpd-ssl a httpd-cfg case. However, my expectation for content/use case for post-assemble and pre-start entrypoints would be different in case of php, than in case of httpd container image; therefore different name. Anyway, my intention was what is in the code, the README is wrong in this case.

from s2i-php-container.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.