Elephant Localization
scorelab / eloc Goto Github PK
View Code? Open in Web Editor NEWElephant Localization
License: Apache License 2.0
Elephant Localization
License: Apache License 2.0
One issue I found was that there seemed to be no module named "mpld3".
I downloaded all the content from eloc. Then in the server.py, it said that it was missing a module called "mpld3". I downloaded mpld3 from github, and it sensed the file, but still said "No module named mpld3". I looked for a pip install, and installed it, but it still said "No module named mpld3".
I think that GCI should put where to get these modules from, and the Readme.md didn't have any proper information. It was also missing some important files like config files.
This repos should follow Gitflow workflow and follow are the items you have to check.
- [ ] There is a `master` branch and a `develop` branch.
- [ ] `master` branch is locked for direct commits and,
- [ ] Require pull request reviews before merging is active
- [ ] Require status checks to pass before merging is active
- [ ] Require branches to be up to date before merging
- [ ] Appropriate Status checks are required
- [ ] Enforce all configured restrictions for administrators is active
- [ ] Restrict only maintainers group can push to the master branch
- [ ] `develop` branch is locked for direct commits and,
- [ ] Require pull request reviews before merging
- [ ] Dismiss stale pull request approvals when new commits are pushed is active
- [ ] Require pull request reviews before merging is active
- [ ] Require status checks to pass before merging is active
- [ ] Require branches to be up to date before merging
- [ ] Appropriate Status checks are required
- [ ] Enforce all configured restrictions for administrators is active
- [ ] Restrict only maintainers group can push to the master branch
The local server of eloc does not startup due to matplotlib.pyplot being imported as mpld3. Initially, I thought I could come overcome this by looking around but then I noticed that mpld3 is redundant as it was not being used anywhere inside plotSpec.py.
So I removed mpld3 and rebuilt. This time, a local instance of eloc spun up smoothly. I recreated the exact error and took a screenshot for more clarity.
Find this task on my website: http://itsrohan.com/gci/gcitasks
Add a list of dependencies needed to run the program. This will allow people to run the program as it is intended to be run: not with errors about missing modules.
Some of the Important Files that must be included in an Open Source Project are missing
Contributor Documentation
Issue Template
Pull Request Template
Proper Readme File
Build Testings Used
Config Files
Updated License
Updated Documentation
=> Dismiss stale pull request approvals when new commits are pushed is active
=>Require status checks to pass before merging is active
=>Readme files should be more descriptive and instructions should be clear
=>Sometimes the app crashes due to mpld3
=>many syntax errors in js,css files
A README file must contain information about other files in a directory or archive of computer software.
The program doesn't support Python 3. Since it's been a long time since Python 3's launch 98% people has switched to Python 3. Also all the New comers will have learnt Python 3. So it's best that the program is written in Python 3.
This project's README.md
is not explained well enough about the project itself. A few pros about the project, explaining what the project actually does and stating methods of using it would be really helpful.
It can rather start as....
"This project is used to locate the geographical locations of elephants. ELOC can be setup by doing the following steps.... etc.
Making it more descriptive would surely help people understand it much better, including newbies.
There should be a proper guide on how to set up a development environment, or how the users going to use it.
How the users are supposed to know how the program works.
Possible Fix: Add Proper Guide
There must be a requirements.txt
file on each folder which contains libraries other than the Standard Libraries.
eloc_node
, eloc_server
folders must have requirements.txt
file on each folder.
Possible Fix: Add
requirements.txt
file on above-mentioned folders
As the life of Python 2.7 is about to end, it would be better to use Python 3 instead.
Possible Fix :
eloc_node/readData.py
file has inconsistent use of tabs and spaces in indentation.
Possible Fix: Use 4 soft spaces instead of tabs
The new contributors will get the idea of the project after reading the readme file. But here the only thing that consist in the readme file is "eloc". So I suggest to add details to the README file
There should be a CONTRIBUTORS.md page in the repository to guide the developers.So please add it.
There should be Travis CI Integration In Project Which runs tests every time Anyone commits to Repository.
There is no Travis CI Integration Available
All the commands/Documentation that are required To integrate Travis CI are present Here
Update the README.md accordingly.
THIS IS A NOT A REAL ISSUE BUT A PLACEHOLDER.
All the practising PRs for Google Code-In 2017 should refer this issue. PRs referring this issue will be closed without merging. Do not refer this issue if you are NOT submitting a practice PR and need your work merged.
The project is missing following files needed for a open source development workflow:
Contributor Documentation
Issue Template
Pull Request Template
The "About" link on the initial pointing to pages/about.html and "Home" link pointing to pages/dashBoard.html are not loading the respective pages and show endless loading animation
There are several directories where readme update is neessary like eloc_node,eloc_server only python script is provided respective README.md is blank.
There is very less info in README
and no proper ISSUE SUBMITTING TEMPLATE
is there.
There should be a proper guide on how to set up a development environment, or how the users going to use it.
There must be a requirements.txt file on each folder which contains libraries other than the Standard Libraries.
The program doesn't support Python 3. Since it's been a long time since Python 3's launch 98% people has switched to Python 3.
Eloc_data should have more descriptive inside catalogs names, because now we have weird naming, and don't know how this data is relevant to project.
I wasn't able to install it because there's lack of information on the README.md in such a way that you don't know what this thing does or how to install it. It needs improvement :D
the README.md file should contain images of the project and installation process, images play a very important roll in an Open-Source project not only because it shows you some ui components for example, and you can get feedback to improve your project UI without needing to install, or sometimes images help a lot when someone has problems installing for example terminal output screenshots.
Hope this helped :D
README.md
file should explain how to set up the project locally, on the user's own environment. We should describe how the installation process will look on Linux
(Ubuntu etc.), Mac
and Windows
.
This process is for sure easy and fast, but some people coming from another environment or those who are not very familiar with git itself wouldn't be able to set up eloc
.
This Issue is connected with #5 as this file has no description AT ALL ๐
The local server of eloc crashes due to mpld3.
the README file should be more descriptive for the user in order to follow instructions
And important files such as ,contributor documents and config files are missing.
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.