scottjr632 / react-rellax-wrapper Goto Github PK

Hi,

Thanks for making the rellax wrapper!

I was wondering how you reference the wrapper when setting relativeToWrapper={true}?

Accessing through id, className or ref does not work.

Hello.
I am trying to have different speeds for different viewports. For example, if I want a parallax on desktop, but not on something smaller, I think it would go like this (I am using Gatsby).

`

    <RellaxWrapper xs={0} mobile={0} tablet={0} speed={-7}>
      <Img
        className={classes.moutain}
        fluid={data.moutain.childImageSharp.fluid}
      />
    </RellaxWrapper>

    <RellaxWrapper xs={0} mobile={0} tablet={0} speed={0}>
      <Img
        className={classes.front}
        fluid={data.front.childImageSharp.fluid}
      />
    </RellaxWrapper>`

But it does not seem to work at all, I have a fixed image from +/- 570 px to 1200px. But under that 570px the parallax effect appears again. Do you know why?
Thanks!

Hello and thanks for this life saving wrapper for Rellax.

Can you please add speed and center to interface so we can get rid of ts-ignore comments:

You can see here that its not in the interface, and if you add it manually the TS error is gone:

Thanks in advance!

What needs to change?

React (and possibly React DOM) should be included as a peer dependency, rather than a direct dependency.

Why should it change?

The problem is that if a consumer of react-rellax-wrapper is using a different version of React (such as the latest v17), React will actually be installed twice.

When this happens, hook calls may become broken. See: https://reactjs.org/warnings/invalid-hook-call-warning.html#duplicate-react

Useful links

See: https://nodejs.org/en/blog/npm/peer-dependencies/

Also, great library by the way! Thanks

The animation on mobile is unusable, it's unfortunate since this library has more functionality than the others. I tried some images with this library and compared them to the other parallax libraries, unfortunately, the others outperformed this library.