scottwernervt / ember-notifier Goto Github PK

Code coverage is poor and needs to be improved.

• Use test hooks for setting up common properties and templates (tests/integration/components/ember-notifier-notification/component-test.js)
• Add mouseEnter and mouseLeave tests for ember-notifier-notification component.
• Speed up tests by disabling animations

Bug

Closing a notification can cause another notification to be removed.

Reproduce

1. Launch a bunch of notifications at ember-twiddle
2. Start clicking the close button on a bunch of them.

Solution

Switch to removing notification by an identifier instead of using the notification object.

Trying to use the add-on, but the icons (and close btn) are not rendering correctly. We have font-awesome present. Here is what it looks like:

Inspecting the html for the icon, it shows:

<span>
    <i class="[object Object]"></i>
</span>

But looking at ember inspector and using the {{debugger}} helper - both seem to indicate the icon property (that determines the class here) is set to a string as expected ("fas fa-exclamation"). So not sure why the class is not set correctly. Have you run into any issues like this previously?

Perform upgrade when Template processing order issue with Ember CLI v3.2 is fixed.

Ember Observer requirements:

Is the README filled out? - Does the README have content that is not the default generated content?

Bug

Error: Assertion Failed: An action named 'setOption' was not found in <dummy@controller:application::ember471> when launching a custom notification component and using a css framework overrides like Bootstrap.

Rework default values for global option config in notifier service.

• Drop 'ember-get-config' dependency.
• Define service defaults as properties and merge/assign config object.

• Swipe right to remove notification #11
• Add integration/unit test mocking swipe right with triggerEvent
• Document feature
• Test manually
  • Firefox Mobile Android
  • Chrome Mobile Android
  • Microsoft Edge Mobile Android
  • Safari iOS

See https://blog.travis-ci.com/2018-11-19-required-linux-infrastructure-migration