scout24 / afp-core Goto Github PK

When throwing an HTTP 500 error, afp is silent about the reason the error is thrown. This makes it hard to debug problems when needed.

See (internal) PRO-17434

Please find a way to make those errors more verbose, so that clients are able to display a "human readable" error message.

we are using afp-core as STS for our company to login into the AWS Console. The setup was built with puppet and the afp was deployed automatically which everything is fine.

From time to time we observed that someone got the error message "No accounts found. You have no attached accounts." even he entered the corrected password and the username was already configured properly.

The error message is not easy to reproducible, for example i tried 2 hours today and it doesn't come, but yesterday twice.

We setup afp-core + apache + sssd as the description.

an investigation in the source code i found that the function getAccountList return Errormessage but didn't understand why the login is working, it still return the Error Message

afp-web/js/service/userMessageService.js

` function getAccountList(callback) {
var error = {};

  $http.get(appVars.afpApiEndpoint + "account")
    .success(function (response, status, headers) {
      callback(null, getLoginstatus(headers), createAccountArray(response));
    })
    .error(function (response, status, headers) {
      error.message = getErrorMessage(status, response);
      callback(error, getLoginstatus(headers));
    });
}

return {
  getLoginstatus: getLoginstatus,
  getErrorMessage: getErrorMessage,
  getAccountList: getAccountList
};`

afp-web/js/controller/AccountlistController.js

` userMessageService.getAccountList(function (err, loginstatus, accounts) {
$scope.loginstatus = loginstatus;

  if (err) {
    $scope.error = err.message;
    $scope.showError = true;

    return;
  }

  $scope.favoriteCount = favouritesService.readFavorites(accounts);
  $scope.accounts = accounts;
  $scope.showError = false;
  focusQueryInput();
});`

afp-web/templates/resultlist.html

`<div class="align-center" ng-show="accounts.length == 0">
     <div class="alert alert-info" role="alert" >
        <b>No accounts found.</b>
             You have no attached accounts.
    </div>
 </div>`

With regard to the issue #6 I saw the sssd_provider in the examples. Is there any reason why the sssd_provider is only available as example? The sssd_provider fixed the issue #6 for our site.

I'd be grateful if you could add the sssd_provider as official provider.

Some classes (e.g. provider_by_ip.py) contain IS24 specific code.

That makes it very difficult to see the generic parts of AFP in contrast to the IS24 specific parts.

For other users it would be much easier to adapt AFP to their use cases if all IS24 specific implementations would be clearly marked as such.

I am not sure if the log-level can be setup via the configuration. If not, this has to be added, otherwise we can close this issue.

If ProviderByIP.check_host_allowed denies a client access due to its domain, this is translated into status code 500 (internal server error) instead of 403 (forbidden).