Giter VIP home page Giter VIP logo

wrs's People

Contributors

ashishnirmohi avatar balbirsingh avatar brahminder avatar mathurricha avatar maverickvarun avatar mukeysh avatar nitishchopraa avatar saurabhb avatar scratch avatar

Stargazers

 avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Forkers

brahminder

wrs's Issues

Reusability

Reuse css rules, classes wherever possible, like a generic class name 'blue' could be use for making blue links..

Closing Tags

Some Pages have unclosed tags. Please have a look at element with id "page" in page.html for reference.

Invalid location of tags

There are lot of tags with invalid locations in project.
For instance, see HTML pasted below. Why 'li' is used under 'div' element?

<div class="partners1">
          <li><a href="#"><img src="images/content-partner-logo-bbc.png"></a></li>
        <li><a href="#"><img src="images/content-partner-logo-npr.png"></a></li>
        </div>
      <div class="partners2">
        <li><a href="#"><img src="images/partner-abc-logo.png"></a></li>
        <li><a href="#"><img src="images/partner-cbc-logo.png"></a></li>
        <li><a href="#"><img src="images/partner-pri-logo.png"></a></li>
      </div>

Script element

Put script element after all other elements in body...

960 Markup

Please use standard width i.e. 960px for 1024 resolution (Fixed layout) instead of 1024.

css styles like max-width : 1024; and margin : 0 auto; are redundant.

Give background to body element and keep everything in one element i.e. #page here, which will be center aligned and have fixed layout rules.. Or if elements are of full width like header in this case, use a single class like 'container' which will be have styles like center aligned, 960px width etc..

Css Issues

  1. ''text-transform : Uppercase; '
  2. Background images and sprites
  3. text-overflow : ellipses for text overflow
  4. Unequal padding in Header tabs
  5. Hover on time in "Later " section shows underline on text, but can't be clicked..
  6. No need of text-indent in slider's pagination.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.