Comments (12)
too late
from scratchaddons.
I believe it's too late to implement this. It's not a big deal, either. Closing
from scratchaddons.
I believe this one is worth reopening. Once we implement #390, addons that work on the editor/project page would also need to work on turbowarp's editor/project page. If we simply said for the match URL to be project
, then we could have the match URL patterns for both turbowarp and scratch to link to htpps://scratch.mit.edu/projects/* and https://turbowarp.org/* (excluding the https://turbowarp.org/privacy.html page). And, if we end up supporting addons on another site, then it would be useful there too. This would also help with #646. And I think it's just easier if all the user needed to add in their addon, was just search
or user
from scratchaddons.
from scratchaddons.
I believe this one is worth reopening. Once we implement #390, addons that work on the editor/project page would also need to work on turbowarp's editor/project page. If we simply said for the match URL to be
project
, then we could have the match URL patterns for both turbowarp and scratch to link to htpps://scratch.mit.edu/projects/* and https://turbowarp.org/* (excluding the https://turbowarp.org/privacy.html page). And, if we end up supporting addons on another site, then it would be useful there too. This would also help with #646. And I think it's just easier if all the user needed to add in their addon, was justsearch
oruser
I honestly doubt userscript made for the Scratch editor could work "as-is" on TurboWarp, so it wouldn't make sense to merge both origins into one permission - an addon might only work on the Scratch editor
from scratchaddons.
from scratchaddons.
I honestly doubt userscript made for the Scratch editor could work "as-is" on TurboWarp, so it wouldn't make sense to merge both origins into one permission - an addon might only work on the Scratch editor
I'm sure that most do, and some (like project-notes-tabs) could easily be fixed by adding an if statement to not run at all.
from scratchaddons.
I honestly doubt userscript made for the Scratch editor could work "as-is" on TurboWarp, so it wouldn't make sense to merge both origins into one permission - an addon might only work on the Scratch editor
How bout now hehe. But even so, this should 100% be implemented... for future mods.
from scratchaddons.
wl has recondered. pr soon.
from scratchaddons.
One reason is that there are addons that don't set their match to the forums but are closely related to them (discuss button)
In this case, the addon can manually add the tag.
There are also addons that have forum matches to implement forum-specific functionality but aren't otherwise forum addons (infinite scrolling).
I argue that infinite scrolling and other addons like that should have the forums tag, even if their effect on it is very little. Alternatively, we can check if the userscripts/userstyles have the settingMatch
property. Then it will ignore its matches.
Another reason is that if we add subcategories, editor addons will need to set them explicitly anyway. Why would website addons work differently?
The editor is not different pages, whereas the forums and the profiles are.
from scratchaddons.
One reason is that there are addons that don't set their match to the forums but are closely related to them (discuss button)
In this case, the addon can manually add the tag.
There are also addons that have forum matches to implement forum-specific functionality but aren't otherwise forum addons (infinite scrolling).
I argue that infinite scrolling and other addons like that should have the forums tag, even if their effect on it is very little. Alternatively, we can check if the userscripts/userstyles have the
settingMatch
property. Then it will ignore its matches.
This would cause similar issues as the theme tag did. I don't think we should add more features that affect both functionality and categorization like that.
The forums tag should be only for addons users want to see when choosing "forums" in a menu. Maybe infinite scrolling should be one of them, but what about website dark mode?
from scratchaddons.
The editor is not different pages, whereas the forums and the profiles are.
It still doesn't make sense for editor addons to behave differently than website addons in any way.
from scratchaddons.
Related Issues (20)
- Use blue as the accent color in light mode HOT 2
- Scratch adding refuses to load in Orion both mobile and desktop HOT 10
- Customize Home Screen HOT 1
- Make author names in forum quotes clickable HOT 12
- Audio fine tuning HOT 4
- Multi-select sprites and assets HOT 2
- Change the color of the extension UI HOT 5
- `hide-backpack`: impossible to drop in the backpack HOT 2
- Popup and settings page should know if the browser is unsupported HOT 1
- `addon.tab.direction` sometimes fails
- Make `safeMsg` a module instead of a function parameter
- Custom extension webpage CSS HOT 1
- Image file metadata and the `better-img-uploads` addon HOT 5
- Variable Manager Upgrade HOT 9
- "Enhanced full screen" (`fullscreen`) makes stage blurry (inconsistent canvas size)
- Mobile/Touch Tag HOT 2
- An AI assistant HOT 18
- Max list safe length too high in `variable-manager` HOT 2
- Sprite list sorting
- Saved comments/forum posts HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from scratchaddons.