sdatkinson / iplug2 Goto Github PK

Hello,

I created two Pull requests to fix issues with macOS:

1- Replace all occurrences of 'std::exception("message")' Error: "No matching conversion for functional-style cast from 'const char[76]' to 'std::exception'"

2- Update ../scripts/prepare_resources-mac.py Error: Multiple errors related to Python 3

Thanks!

• Move current knob to be input level.
• Add output level
• Both in dB, -20 to 20

Hello,

I just get this sound after building the macOS app for /iPlug2/Examples/NAM/, any ideas where to trouble shoot? Thanks!

MacBook Pro M1, Mac OS 12.4, Xcode Version 13.4.1

Hey, as mentioned... this memset is only zeroing half of the buffer, so the buffer could contain garbage values... so you might want to either change that on your fork or wait to merge sdatkinson/NeuralAmpModelerPlugin#406 before doing your release

I get this error while trying to build VST3 or APP Targets / macOS 12.4 Apple M1 Xcode 13.4.1

No matching constructor for initialization of 'wavenet::WaveNet'

/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX12.3.sdk/usr/include/c++/v1/__memory/unique_ptr.h:728:32: error: no matching constructor for initialization of 'wavenet::WaveNet'
return unique_ptr<_Tp>(new _Tp(_VSTD::forward<_Args>(__args)...));
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Users/user/Dev/iPlug2/Examples/NAM/get_dsp.cpp:83:17: note: in instantiation of function template specialization 'std::make_unique<wavenet::WaveNet, std::vectorwavenet::LayerArrayParams &, const float &, const bool &, nlohmann::basic_json<>, std::vector &>' requested here
return std::make_uniquewavenet::WaveNet(
^
In file included from /Users/user/Dev/iPlug2/Examples/NAM/get_dsp.cpp:7:
/Users/user/Dev/iPlug2/Examples/NAM/wavenet.h:202:5: note: candidate constructor not viable: expects an lvalue for 4th argument
WaveNet(
^
/Users/user/Dev/iPlug2/Examples/NAM/wavenet.h:200:9: note: candidate constructor (the implicit copy constructor) not viable: requires 1 argument, but 5 were provided
class WaveNet : public DSP {
^
/Users/user/Dev/iPlug2/Examples/NAM/wavenet.h:200:9: note: candidate constructor (the implicit move constructor) not viable: requires 1 argument, but 5 were provided
5 warnings and 1 error generated.

I think it would be a decent idea to wrap DSP into it's own namespace other than just DSP, since it is such a widely used shorthand name. I looked the sources and many others seemed to have a-ok names so just an idea! I had to modify em manually to fit on my own project.

Thank you for your hard work, this thing is awesome! :)