sdaugherty / mediawiki-page-attachment Goto Github PK

What steps will reproduce the problem?
1. Clicking on "upload and attach file"

What is the expected output? What do you see instead?
Expected output would be an upload dialog, but instead the following Error 
Message shows up:
Fatal error: Class 'PageAttachment\Upload\Title' not found in 
C:\xampp\htdocs\wiki\extensions\PageAttachment\upload\Upload.php on line 90

What version of the product are you using? On what operating system?
Version 1.0.0-b3 on mediawiki 1.17 in windows server2003 R2

Need internationalization capability for audit-log messages.

Truncate long file name to keep the display section evenly spaced.

What steps will reproduce the problem?
1. Create a message file for a language other than English 
2. Update code to include the message file
3. Under user preference, change language preference to that language
4. Open a Wiki page

What is the expected output? What do you see instead?
Attachment section labels/messages should be in user language.  Instead, 
labels/messages are still in English.

Please use labels and text to provide additional information.
All releases

What steps will reproduce the problem?
1. Click on "View Attachment Information and History"
2. On file page edit file description and save

What is the expected output? What do you see instead?
Updated description should be displayed. Instead, still shows old description.

Audit logging fails when a file is deleted using MediaWiki's file deletion 
command.

Steps to reproduce:
1. Enable audit logging
2. Use MediaWiki's file deletion option to delete a file

I tried the extension in my wiki and changed the language to "de".
if i click on attach file, i´m redirected to create a new page because i´m 
linked to "Main Page" instead of the localized counterpart.

greets Markus

When in Edit/Preview/etc. mode, attached to page name is not set, and 
attachment load javascript throws exception.  This is visible to user when show 
script errors is turned on.

Need a better way to handle this.

What steps will reproduce the problem?
1. Enable set category on upload
2. Access any page

What is the expected output? What do you see instead?
No error.

Please use labels and text to provide additional information.
MediaWiki 1.19aplha

Drop un-used column "activity_detail" from audit log table

What steps will reproduce the problem?
1. Make changes to attachment list on a page that is being watched


What is the expected output? What do you see instead?
Notification message should be in user's preferred language.
Notification message is in Wiki's default language.

Please use labels and text to provide additional information.
To be released PageAttachment versions 1.4.0 & 2.1.0

Need table creation SQL files for MediaWiki supported databases other than MySQL

For PHP 5.2.x release lines:  German message files are corrupted.

The transformation script is removing the backslash needed to escape the single 
quotes.

The message files do not need any namespace transformation and should be 
excluded from any processing.

Currently only checking the following:

  1. User is allowed to upload
  2. User is not blocked
  3. Wiki not in read-only mode

Need to add the following checks:

  1. Normal users are allowed to upload
  2. Autoconfirmed users are allowed to upload
  3. etc. ...

See:
  1. SpecialUpload.php [ public function execute($par)  ] 
  2. http://www.mediawiki.org/wiki/Manual:Configuring_file_uploads#Upload_permissions

What steps will reproduce the problem?
1. Hover the cursor on description field and the description content is very 
large. 

What is the expected output? What do you see instead?
Description popup dynamically adjust to contain the content and doesn't 
overflows or bleeds over the boundary.

Update to take advantage of new resource loader in MediaWiki 1.17.0

Hi PageAttachment developers,

It's a top mediawiki extension with some starting problems.

Install handbook by: http://www.mediawiki.org/wiki/Extension:PageAttachment

1#
PHP Warning:  
require(/var/www/extensions/PageAttachment/auditlog/AuditLogManager.php): 
failed to open stream: No such file or directory in 
/var/www/includes/AutoLoader.php on line 654
PHP Fatal error:  require(): Failed opening required 
'/var/www/extensions/PageAttachment/auditlog/AuditLogManager.php' 
(include_path='/var/www:/var/www/includes:/var/www/languages:.:/usr/share/php:/u
sr/share/pear') in /var/www/includes/AutoLoader.php on line 654

solved: 
In ../auditlog/ rename file AuditlogManager.php to AuditLogManager.php (Upper L 
case!)

2#
PHP Warning:  
require(/var/www/extensions/PageAttachment/attachment/AttachmentDatafactory.php)
: failed to open stream: No such file or directory in 
/var/www/includes/AutoLoader.php on line 654, referer: 
http://xx.xx.xx.xx/index.php/Main_Page
PHP Fatal error:  require(): Failed opening required 
'/var/www/extensions/PageAttachment/attachment/AttachmentDatafactory.php' 
(include_path='/var/www:/var/www/includes:/var/www/languages:.:/usr/share/php:/u
sr/share/pear') in /var/www/includes/AutoLoader.php on line 654, referer: 
http://xx.xx.xx.xx/index.php/Main_Page

Webserver talk Error (PageAttachment window): 500 Internal Server Error ()

solved:
In ../attachment/ rename file AttachmentDataFactory.php to 
AttachmentDatafactory.php (Lower F case!)

3#
Webserver talk Error at upload or search/attach (PageAttachment window): » 
Error: Unable to Determine Attach to Page «

not really solved:
PageAttachment works fine with LocalSettings.php set to $wgLanguageCode = "en", 
but not work with $wgLanguageCode = "de";

###
My system:
Mediawiki 1.16.2
PHP 5.3.6-13ubuntu3.2 (apache2handler)
Ubuntu Server 11.10 x64

This is my developer plattform for the new Corporate Portal base on Mediawiki. 
Ubuntu 11.10 is use for future using of Ubuntu 12.04 LTS.

###
An translate german message file will be sent if language problem solved.

Thx
Daniel

Change HTML "table" element with "div" to match MediaWiki's presentation layout.

What is the expected output? What do you see instead?
A description of the file in a column to the right of the file name.
Thanks!

For MediaWiki 1.17.0 & Up:

Running "../mw-config/index.php" to reconfigure the wiki fails on 
"PageAttachment\RequestHandler" not found exception.


Workaround:
==========

Step 1:
------
Comment out the following file in "LocalSettings.php" file

    require_once("$IP/extensions/PageAttachment/SetupExtension.php");

Step 2:
------
Then when you are done reconfiguring your wiki, un-comment the following in 
"LocalSettings.php" file.

    require_once("$IP/extensions/PageAttachment/SetupExtension.php");

Step 3:
------
To ensure the database is in usable state for PageAttachment extension, from 
MediaWiki's "maintenance" directory, run the following command: 

    php update.php

Hi Aldrin!

I´ve tried the latest version of the pageattachment extension and a new bug 
occured:

event is not defined
 if (event.persisted)
http://172.27.2.191/wiki/extensions/PageAttachment/skins/js/page-attachment.js?3
01 (Line 123)

I´m working with Mozilla Firefox 7.0.1

Greets Markus

Tested with MediaWiki 1.18.0beta1.  Doesn't work. 

Fails on initialization. If initialization is fixed, then get "wfGetMainCache" 
not found exception -- not sure why, if explicitly "GlobalFunctions.php" is 
included then this error goes away.  Then start getting errors on hooks call -- 
reference not expected error.  After this stopped trying to make it work.

Will wait for the final release and after that will look into this.

Does not work under MediaWiki 1.17.0 because of incompatibility with the new 
resource loader.

Work is under way to resolve this issue.

What steps will reproduce the problem?
1. Is there a command I can drop in to pages I don't want the attachment box to 
appear on? (I dont want it on the home page for instance and by default, it 
would be nice to be able to only include it if I want it there rather than on 
all pages
2. Great extension by the way :)
3.

What is the expected output? What do you see instead?


What version of the product are you using? On what operating system?

  PageAttachment version  :2.0.2
  MediaWiki version       :1.18.2
  PHP version             :5.3
  Operating System name   :win
  Operating System version:7


Please provide any additional information below.

This is based on request from Elliot B. received through email.

Set attachment category during upload like "CategoryOnUpload" extension.  Set 
attach to page as the category.

Other options:
Allow users to select the category from a drop-down input box based on existing 
categories. Make attach to page as one of the category.

Per "CategoryOnUpload" documentation, it should not be used on large Wikis. So, 
make sure this can be used on large Wikis with large number of categories.

View audit log doesn't work for single file when file name has special 
characters.  For example: '&'

View audit log doesn't work for single file under MySQL binary collation.

What steps will reproduce the problem?
1. install Mediawiki-1.18.2
2. extract and setup PageAttachement extension from 
mediawiki-page-attachment-2.1.0-beta-1.zip
3. run php maintenance/update.php

What is the expected output? What do you see instead?

PHP Fatal error:  Class 
'\PageAttachment\Security\MediaWiki\Upload\UploadPermissionChecker_MediaWiki_v11
70' not found in 
/opt/mediawiki-1.18.2/extensions/PageAttachment/security/mediawiki/MediaWikiSecu
rityManagerFactory.php on line 69

What version of the product are you using? On what operating system?
Mediawiki-1.18.2, mediawiki-page-attachment-2.1.0-beta-1, php 5.3.2
Ubuntu 10.04-1

Please provide any additional information below.

following patch seems to fix this issue:
--- ./configuration/DefaultSystemConfigurations.php.orig    2012-03-29 
12:48:36.286822600 +0900
+++ ./configuration/DefaultSystemConfigurations.php 2012-03-29 
12:57:46.216824459 +0900
@@ -37,8 +37,8 @@
 #
 #
 #
-$wgPageAttachment_mediaWikiUploadPermissionChecker[1][16] = 
'\\PageAttachment\\Security\\MediaWiki\\Upload\\UploadPermissionChecker_MediaWik
i_v1162';
-$wgPageAttachment_mediaWikiUploadPermissionChecker[1][17] = 
'\\PageAttachment\\Security\\MediaWiki\\Upload\\UploadPermissionChecker_MediaWik
i_v1170';
+$wgPageAttachment_mediaWikiUploadPermissionChecker[1][16] = 
'PageAttachment\\Security\\MediaWiki\\Upload\\UploadPermissionChecker_MediaWiki_
v1162';
+$wgPageAttachment_mediaWikiUploadPermissionChecker[1][17] = 
'PageAttachment\\Security\\MediaWiki\\Upload\\UploadPermissionChecker_MediaWiki_
v1170';
 $wgPageAttachment_mediaWikiUploadPermissionChecker[0][0]  = $wgPageAttachment_mediaWikiUploadPermissionChecker[1][17];


@@ -53,12 +53,12 @@
 #
 # :: Message Composers ::
 #
-$wgPageAttachment_messageComposers['email'] = 
'\\PageAttachment\\Notification\\Email\\EmailMessageComposer';
+$wgPageAttachment_messageComposers['email'] = 
'PageAttachment\\Notification\\Email\\EmailMessageComposer';

 #
 # :: Message Transporters ::
 #
-$wgPageAttachment_messageTransporters['email'] = 
'\\PageAttachment\\Notification\\Email\\EmailTransporter';
+$wgPageAttachment_messageTransporters['email'] = 
'PageAttachment\\Notification\\Email\\EmailTransporter';


 ## ::END ::

What steps will reproduce the problem?
1. Click on Browse/Search Attach button


What is the expected output? What do you see instead?
A page displaying existing files to attach.
Get the following error:

Catchable fatal error: Argument 1 passed to ImageListPager::__construct() must 
implement interface IContextSource, none given, called in 
/Users/aldrin/Sites/mw1.19.0-alpha/phase3/extensions/PageAttachment/browse-searc
h/ImageListPager.php on line 52 and defined in 
/Users/aldrin/Sites/mw1.19.0-alpha/phase3/includes/specials/SpecialListfiles.php
 on line 66

Please use labels and text to provide additional information.
MediaWiki 1.19alpha

What steps will reproduce the problem?
1. Access any Wiki page


What is the expected output? What do you see instead?
Page Attachments List Section should be rendered.

Please use labels and text to provide additional information.
MediaWiki 1.19alpha

Delete a file permanently when an attachment is deleted.

Make this option configurable (enable/disable).


This enhancement request was received from Tom through email. 

What steps will reproduce the problem?
1. Go to "SpecialPages" page
2. "Upload & Attach" special page is listed


What is the expected output? What do you see instead?
"Upload & Attach" special page should not be listed

Please use labels and text to provide additional information.
Releases: 2.0.0 & 2.0.0-php-5.2

When permanent attachment removal is enabled, do not store deleted file 
information, since, not needed and would fill-up the database with useless 
data. 

PA didn't work on my hoster, which has only PHP 5.2.13 (zend compatibilty)

Error on:
"$requestHandler = new PageAttachment\RequestHandler();"
"namespace PageAttachment\Messages;"
etc.

Need message files for all MediaWiki supported languages.

Currently supported languages:
1. English

What steps will reproduce the problem?
1. Undelete a file that was previously attached to a page


What is the expected output? What do you see instead?
Attachment is restored to the previously attached to pages.
MediaWiki shows error in inserting data into audit log table with message that 
attached to page id cannot be null.

Please use labels and text to provide additional information.
PageAttachment version 1.x

For Right-to-Left languages, correctly trim the description text when the 
length is longer than maximum displayable length.

Attachment list is not displayed when not logged in.

Update Wiki with documentation for all the configuration options

Replace Deprecated "sajax_do_call" Ajax function with new jQuery function in 
"page-attachment.js"

Add an Option to View Upload Comment

What steps will reproduce the problem?
1. Click on Browse/Search button to attach existing file
2. Select a file to attach


What is the expected output? What do you see instead?
The attached to page is shown with the file attached.
Instead, the "No such action" error page is shown with a link back to the 
attached to page.

Error Page Message:
[[
No such action
Jump to: navigation, search

The action specified by the URL is invalid. You might have mistyped the URL, or 
followed an incorrect link. This might also indicate a bug in the software used 
by mw1190-alpha.

Return to Main Page.
]]


Please use labels and text to provide additional information.
MediaWiki 1.19aplha

wfMsg returns timezone region name in user's language if available.  However, 
it doesn't work for timezone city name.

Make 1.3.1 release line compatible with PHP version >= 5.3.0 by applying fixes 
from Issue# 31

As reported on
https://www.mediawiki.org/wiki/Extension_talk:PageAttachment#Fatal_Error:_Class_
ListFiles_not_found_8360
there had to be a small modification in SetupExtension.php to resolv this issue:

Old:
## Special Pages (Unlisted)
$wgSpecialPages['PageAttachmentListFiles']        = 
'\\PageAttachment\\BrowseSearch\\ListFiles';
$wgSpecialPages['PageAttachmentUpload']           = 
'\\PageAttachment\\Upload\\Upload';
$wgSpecialPages['PageAttachmentAuditLogViewer']   = 
'\\PageAttachment\\AuditLog\\AuditLogViewer';

New:
## Special Pages (Unlisted)
$wgSpecialPages['PageAttachmentListFiles']        = 
'PageAttachment\\BrowseSearch\\ListFiles';
$wgSpecialPages['PageAttachmentUpload']           = 
'PageAttachment\\Upload\\Upload';
$wgSpecialPages['PageAttachmentAuditLogViewer']   = 
'PageAttachment\\AuditLog\\AuditLogViewer';

You are able to reproduce it on
Ubuntu 10.04 LTS with all patches and mediawiki 1.18.0 (installed through 
tar.gz) and downloaded PageAttachment-extension 
http://mediawiki-page-attachment.googlecode.com/files/mediawiki-page-attachment-
2.0.0.zip

Hope you can fix this soon.

There currently is no security check for protected pages like there is for 
logged in users and this will breach the security of a page if present.

Tried to fix the issue myself but unable to do so and we have spoken over email 
regarding this minor problem.


Currently running: 
mediawiki 1.72
PageAttachment 1.3.2
php 5.3.8 (apache2handler) 
MySQL 5.5.16

Many thanks for your hard work Aldrin.

What steps will reproduce the problem?
1. Edit a page & save
or,
1. Upload & attach a file
or,
1. Browse/search & attach a file

Expected to see attachment list section displayed.
Instead got collapsed attachment list section with no attachments listed 

This doesn't always happens.
Only happens on MediaWiki 1.16.2 only.         

What steps will reproduce the problem?
1. Download 2.0.2 of PageAttachment
2. Install and activate in LocalSettings.php
3. Run php maintenance/update.php
4. Browse to a wiki page

What is the expected output? What do you see instead?
Expected output: the normal wiki page rendered
Seen instead:
Warning: Unexpected character in input: '\' (ASCII=92) state=1 in 
extensions/PageAttachment/SetupExtension.php on line 131

Parse error: syntax error, unexpected T_STRING in 
extensions/PageAttachment/SetupExtension.php on line 131

(note: the full path to the wiki was redacted from the above statements)

What version of the product are you using? On what operating system?
* PageAttachment version: 2.0.2
* MediaWiki version: 1.18.0
* PHP version: 5.2.17 (cgi-fcgi)
* Operating System name & version: Linux 2.6.32.8

Please provide any additional information below.
Line 131 reads:         $requestHandler = new PageAttachment\RequestHandler();
I suspect it is the backslash that is causing the problem.

What steps will reproduce the problem?
1. I have installed the code fully, added the db tables and got everything 
working in the code (categories appear in the upload page) and I dont have any 
crashes any more. However, I have NO idea how to add the tables you show in the 
preview images and I have found no advice or documentation on how to actually 
implement and add attachments to pages. Please can you provide something or 
show some screenshots of what I should see in the way of options on file edit 
pages which would allow me to attach files?

What is the expected output? What do you see instead?


What version of the product are you using? On what operating system?

PageAttachment version  :
MediaWiki version       :
PHP version             :
Operating System name   :
Operating System version:


Please provide any additional information below.

Add watch capability like MediaWiki provide for each page.  When attachment 
added/updated/removed, send notification to users (watchers) who are watching 
the page that has attachments.