sdroege / rtsp-server Goto Github PK

<slomo> the problem is that it is only binding later when you actually start the server, so at that point it can't yet know. i wonder how actix does that. maybe something to steal an idea from.

See

I tried to implement handle_request on the client::Client like this:

use std::pin::Pin;
use futures::prelude::*;

#[derive(Debug)]
pub struct Client {
    basic_client: rtsp_server::client::basic_client::Client,
}

impl Default for Client {
    fn default() -> Self {
        Client {
            basic_client: rtsp_server::client::basic_client::Client::default(),
         }
    }
}

impl rtsp_server::client::Client for Client {
    fn handle_request(
        &mut self,
        ctx: &mut rtsp_server::client::Context<Self>,
        request: rtsp_server::client::OriginalRequest,
    ) -> Pin<
	Box<
            dyn Future<
                Output = Result<
                    rtsp_types::Response<rtsp_server::body::Body>,
                    rtsp_server::error::Error
                >
            > + Send
        >
    > {
       	self.basic_client.handle_request(ctx, request)
    }
}

But this fails with:

error[E0308]: mismatched types
  --> src/client/mod.rs:32:42
   |
32 |         self.basic_client.handle_request(ctx, request)
   |                                          ^^^ expected struct `rtsp_server::client::basic_client::Client`, found struct `client::Client`
   |
   = note: expected mutable reference `&mut rtsp_server::client::Context<rtsp_server::client::basic_client::Client>`
              found mutable reference `&mut rtsp_server::client::Context<client::Client>`

I tried to implement a From trait for the clients, but that didn't work either. The workaround is to simply copy basic_client and change whatever you need to.

See

Should also ideally make use of vectored writes.

• appsink/appsrc helpers should be separate API
• Have some kind of "gst-launch" style media factory / media
• Also API for explicit pipelines
• SDP<->caps conversion API (and should probably implement SDP builders, see issue in sdp_types crate)

See

• server::Server should get API for listing clients, sessions, etc. and getting information from them, terminating them, etc
• Media, factory, client, specific API in the same style

See

Check the user agent version and if old enough use RTSP 1.0 Transport/RTP-Info instead.

See

Related GStreamer bugs:

• https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/issues/835
• https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/issues/834
• https://gitlab.freedesktop.org/gstreamer/gst-rtsp-server/-/issues/129
• https://gitlab.freedesktop.org/gstreamer/gst-rtsp-server/-/issues/128

Maybe via specific error types for those error codes

Requires adding Terminate-Reason support to rtsp-types and then adding some API here to make use of it, and also do that automatically in basic_client and other places where it makes sense to kick out the client.

See

I tried to build the rtsp-server with an older cargo version, but it fails because the default branch of the dependency rtsp-types was changed to 'main'. In older Cargo Versions, Cargo tries to pull repos with the default branch master which does not exist anymore.

This can easily be fixed by changing line 18 in Cargo.toml to:

rtsp-types = { git = "https://github.com/sdroege/rtps-types.git", branch = "main" }

I would be very pleased, if this will be fixed. Thx :)

See

Hello, I did not have time to read the server yet. I used in my client the message_socket.rs code you pointed me, very good.

I just made my client work with authentication (RTSP uses the same basic/digest scheme as HTTP). I implemented it myself as the ones I found in Rust were either tied to hyperx or not very good. Are there plans to include digest authentication in the server? I didn't see any crypto dependencies on your cargo.toml so I assume there's no digest authentication support. If you'd like to join forces to enhance mine, it would be nice. I just didn't release the code yet as I'm cleaning.

I just tested MD5, Sha2 and Sha512 with examples from RFC and it worked. I just tested on a real camera and it worked. Added some nice tests to it.

See

Also backpressure should generally be implemented better.