seandesmond / angular-payment Goto Github PK

i dont know how to make a pull request so i create this issue. sorry.

Hello, i found some issues with angular 1.3. + , when loading ngModel from a service, in this line was omittet de return value

.directive('cardCvcValidator', ['payment', function (payment) {
'use strict';
return {
require: 'ngModel',
link: function (scope, elm, attrs, ngModelCtrl) {
function validate(value) {
var valid = value ? payment.validateCardCvc(value) : false;
ngModelCtrl.$setValidity('cardCvc', valid);
return valid;
}

            ngModelCtrl.$parsers.unshift(function (value) {
                return validate(value) ? value : undefined;
            });

            ngModelCtrl.$formatters.unshift(function (value) {
                validate(value);
           //add this line    return value;
            });
        }
    };
}]);

and is an issue on angluar 1.3 + with formatters when the value is an object it need push .. not unshift.

i hope this can help to perform you amazing directive.

Hi @seandesmond - it appears this does not work on mobile chrome (I tested with Android) - any ideas why? The month/year field especially does not auto add the slash and furthermore prevents adding one manually so the field can not be filled out at all, effectively breaking the form and preventing payment, so it's a pretty serious bug. I've removed the directive for now on mobile chrome temporarily but it would be awesome to be able to use it again!

First, for some reason this doesn't show up in bower search. Second when requiring it after having installed it with bower I get the following error:

Sprockets::FileNotFound - couldn't find file '/Users/brianthecoder/Dropbox/code/20jeans/dstld/vendor/assets/bower_components/angular-payment/tree/gh-pages/payment-tpls-0.1.0-SNAPSHOT.js'

It looks like the file you're requiring is on a different branch, but I can't use that branch because it doesn't have a bower.json, why not just create a dist folder on the master branch and store the files there. It seems to be the common way I've seen with bower.

Is there a way to get the cards brand from the credit card directive?

Month value isn't being validated to be less or equal than twelve.

This directive is awesome but for some reason it does not work on mobile which makes it useless now a days. Please fix this!!!!

looks like there's an issue with keypress on some browsers. i think keyup should work.

https://github.com/seandesmond/angular-payment/blob/master/src/cardExpiry/cardExpiry.js#L77

http://stackoverflow.com/questions/21055270/javascript-keypress-event-not-raised-on-android-browser#answer-24434463

Great directive, loving the no dependencies! However, we just upgraded to the more recent Angular versions and this no longer works. I noticed this hasn't been updated for about a year and currently the gh-pages branch uses angular 1.1.5. Could you update it to work with 1.2.x and 1.3.x?

Thanks!

Would it be possible to tag the 0.2.0 release in this repo so I can pull this lib in with https://rails-assets.org/ ?

Hello, it is not an issue but i could not find another way to talk to you.

I was just wondering why do you restrict use of directives to element only?

Could support for the new Mastercard BIN-2 range (222100-272099) be added?
Test cards: 2223000048400011 or 2223520043560014.

https://www.mastercard.us/en-us/issuers/get-support/2-series-bin-expansion.html

Implemented CC, CVC and Expiry fields.

 <card-number-input name="number" ng-model="data.creditcard.number" card-type="data.creditcard.type" required></card-number-input>
  <card-expiry-input name="expiration" ng-model="data.creditcard.expiration" ></card-expiry-input>
  <card-cvc-input name="cvv2" ng-model="data.creditcard.cvv2"></card-cvc-input>
  data: {{data.creditcard}}

User enters the data and model results in:
{"type":"visa","number":"4111111111111111","expiration":{"month":12,"year":2018},"cvv2":"123"}

User saves the form, but decides later to edit the information. The model hasn't changed and looks exactly as above, however, neither the CVC nor the Expiry field show the model values.

I'd like all fields to show the data entered before.
What am I missing?

Thanks...

I've noticed that though the spaces in a credit card number get auto added they don't also get removed automatically.

I was expecting "4111 ", caret at end and I push backspace to get "411". Currently it just removes the space and not the number as I expected.

We've moved away from bower and now use npm exclusively. Its easy enough to specifically call this git repo in our package.json but it would be super great if it was officially registered so versioning was easier.

npm?

Certian services like Braspag require a test credit card number "0000 0000 0000 0001" to be used in their sandbox enviroment. I was unable to acomplish this with the current version of the plugin.

It would be great if the plugin supported this usecase.

<input card-number-validator 
           data-whitelist="['0000 0000 0000 0001']" 
           data-ng-model="ccNumber"  />