Docker Support about fastapi-template HOT 3 CLOSED

Hi @pdrivom 👋

Yeah, that's a great idea, please create a PR, and I'll take a look.

I noticed you created and closed a couple of PR already, so I was looking to reach out to you anyway 😄

Thanks for the comment. I've really learned a lot from working on this project, and hope it can be of use to you and others.

from fastapi-template.

Could you please split the Secweb stuff into a separate PR, in case you haven't already?

I personally tend to add the headers directly in the Nginx site configuration (I have specific files I include), but I can see how the addition would be very useful. I'd prefer it was an optional feature (set by the .env file, even if it defaults to True).

from fastapi-template.

Hello @seapagan, yes, I will split them. Yeah I created the PRs basically to test the pipelines and chek how you built the PR flow and it's preaty nice. I just want to check how to get the Dockerfile validation to pass on the code analysis. Since it's not for production focus, those validations are not relevant yet. We can also add a nginx integartion with the headers for the production option (ex: on the Kubernetes manifest).

from fastapi-template.