PHP-Scoper 0.18.12 breaks PHAR for PHPUnit 8.5 on PHP 7.2 about phpunit HOT 8 OPEN

@theofidry Before I dig into this, is there anything that would be obvious to you that might explain this? Thanks!

from phpunit.

Maybe this from the release https://github.com/humbug/php-scoper/releases/tag/0.18.12

Upgrade to PHP-Parser v5 (humbug/php-scoper#1025)

https://github.com/nikic/PHP-Parser?tab=readme-ov-file#php-parser says:

Documentation for version 5.x (current; for running on PHP >= 7.4; for parsing PHP 7.0 to PHP 8.3, with limited support for parsing PHP 5.x).

So you can't run this on PHP < 7.4 I guess? 🤔

from phpunit.

@mfn PHP-Scoper requires a newer version of PHP, yes. But that does not have to mean that the modified code no longer works with PHP 7.2.

from phpunit.

Aside from the PHP-Parser upgrade I don't see anything that could cause this :/ Do you have the offending code by any chance? I can take a look at it

from phpunit.

$ git clone [email protected]:sebastianbergmann/phpunit.git
$ cd phpunit
$ git checkout 8.5
$ ant phar-snapshot
$ php-72 build/artifacts/phpunit-snapshot.phar

Parse error: syntax error in phar:///usr/local/src/phpunit/build/artifacts/phpunit-snapshot.phar/phpunit/Framework/MockObject/Generator.php on line 736

$ phar extract -f /usr/local/src/phpunit/build/artifacts/phpunit-snapshot.phar
$ php-72 -l phpunit/Framework/MockObject/Generator.php

Parse error: syntax error in phpunit/Framework/MockObject/Generator.php on line 736
Errors parsing phpunit/Framework/MockObject/Generator.php

Attached is the result of ant phar-snapshot for the current state of the 8.5 branch.

phpunit-snapshot.phar.tar.gz

from phpunit.

Ok I got a small reproducer within the PHP-Scoper test suite, will look more into it

from phpunit.