sebpiq / pd-fileutils Goto Github PK

View Code? Open in Web Editor NEW

83.0 83.0 16.0 1.16 MB

A node module providing various utilities for Pure Data files.

License: BSD 2-Clause "Simplified" License

JavaScript 99.42% Handlebars 0.58%

pd-fileutils's People

Contributors

Stargazers

Watchers

Forkers

taylorbf alessandrostone adkelley toolness 821760408-sp opendawn jahpd giuliomoro simon-l unforeseenocean ekzy macromachines chairmanholtz goozo kaosbeat wasted-audio

pd-fileutils's Issues

add width & height to the rendered SVG

Otherwise the SVG is cropped inside the page :

<!doctype html>
<html>
  <head>
    <style>
      body {
        background-color: black;
      }
img {
        background-color: red;
}
    </style>
  </head>
  <body>
    <img src="https://enzienaudio.com/a/dave?fetch=https://raw.githubusercontent.com/mhroth/ZenGarden/master/test/MessageInteger.pd" />
  </body>
</html>

chunk #C

Add support for it. First maybe find what it is :)

[bug] comments are shown in different position than expected

For some reason, comments are being shown higher than expected. These can cause some conflicts, since comments are sometimes used to describe an object to its immediate side. E.g., look for the two comments <- input 1, 2, 3 or 4 here and <- input a, b, c or d in the following patch:

https://enzienaudio.com/a/dave?fetch=http://forum.pdpatchrepo.info/uploads/files/upload-e60ec29d-d318-4a97-bd8b-d223650acc35.pd

Corect display: http://forum.pdpatchrepo.info/uploads/files/upload-cf44d166-49be-4ef4-9adb-dd90079f8d3b.png

[enhancement] different thickness for signal cords

I would like to suggest making signal cords thicker (or rather message cords thinner), as with regular Pd, so that they can be easily identifiable. As of now, it's kind of tricky to see which patch cords are carrying signals and which aren't, e.g.: https://enzienaudio.com/a/dave?fetch=http://www.pdpatchrepo.info/hurleur/vfreeverb~alt.pd

bug with svg render

In the render function, there shouldn't be d3.select('svg').remove() cause it will remove svg elements if called in a web page.

https://github.com/sebpiq/pd-fileutils/blob/master/lib/svg-rendering.js#L41

Limit width of rendered objects

I found two displaying problems with objects in general. The first is that objects are not limited in span as they are in pd vanilla, extended or l2Ork. The second one is when an object contains a comma (such as when using [expr if]), the comma is displayed as , and not simply ,

These problems may also appear in messages, although I haven't test that yet.

Example. Compare this...: https://enzienaudio.com/a/dave?fetch=http://forum.pdpatchrepo.info/uploads/files/upload-4b5f0aba-6363-4f49-975f-df5a26f4a66a.pd

...to this: http://forum.pdpatchrepo.info/uploads/files/upload-76b1b5da-45ac-48be-b406-a93c883518cc.png

EDIT: I also noted that the messages are truncated. Where the png shows [0.123456789( pd-fileutils shows [0.1234567(

Handle coords ?

I don't really know ... is that really useful?

semicolon and messages

When one types a semicolon inside a message in Pd, next time the patch is opened there is a line break between the semicolon and the rest of the message. Currently, pd-fileutils does not do that (see both messages in the right side of the patch below):

https://enzienaudio.com/a/dave?fetch=http://forum.pdpatchrepo.info/uploads/files/upload-e60ec29d-d318-4a97-bd8b-d223650acc35.pd

Corect display: http://forum.pdpatchrepo.info/uploads/files/upload-cf44d166-49be-4ef4-9adb-dd90079f8d3b.png

[bug] object width information should not be displayed

The width of an object is written in a .pd file as , f <n>, where is a number (note that only pd vanilla and l2ork can change the width of an object). Pd-extended, for instance, is programmed to ignore such (which is fairly easy, since no object name can contain a comma). The same should be applied to pd-fileutils: either ignore these information or make use of it for correct width, but do NOT display it such as below (see the last [unpack s s] in the very bottom of the patch which contains an , f 14):

https://enzienaudio.com/a/dave?fetch=http://forum.pdpatchrepo.info/uploads/files/upload-e60ec29d-d318-4a97-bd8b-d223650acc35.pd

Corect display: http://forum.pdpatchrepo.info/uploads/files/upload-cf44d166-49be-4ef4-9adb-dd90079f8d3b.png

Browserify

Build for the browser and test it

check that ids are contiguous

When rendering to pd, ids are inferred from position of the object in the file, so we should check that when creating/rendering a patch, ids are contiguous.