Giter VIP home page Giter VIP logo

gimme-a-token's People

Contributors

sebsel avatar

Stargazers

 avatar  avatar  avatar

Watchers

 avatar  avatar  avatar

Forkers

dearprakash

gimme-a-token's Issues

use guaranteed invalid redirect_url

the .dev TLD was never reserved to never exist, and one can indeed now register .dev domains, and I now could register nonexisting-domain.dev (it seems to be still available).

Options:
Use one of .example or .invalid, which (among others) RFC2606 explicitly reserves.

".example" is recommended for use in documentation or as examples.
".invalid" is intended for use in online construction of domain
names that are sure to be invalid and which it is obvious at a
glance are invalid.

Maybe use the me url, assuming that wrongly sending the data there is at least safe since it's owned by the person testing.

I also considered using a "weird" url-scheme, but is more likely to be rejected I think.

Add links to XRay for easier endpoint discovery

The main goal of the tool is to be totally client-side, which makes it harder to call out to discover the right URLs (can't call cross domain for all URLs).

I could improve the documentation to point to the public XRay, which makes it easier to discover the right rel-links for the user.

Required state parameter is not sent to authorization endpoint

According to the spec, the state parameter is required as a parameter when making authentication and authorization requests:

I don't think gimme-a-token is provided the state parameter - if I use it to make an auth request to my endpoint, it is missing. (If I append a made up state value to the query string, the rest of the flow works fine.)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.