sed-pro-inria / tetrinria Goto Github PK

View Code? Open in Web Editor NEW

0.0 3.0 7.0 626 KB

A simple tetris implementation for training purpose

License: BSD 4-Clause "Original" or "Old" License

C 91.67% C++ 7.16% Makefile 1.08% Shell 0.08%

tetrinria's Introduction

tetrinria

A simple tetris implementation for training purpose

build in DEBUG mode

mkdir build_debug
cd build_debug
cmake -DCMAKE_BUILD_TYPE=DEBUG ..
make
./gtk/tetris-gtk

build in TEST mode

mkdir build_test
cd build_test
cmake -DCMAKE_BUILD_TYPE=TEST ..
make
CTEST_OUTPUT_ON_FAILURE=TRUE make test
./gtk/tetris-gtk

tetrinria's People

Contributors

Watchers

Forkers

cdoucet jakeill fredericn marianne64000 ldelaye dfroger raoufhamouda

tetrinria's Issues

Piece moving to the right

=> Pressing the right arrow key makes the piece move to the right.
Depends on #4

improve trn_grid_print readability

Coding rules checking fails

KWstyle configuration file is too complex and make the tests fail.

Make test_tetrinria_core.c pass kwstyle script

kwstyle script output:
Processing /home/training/tetrinria/core/test/KWstyle/../../test/test_tetrinria_core.c
Error #0 (63) Line length exceed 85 (max=81)
Error #0 (64) Line length exceed 89 (max=81)
Error #0 (103) Line length exceed 82 (max=81)
Error #0 (167) Line length exceed 85 (max=81)
Error #0 (332) Line length exceed 86 (max=81)
Error #0 (336) Line length exceed 86 (max=81)
Error #0 (436) Line length exceed 87 (max=81)
Error #0 (473) Line length exceed 82 (max=81)
Error #0 (483) Line length exceed 83 (max=81)
Error #0 (495) Line length exceed 82 (max=81)
Error #0 (496) Line length exceed 82 (max=81)
Error #11 (658) Number of spaces before end of line exceed: 4 (max=3)

should be empty

Piece going at the very bottom

=> Pressing the space bar makes the piece reach the bottom.
Depends on #4

Show grid

design grid
initialize components
draw grid

=> When the game starts, a grid is drawn.

create a subfunction in trn_grid_fill to throw out the second loop

Game over

When the grid is filled, the game ends.
See #2

Line length exceed 81 in game.c and game.h

To be changed:

Result of kwstyle:
"Processing ../../game.c
Error #0 (33) Line length exceed 83 (max=81)
Error #0 (58) Line length exceed 83 (max=81)

Processing ../../game.h
Error #0 (27) Line length exceed 90 (max=81)"

Empty file tetromino_srs.c

Piece going down faster

=> Pressing the down arrow key makes the piece going down faster.
Depends on #4

Piece moving to the left

=> Pressing the left arrow key makes the piece move to the left.
Depends on #4
See #10

Shorten trn_grid_equal by creating a subfunction

give a better structure to grid.c

Make grid.c pass kwstyle script

KWstyle output:
Processing /home/training/tetrinria/core/test/KWstyle/../../grid.c
Error #0 (54) Line length exceed 85 (max=81)
Error #0 (148) Line length exceed 85 (max=81)
Error #0 (175) Line length exceed 83 (max=81)
Error #0 (184) Line length exceed 85 (max=81)
Error #0 (198) Line length exceed 83 (max=81)

should be empty

On a clear line, score points

On multiple clear lines, score bonus points

See #5

Show piece going down

Depends on issue #2

ecrire un test pour la rotation des pieces

Piece rotating clockwise

=> Pressing the up arrow key makes the piece rotate clockwise.
Depends on #4

memory leaks

Valigrind detects memory leaks. See Travis output:

https://travis-ci.org/sed-pro-inria/tetrinria/builds/42204050

Cleaning to do in game.c - trn_game_check_complete_rows

Those lines are useless? To be checked and maybe removed.

start: line 167
look like: " printf("lines_count: %d\n", lines_count);
printf("score: %d\n", game->score);
trn_game_update_score(game, lines_count);
game->lines_count += lines_count;
printf("lines count: %d\n", game->lines_count);
printf("lines per level: %d\n", LINES_PER_LEVEL * (game->level+1));"