sedona-solutions / sedona-sbo Goto Github PK

The code itself should be tested + travis added

JMS DI should not be used in the bundles to not force developers to install it

Code is seen as duplication in the different generated classes

The next 45 lines appear in src/AppBundle/Datatables/AlbumDatatable.php:63, src/AppBundle/Datatables/ArtistDatatable.php:63 and src/AppBundle/Datatables/TrackDatatable.php:63.

The next 24 lines appear both in src/AppBundle/Datatables/AlbumTrackDatatable.php:45 and src/AppBundle/Datatables/TrackDatatable.php:39.

Code Factorisation should be done

Based on the principle that removing code is easier than adding, the code generator generates a lot of code, and in doubt sometime generates commented code that can be activated by uncommenting it.

However, it can be seen as a bad practice and code quality checker raise warnings on it.

Those generated optional codes should have a custom syntax to be easily detected, and a new command line to automatically remove them should be added.

Behat Tests should be automatically generated at the same time than Controlers

Sensio Insights usually reports that our controllers have too many actions.

It's usually true for Entity having different relations with other entities: they have several actions for each relation to list/add/delete.

A fix could be to generate separate controllers for relations, but in this case, they should be grouped by Entities in folders or there will be too many files.

KnpLabs translatable behavior should be managed

DateTime system only works for "en" projects.
Should be working for all languages.

• Bug with front JS: localized version of Moment are not correctly loaded (fix in progress with #9 )
• Symfony Type expects US date format, the format should be dynamic according to current locale

Using the same basic idea, it should be possible to generate REST controlers based on FOSRESTBundle
sbo:generate:api