Comments (10)
https://github.com/patrickmarabeas/nothing-to-see-here/tree/stuff
Pat has kindly donated a private repo so it's less likely I'll get fired out of a cannon in to the sun for doing this, haha.
from playroom.
Upgrading to styled-components
4.x.x and using createGlobalStyles
instead of injectGlobal
works, guessing this will fall in to the black hole of every other issue people have had with injectGlobal
which caused them to deprecate it.
If you're interested in looking any further in to this go ahead but I'm happy to close it and move on and just wait until we are at a point that we can upgrade styled-components.
from playroom.
Any chance I could get a minimal reproduction of this issue somewhere?
from playroom.
I'll find somewhere to put the dist out on the internet for the time being, will let you know when/where it is once I figure that out.
E: Or did you want the src as well?
from playroom.
Source is more important, so I can have a poke around at the build.
from playroom.
Thanks for letting me see your usage—the reproduction is a bit heavy, though, so I don't really have the time to dig in. Are you able to create a new project and reproduce the issue there? It'll probably help you narrow down exactly what's wrong, too.
from playroom.
Yeah no probs, I'll have a look in to it tomorrow and see what I can pull out.
from playroom.
https://github.com/patrickmarabeas/nothing-to-see-here
Hopefully this is what you were looking for, it's only got our Text
component which depends on global styles, styled-components injectGlobal
doesn't appear to be applied which may be the issue here but not sure how to fix that with the StyleSheetManager
component.
from playroom.
Is this an issue with styled-components?
from playroom.
I think it could be, tried out manually running injectGlobal
in frame-component
as per https://stackoverflow.com/questions/45489383/how-to-inject-global-styles-while-rendering-server-side-with-styled-components?rq=1 but that didn't seem to do the trick, will keep digging.
from playroom.
Related Issues (20)
- Shared links are broken HOT 3
- Custom fonts/static assets HOT 4
- Reduce the gap showing TS errors 👀
- Checkbox logic could be improved
- componentsToHints breaks if `PlayRoomProps.components` file contains something other than a component
- Dark mode shadows
- React 18 support HOT 5
- v0.28.x fails on project using @vanilla-extract/next-plugin HOT 1
- v0.28.x HOT 2
- [Feature Request] Detach code panel to separate window
- Gitlab Addon HOT 1
- With prettier V3, opening code snippets generate an error HOT 1
- Feature Request: Support `Cmd + /` to comment out code
- Logistics of renaming frame.html to frame/index.html HOT 2
- Code given to frames aren't compressed HOT 6
- Editor for an additional css / scss file HOT 1
- Windows machine giving Error [ERR_UNSUPPORTED_ESM_URL_SCHEME]: from version 0.33.0 upwards HOT 1
- Unable to build playroom without a favicon HOT 1
- [Feature Request] Accessibility tool integrated in playroom HOT 1
- Playroom favicon is not customizable HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from playroom.