Add Bifunctor instance for PolyDiff about diff HOT 16 OPEN

I think we can abandon base older than 4.8.0.0. If someone complains I'll welcome a PR with ifdefs.

from diff.

Have you noticed any slowness in the diff function? I may have seen this when running in the browser via ghcjs.

from diff.

Have you noticed any slowness in the diff function? I may have seen this when running in the browser via ghcjs.

We're only using the getGroupedDiff function (on GHC 8.8.4 targeting x86) and it's only used as part of tests.
I haven't noticed it being particularly slow, but that said these tests are not something that we've profiled, as they're fast enough.

from diff.

I can do the CPP.

from diff.

@ddssff did you test it with GHC 9.6? I suspect instance Functor is missing.

from diff.

I don't have access to ghc-9.6. Stuck on 8.10.

from diff.

Sorry, I’m AFK until the next week. If you wish, once back home, I can generate a GitHub Actions CI setup with haskell-ci covering a range of GHCs up to 9.6.

from diff.

@ddssff could you possibly make a release some time soon?

from diff.

Hackage upload? Will do.

from diff.

Yes, please.

from diff.

Does O(ND) in the title refer to time or space complexity?

from diff.

Time is O(ND) and space is O(D^2).

I'm not sure "O(ND)" is terribly helpful as a top-level package description without explaining what D refers to. It might be helpful to bring Cabal "description:" field in line with the module header:

from diff.

How about this:

synopsis:            Diff algorithm in pure Haskell
description:         Implementation of the standard diff algorithm, and utilities for pretty printing.  Time complexity is proportional to N (input length) & D (number of differences).  Space complexity is D^2.

from diff.

Thanks for a quick turnaround with a release, really much appreciated.

How about this:

Looks great! And today I learned that one can edit package description via revision :)

from diff.

from diff.

I'm thinking of removing 'getContextDiffOld' - I can't see how it could be useful to anyone.

Makes sense to me.

from diff.