seereason / diff Goto Github PK

Great to have tags for v0.5 and v0.4 to automatically list the changes using the "compare" functionality.

For example, try getDiff (take 10000 (repeat 'a')) "" - it takes quite a while and returns (replicate 10000 (First 'a')).

The space complexity used to be O(mn) in Diff-0.1.*, but since Diff-0.2 is at most O(max(m,n)).

Upd.: Actually, maybe my mental model of snakes is wrong? I imagine that they share initial segments, but even if they don't at all, the absolutely worst case is O(n d), where d is a number of differences, which is still much better than O(m n).

The following Bifunctor instance would be very handy:

instance Bifunctor PolyDiff where
  bimap f _ (First a) = First (f a)
  bimap _ g (Second b) = Second (g b)
  bimap f g (Both a b) = Both (f a) (g b)

I appreciate supporting base >= 3 && <= 6 makes things slightly more complicated, as Bifunctor is only available since base-4.8.0.0. The two options I can think of are using a CPP macro, or increasing the minimum bounds of base.

I'm happy to open a PR with either approach (or something else!).

Thanks for keeping a changelog!

Please add it to the package so that it also displays on Hackage.