sefodopo / fabricautobackup Goto Github PK

might works like this:
/backup command add [custom id] [cmd/sh command]
add a command

/backup command remove [custom id]
remove a command

/backup now [custom id]
run a command

or any thing else

*It's better to be able to set the whitelist of who can use the "/backup command" command. It is extremely risky to allow all players or operators to control the server computer.

It seems like when it's backing up when the server is stopping, it kills the process before it finishes. The command I'm using to back up works outside Minecraft, but when run through AutoBackup on the server stopping, it stops early, leaving the backup incomplete.

crash-2021-08-12_16.40.13-server.txt

hey there, I'm getting this crash when I load up my instance.

https://pastebin.com/hHb1aNZ9

Thanks a bunch :)

When the backup script I use is called by the mod, players experience a short lag spike. This is perfectly normal, but they aren't warned of this beforehand, as the message signaling the start and completion of the backup are shown to ops only. It would be nice if there was a way to set up messages sent to all players in the configuration file. As an example, here is how I would see it:

• timeBeforePreBackupMessage: The amount of time in seconds before the backup where the server sends the pre-backup notice. Defaults to 10 seconds, disables the pre-backup warning entirely if set to 0 or less.
• preBackupMessage: A message sent to all players a certain amount of time before the backup happens, as set by timeBeforePreBackupMessage. Should support a {time} variable which would be replaced by the value of timeBeforePreBackupMessage when sent.
• backupStartMessage: A message sent to all players right as the backup happens.
• backupCompleteMessage: A message sent to all players right after the backup is complete.
• (Optionally) backupFailedMessage: A message sent to all players after a failed backup.

Additionally, a timer tied to these messages might be a nice feature to have:

• backupTimerMessage: A setting which sends messages counting down the time before backup. Should support a {remaining} variable which is replaced by however many seconds are left before the backup when the message is sent.
• skipFirstTimerMessage: An option which, if true, does not send the countdown message for the first iteration of the countdown. Useful if the backup message already mentions the time before backup. Defaults to true.
• backupTimerInterval: An option which sets how many seconds pass between each countdown message. For example, if timeBeforePreBackupMessage is set to 60 seconds, skipFirstCountdown is set to true, and this option is set to 10 seconds, the countdown will send a message at 50 seconds, 40, 30, 20, and 10 seconds. Defaults to 1, disables the countdown if zero, no effect if backupTimerMessage is empty.

Any of the message settings would be disabled if empty, which would be their default value. Ideally, the messages should support Minecraft formatting codes.

There is an issue of it not showing the text from my lang file on a server when the command is run.

I changed the Minecraft version constraint in fabric.mod.json inside the JAR, which gets it working in 1.18.

i.e. I unzipped the JAR, changed this line to "minecraft": "1.18.x", and zipped the JAR back up:

I did the same thing for https://github.com/LoganDark/fabric-languagehack

Dunno what changes are needed to do this the right way, but this quick hack got me running.
Maybe we can get by with more permissive version bounds on these two mods. (>=1.17.0?)

(side note: I would've built from source, but I ran into a could not resolve plugin artifact 'fabric-loom:fabric-loom.gradle.plugin:0.8-SNAPSHOT' on gradle build.)

After fixing #5 with #6 the backups now cause a warning message that the server is so many ms behind and ticks behind. If these ticks get too high, then the server may decide to crash.

TLDR: If the backup command takes too long to execute, it could crash the game.