Giter VIP home page Giter VIP logo

analytics-ios-integration-crittercism's Issues

this pod is causing me compile time errors

i have a swift 2.1 app already integrated with the segment pod working properly (tracks events and have other integrations enabled) but adding this pod is throwing the error in the screenshot.

screen shot 2016-01-27 at 11 41 05 am

Wrong class type for factory instance?

In the factory implementation's +instance class method shouldn't the sharedInstance type be SEGCrittercismIntegrationFactory instead of SEGCrittercismIntegration?

+ (id)instance
{
    static dispatch_once_t once;
    static SEGCrittercismIntegration *sharedInstance; // <-- THIS LINE
    dispatch_once(&once, ^{
        sharedInstance = [[self alloc] init]; // <-- self here is of SEGCrittercismIntegrationFactory
    });
    return sharedInstance;
}

If this is a bug, then it should be checked across all integrations as well because it's not just this integration that does this.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.