Giter VIP home page Giter VIP logo

Comments (11)

sekwah41 avatar sekwah41 commented on July 16, 2024

Wont be a high priority but I can explore it with the recode. Though my priority is getting the base features through first.

Is it not working with Folia or is it more optimising it for better performance?

from advanced-portals.

cgw2023 avatar cgw2023 commented on July 16, 2024

Wont be a high priority but I can explore it with the recode. Though my priority is getting the base features through first.

Is it not working with Folia or is it more optimising it for better performance?

Plugin cannot be enabled in folia platform
Folia is different from spigot/paper, it have alot of changes for multithreading, it is made by papermc team.

https://github.com/PaperMC/Folia

Folia is getting popular now

image

from advanced-portals.

sekwah41 avatar sekwah41 commented on July 16, 2024

Can you please try using the latest version of advanced portals? by the looks of it you are using a very old version.

0.9.+ would give me more feedback :)

from advanced-portals.

cgw2023 avatar cgw2023 commented on July 16, 2024

Can you please try using the latest version of advanced portals? by the looks of it you are using a very old version.

0.9.+ would give me more feedback :)

oh sorry i pressed the wrong version on modrinth

this is version 0.9.2 with error

image

logs:
https://mclo.gs/wf14aD4

Please help

from advanced-portals.

sekwah41 avatar sekwah41 commented on July 16, 2024

Ive had to prioritise other projects rn but im part way through a re-code of advanced portals, I can take a look to see why these dont work during that. Though if I get some time on the weekend I can try to pull it down and gauge how much work it would be to add this.

from advanced-portals.

sekwah41 avatar sekwah41 commented on July 16, 2024

Also given the error, there is a risk that it is Folia that is actually erroring, otherwise, the advanced portals Listeners class would be at the top of the stack trace.

Though it could be because I trigger it too early depending on whats going on, so ill have to experiment and see if its just a weird quirk of how Folia works, if it's broken on their end or if its something I can fix.

from advanced-portals.

sekwah41 avatar sekwah41 commented on July 16, 2024

I've added Folia support, at least a rough draft. Currently, Folia doesn't seem to properly Implement some of the nether portal events so avoid making nether portal portals until they have done that (even if you are on portal cooldown it'll still trigger as it doesn't fire at all).

It may require more events though folia should really make it support the current ones properly.

from advanced-portals.

sekwah41 avatar sekwah41 commented on July 16, 2024

Will be in next release likely tomorrow.

from advanced-portals.

sekwah41 avatar sekwah41 commented on July 16, 2024

Check out this if you want
Advanced Portals Folia.zip

from advanced-portals.

sekwah41 avatar sekwah41 commented on July 16, 2024

I may re-consider adding Folia support as it forces such a new Java requirement blocking off any earlier paper versions than 1.17. However, most of the userbase is on 1.16+ at least.

from advanced-portals.

sekwah41 avatar sekwah41 commented on July 16, 2024

Though with the recode I am mostly planning to support the latest versions with priority so that is fine likely going forward.

from advanced-portals.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.