Giter VIP home page Giter VIP logo

Comments (3)

hanseltime avatar hanseltime commented on June 24, 2024

I would love to know if this is a bug and if there is a reason that we're not allowing errors to trigger "fail" phases. If we can define the behavior expected, I am more than willing to contribute the fix.

From my end, I would expect all errors to get sent to the fail plugins. If that's not the case, I would also be okay with setting a config option like allErrorsTriggerFail command that would effectively feature flag the behavior.

from semantic-release.

travi avatar travi commented on June 24, 2024

would appreciate any further investigation into the issue that the community is willing to invest. it would be valuable to target defining an integration test for this situation as a result of the investigation. that would give us an executable definition to compare to other failures to help us determine how intentional this was. i expect that it is more likely an oversight, but a test would help us confirm.

from semantic-release.

hanseltime avatar hanseltime commented on June 24, 2024

Adding here that the PR above demonstrates the failure with a test. #3180

I can pull out the second commit to if we want it to fail as a matter of demonstration

from semantic-release.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.