semmypurewal / jermaine Goto Github PK

View Code? Open in Web Editor NEW

9.0 9.0 4.0 5.49 MB

yet another javascript modeling tool

License: Other

JavaScript 100.00%

jermaine's People

Contributors

Stargazers

Watchers

Forkers

dmfalke frimmel pseudothrax embeepea

jermaine's Issues

all attributes should default to null

All attributes should be initialized to null in a model. This helps remove some confusion that can be caused by them being set to undefined.

connect to a view system

Figure out a way to have Jermaine objects renderable via a view system like Handlebar or Mustache. The API should be really simple, preferably something like this:

Person.looksLike("template.js");

where template.js is a template file in a separate (views?) directory. The simpler the API, the better.

addTo method of attr.js should throw an error if it attempts to override an existing method or attribute in the class

This isn't happening yet because of our approach to implementing inheritance and making the instanceof operator work. We set the prototype to an instance of the super-model but then override each individual attribute with an actual cloned attribute. This is necessary to maintain encapsulation of the attribute.

We'll have to re-think our approach slightly to make this work.

attach methods to prototype not instance

Something like:

model.prototype[methodName] = methodBody

in model.respondsTo

Yet another bug/failing test

This test seems to fail:

    it("another bug?", function () {
        var Person,
    p, p1, p2, p3, p4;
        Person = new Model(function () {
            this.hasA("name").which.isA("string");
            this.hasMany("friends").eachOfWhich.validateWith(function (friend) {
                return friend instanceof Person;
            });
        });

        expect(function () {
            p = new Person("Semmy");
    }).not.toThrow();
    });

Automated Documentation

Use JSDoc or something similar to generate HTML documentation for Jermaine's public API, particularly the Model function and Model objects.

add javascript-style constructors

Allow an option for the user to use JavaScript style constructors for model instances, e.g.

var p = new Person({"name":"Semmy", "id":1001});

Instances of models should not have all EventEmitter attached directly to them

Right now an instance of a model gets all of the methods associated with an EventEmitter. Those should be hidden within the object, with the exception of the 'on' method.

If we decide we need more explicit access to the emitter for instances, we can create a 'getter' called 'emitter'.

constructor should throw an error if defaultsTo is a function returning null and null doesn't pass the validator

This test fails:

it("should throw an error if the defaultValue is a function that returns null and null doesn't  pass the validator", function   () {
        var Person = new Model(function () {
            this.hasA("name").which.validatesWith(function (name) {
                return typeof(name) === "string";
            });
        });

        expect(function () {
            p = new Person();
    }).toThrow();
});

attributes are emitting events to all instances of objects

This test is failing.

var p1, p2;
p1 = new Person();
p2 = new Person();
expect(spy1.callCount).toBe(0);
expect(spy2.callCount).toBe(0);

p1.on("change", spy1);
p2.on("change", spy2);

p1.name("semmy");
expect(spy1.callCount).toBe(1);
expect(spy2.callCount).toBe(0);

Needs to emit an event if an element in a submodel's list changes

Need to come up with a concrete example for this.

toJSON throwing error when model contains a null value

This test is failing

        it("should not throw an error when called on a null value", function () {
            var p = new Person();
            p.nullValue(null);

    expect(function () {
                p.toJSON();
            }).not.toThrow();
        });

Attributes/Models should emit events on changes

removeAt

add attr_list removeAt() met hod

add new validators

add built-in validators for 'matches' (regexp) and 'isInRange'

Failing tests in IE8

Versions of IE prior to 9 do not have an implementation of Array.indexOf().

Issue arises in Validator.js -> isA

Documentation

The documentation needs to be updated. Also, inline documentation needs to be added to all core objects.

pop not working in attr_list

This jasmine test is failing

describe("pop method", function () {
    it("should return the object which was popped", function () {
        var lastObj = "mark",
            poppedObj;
        obj.friends().add("john");
        obj.friends().add("semmy");
        obj.friends().add(lastObj);
        poppedObj = obj.friends().pop();
        expect(poppedObj).toEqual(lastObj);
    });

    it("should decrease the size of the attr_list", function () {
        var size;
        obj.friends().add("john");
        obj.friends().add("semmy");
        obj.friends().add("mark");
        size = obj.friends().size();
        obj.friends().pop();
        expect(obj.friends().size()).toEqual(size-1);
    });
});

        var p1, p2;
        p1 = new Person();
        p2 = new Person();

        expect(spy1.callCount).toBe(0)
        expect(spy2.callCount).toBe(0)

        p1.on("change", spy1);

        p2.on("change", spy2);

        p1.friend(p2);

        expect(spy1.callCount).toBe(1);
        expect(spy2.callCount).toBe(0);

        //causes infinite loop                                                                                                                                                                          
        p2.friend(p1);

attr_list ordering

remove ordering from attr_list, add whichIsOrdered() or some such