Giter VIP home page Giter VIP logo

semux-keeper-extension's People

Contributors

dinc334 avatar honeycrypto avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar

semux-keeper-extension's Issues

Don't allow to import existing account

When user tries to import already existing account via privkey or json file, we should notify him that account already exists and don't create duplicates in the wallet.

Add lock button

Show "welcome" page. Require user password to unlock app.

Disallow different passwords for accounts

Right now user can create new accounts with a different passwords. This may be very confusing UX because users will have to backup both passwords and private keys. Maybe we should force user to use same password as he used for created/imported account 0.

Since we don't store passwords, the flow can be as follows:

  1. Ask for a password to create new account
  2. Verify if this password can successfully decrypt address 0 from storage.
  3. Throw error "Invalid Password" if user tried to use a new password.

Thoughts?

Changes to list of transactions

Show pending outgoing transactions in the list because right now it's not clear if the TX was successfully broadcasted to the network.
Order transactions by date: most recent ones on the top.

Code refactoring is needed

There are some duplicated pieces of code which should be moved to helpers.
All promises must reject in case of errors.
try catch is required for all requests to remote servers (semux node, exchanges, other)
Move all hardcoded constants (URLs, min fee, ..) to a config file.
Code review.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.