sendgrid / krampus Goto Github PK

we feel the tasks stuff would be better suited as a SQS queue. should scale up better than the json file and also let us action jobs when they are due rather than at the nearest timed cloudtrigger event.

>>> try:
...     raise ValueError
... except Exception as e:
...     print("could not delete function '%s', unknown error: %s" % str(e))
... 
Traceback (most recent call last):
  File "<input>", line 2, in <module>
ValueError

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "<input>", line 4, in <module>
TypeError: not enough arguments for format string

# minimal example
>>> "could not delete function '%s', unknown error: %s" % "Exception string..."
Traceback (most recent call last):
  File "<input>", line 1, in <module>
TypeError: not enough arguments for format string

It seems like adding self.func as the first string might be the answer:

KLog.log("could not delete function '%s', unknown error: %s" % (self.func, str(e)), "critical")

The intro blog post describes how this is used with Security Monkey. Can you provide more details on how that is done? Ideally in code, but at least a description?

it has been determined that it might be nice to handle an array of s3 perms to delete rather than making them all break out into separate jobs. make it do that.

Issue Summary

Virtualenv docs should include a python environment version. Otherwise, the pathing in the ./mkdist script fails without a clear resolution. This will be common as more package managers default to installing python3 over python2

Without providing more explicit clarity within the venv setup, this will cause confusion.

Steps to Reproduce

1. ensure default python is set to Python 3+
2. $ virtualenv venv
3. $ source venv/bin/activate
4. $ pip install -r requirements.txt
5. $ ./mkdist

Technical details:

• krampus Version: master
• Python Version: 3.6