senecajs-labs / seneca-queue Goto Github PK

In case of errors from the remote server the seneca instance die because of fatal$ being true in plugins for seneca 0.6, 0.7, 0.8.

Mocha is a missing dep when running the tests :)

It should use fastq or steed, which are much faster than async.queue. The API is the same, so it should be an easy fix.

i used your examples, only started 1 server, put the client in an interval loop.
kept getting errors for the server that wasn't up.
i see a blacklist in your code, but maybe it's not used for this purpose. if it is then it's failing.

after a minute or so my client crashes.

maybe the queue should kick clients out that error.

Trello Card

At the moment external queue implementation are discovered automatically by searching for registered actions with the appropriate "hook" pattern. Requests are then distributed among found implementations with a round robin algorithm.

I think this may cause two problems:

• seneca queue can't pass options to the external implementations leaving the burden to to so to the final users, which is counter intuitive (especially when changing "role")
• this makes difficult to have different implementations at the same time - because seneca-queue split the requests among all the different implementations. It could be useful to allow the split to be based on the task type

We may also want to create a seneca-queue-test package to check for queues conformity (along the lines of seneca-store-test and seneca-transport-test)

how to return error/success value callback from server??
I have return with certain parameters but it get undefined
Ex-
Client.js
var s = require('seneca')()
.client({ port: 8081, pin: 'cmd:enqueue-remote,queue:q1' })
.use('../', {
queues: ['q1', 'q2']
})
var res_cb=function(err,success){
console.log("Success",success);
}
s.act({ role: 'queue', cmd: 'enqueue', msg: { task: 'my task', param: 1 ,count:1}},res_cb);

Server1.js
var s = require('seneca')()
.use(require('../'))
.listen({ port: 8081 })

s.add({
task: 'my task'
}, function(args, cb) {
return cb(null, { b: 2 })
})

console.log('worked if you see OK two times')
s.act({ role: 'queue', cmd: 'start' })

Output of client.js
Success undefined

The returned value gets undefined. can you please suggest any way to achieive these.

Thanks,
Jayesh